<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103664/">http://git.reviewboard.kde.org/r/103664/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By C. Boemann.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Before newyear i removed some characters that shouldn't be there when we load
However that broke lineheights of empty lines. I have now analysed LO/OO and coded the same behaviour into
Calligra. The filters will have to follow, but at least the last line thing is the same as the filters do
Anyway here is the commit msg:
Make the line heights work like LibreOffice/OpenOffice when in combination with line breaks
1) a blank line is affected by the line break after
2) a line with contents is not affected by the linebreak
3) following line is never affected by the line break
4) a final line if blank can have it's height specified by a special textstyle
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I've loaded and saved a file and roundtrips
I've added a unit test plus done manual testing</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/kotext/opendocument/KoTextLoader.cpp <span style="color: grey">(eb9c677)</span></li>
<li>libs/kotext/opendocument/KoTextWriter_p.cpp <span style="color: grey">(0d04bcb)</span></li>
<li>libs/kotext/styles/KoCharacterStyle.h <span style="color: grey">(c13972c)</span></li>
<li>libs/kotext/styles/KoParagraphStyle.h <span style="color: grey">(bccc252)</span></li>
<li>libs/textlayout/KoTextLayoutArea.cpp <span style="color: grey">(aef7357)</span></li>
<li>libs/textlayout/tests/TestBlockLayout.h <span style="color: grey">(1286629)</span></li>
<li>libs/textlayout/tests/TestBlockLayout.cpp <span style="color: grey">(5216d78)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103664/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>