<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103402/">http://git.reviewboard.kde.org/r/103402/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 2nd, 2012, 9:03 p.m., <b>Jarosław Staniek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/103402/diff/3/?file=45246#file45246line42" style="color: black; font-weight: bold; text-decoration: underline;">plugins/pictureshape/PictureShape.h</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">namespace _Private</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">41</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="n">namespace</span> <span class="n">_Private</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Is this how we agreed to mark private namespaces?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I don't understand. What do you mean?</pre>
<br />
<p>- Silvio</p>
<br />
<p>On January 2nd, 2012, 4:08 p.m., Silvio Heinrich wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Silvio Heinrich.</div>
<p style="color: grey;"><i>Updated Jan. 2, 2012, 4:08 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It's a feature meant to be applied after the release is out.
It adds a GUI to the pictureshape tool for cropping and setting the color mode.
The scaling of the loaded picture is done in a background thread.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plugins/pictureshape/CMakeLists.txt <span style="color: grey">(5e6c922)</span></li>
<li>plugins/pictureshape/ChangeImageCommand.h <span style="color: grey">(44244d4)</span></li>
<li>plugins/pictureshape/ChangeImageCommand.cpp <span style="color: grey">(66decc4)</span></li>
<li>plugins/pictureshape/ClippingRect.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/pictureshape/ClippingRect.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/pictureshape/CropWidget.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/pictureshape/CropWidget.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/pictureshape/GreyscaleFilterEffect.h <span style="color: grey">(e858599)</span></li>
<li>plugins/pictureshape/GreyscaleFilterEffect.cpp <span style="color: grey">(ed8032f)</span></li>
<li>plugins/pictureshape/MonoFilterEffect.h <span style="color: grey">(2696378)</span></li>
<li>plugins/pictureshape/MonoFilterEffect.cpp <span style="color: grey">(115b068)</span></li>
<li>plugins/pictureshape/PictureShape.h <span style="color: grey">(fc3c221)</span></li>
<li>plugins/pictureshape/PictureShape.cpp <span style="color: grey">(68eeb6a)</span></li>
<li>plugins/pictureshape/PictureShapeConfigWidget.h <span style="color: grey">(7249e7b)</span></li>
<li>plugins/pictureshape/PictureShapeConfigWidget.cpp <span style="color: grey">(a85e764)</span></li>
<li>plugins/pictureshape/PictureTool.h <span style="color: grey">(5c1dd5f)</span></li>
<li>plugins/pictureshape/PictureTool.cpp <span style="color: grey">(aef9304)</span></li>
<li>plugins/pictureshape/SelectionRect.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/pictureshape/SelectionRect.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/pictureshape/WatermarkFilterEffect.h <span style="color: grey">(f8a5b05)</span></li>
<li>plugins/pictureshape/WatermarkFilterEffect.cpp <span style="color: grey">(513d44f)</span></li>
<li>plugins/pictureshape/filters/GreyscaleFilterEffect.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/pictureshape/filters/GreyscaleFilterEffect.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/pictureshape/filters/MonoFilterEffect.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/pictureshape/filters/MonoFilterEffect.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/pictureshape/filters/WatermarkFilterEffect.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/pictureshape/filters/WatermarkFilterEffect.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/pictureshape/forms/wdgPictureTool.ui <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103402/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>