<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103568/">http://git.reviewboard.kde.org/r/103568/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 16bc36adc6a6ead69e21e98e770411a7d6a8da81 by Thorsten Zachmann to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On December 29th, 2011, 1:26 p.m., Thorsten Zachmann wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Thorsten Zachmann.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Don't strip spaces during loading of the xml. This uses the work of review request #101857 which makes it possible to not strip the spaces.
In the following line from the document in the bug report we don't get the space between <text:line-break/> <text:s/>
<text:p text:style-name="Standard">abc <text:s text:c="4"/>5 space<text:line-break/> 1 space<text:line-break/> <text:s/>2 space<text:line-break/> <text:s text:c="2"/>3 space<text:line-break/> <text:s text:c="3"/>4 space<text:line-break/> <text:s text:c="4"/>5 space</text:p>
and therefore we loose the the space on loading.
The patch also fixes all occurrences where xml was handled wrongly. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Run cstester and fixed all problems that showed regressions. The left over changes fix bugs where we lost blanks before.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=290091">290091</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>filters/libmsooxml/MsooXmlCommonReaderDrawingMLImpl.h <span style="color: grey">(d64e330)</span></li>
<li>filters/words/docx/DocxXmlDocumentReader.cpp <span style="color: grey">(3fa7294)</span></li>
<li>libs/flake/KoShapeRegistry.cpp <span style="color: grey">(13c6889)</span></li>
<li>libs/odf/KoXmlReader.h <span style="color: grey">(8a09912)</span></li>
<li>libs/odf/KoXmlWriter.cpp <span style="color: grey">(ae336e6)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103568/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>