<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103276/">http://git.reviewboard.kde.org/r/103276/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 28th, 2011, 6:53 a.m., <b>Thorsten Zachmann</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/103276/diff/1/?file=42280#file42280line137" style="color: black; font-weight: bold; text-decoration: underline;">libs/kotext/KoVariableManager.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void KoVariableManager::loadOdf(const KoXmlElement &bodyElement)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">130</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">KoXmlElement</span> <span class="n">element</span> <span class="o">=</span> <span class="n">KoXml</span><span class="o">::</span><span class="n">namedItemNS</span><span class="p">(</span><span class="n">bodyElement</span><span class="p">,</span> <span class="n">KoXmlNS</span><span class="o">::</span><span class="n">text</span><span class="p">,</span> <span class="s">"user-field-decls"</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This should not use namedItemNS as this will iterate over all elements which can be very long for big documents. It should use a for loop and quit it when it found the first element that should be after user-field-decls. Doing that way will not cause a slowdown in loading documents.</pre>
</blockquote>
<p>On November 28th, 2011, 1:48 p.m., <b>Sebastian Sauer</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Will change later in the next iteration.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Addressed with commit 0b5253e5fd14c4b96d40b5d943ee14366e7078d5</pre>
<br />
<p>- Sebastian</p>
<br />
<p>On November 27th, 2011, 3:54 p.m., Sebastian Sauer wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra and Thorsten Zachmann.</div>
<div>By Sebastian Sauer.</div>
<p style="color: grey;"><i>Updated Nov. 27, 2011, 3:54 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Following patch implements user defined variables. This solves bug https://bugs.kde.org/show_bug.cgi?id=282972
What I did;
* extended the KoVariableManager to handle now also such user defined variables.
* the KoVariableManager now has loadOdf and saveOdf methods to load and save user defined variables declarations.
* the user defined variables are implemented using the new plugins/variables/User* classes.
* KoVariable::manager() can now be used even on KoVariable::createOptionsWidget
* replaced the previous unused KoInlineObject::User with KoInlineObject::UserGet and KoInlineObject::UserInput and make use of them
* extended KoTextLoader.cpp to proper load user defined variables into the KoVariableManager. Instances are created using the new UserVariable plugin.
* extended KoOdfNumberStyles with the formatFraction method. Ideally I would also move the other format (e.g. formatDate, formatTime, etc.) methods from the plugin to the KoOdfNumberStyles class to have it reusable (we at least need formatDate and KoOdfNumberStyles also in the DateVariable later).
* added the KoOdfNumberStyles::saveOdfBooleanStyle to also save boolean formattings proper back.
* introduced the KoOdfNumberStyles::saveOdfNumberStyle method to handle choosing the proper KoOdfNumberStyles::saveOdf*Style methods.
* extended KWOdfWriter.cpp to proper save the user defined variable declarations back to the ODT.
Remaining problems;
* there is no way to add/edit/remove/display such user defined variables in Calligra Tables. Seems oocalc has the same problem.
* the UI still misses a way to set/modify custom formatings.
* support for formulas... but this is another beast and partly already covered at bug 283816. I do not plan to work on this anytime soon.
Update to the first review-request at https://git.reviewboard.kde.org/r/102890/ ;
* loading of the variables happens now not any longer in the KoTextLoader but in the applications themself right after loading the body-element what is inline with how saving is done.
* the same logic is applied to Calligra Words, Stage and Tables what means all 3 of them support now loading and saving of user defined variables. Editing can be done direct in the Insert=>Variable=>Custom (should we better rename it to "User defined" rather then "Custom"?) dialog what is inline with how it can be done in OO.org/LO.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">see the documents attached to bug 282972</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/kopageapp/KoPADocument.cpp <span style="color: grey">(43e002a)</span></li>
<li>libs/kotext/InsertVariableAction.cpp <span style="color: grey">(de68bbf)</span></li>
<li>libs/kotext/KoInlineObject.h <span style="color: grey">(fbd1795)</span></li>
<li>libs/kotext/KoVariableManager.h <span style="color: grey">(680a29b)</span></li>
<li>libs/kotext/KoVariableManager.cpp <span style="color: grey">(a915b77)</span></li>
<li>libs/kotext/tests/TestKoInlineTextObjectManager.cpp <span style="color: grey">(5bafc82)</span></li>
<li>libs/odf/KoOdfNumberStyles.h <span style="color: grey">(536408d)</span></li>
<li>libs/odf/KoOdfNumberStyles.cpp <span style="color: grey">(5611465)</span></li>
<li>libs/odf/tests/CMakeLists.txt <span style="color: grey">(a1c71dc)</span></li>
<li>libs/odf/tests/TestNumberStyle.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/odf/tests/TestNumberStyle.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/variables/CMakeLists.txt <span style="color: grey">(cca8198)</span></li>
<li>plugins/variables/UserVariable.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/variables/UserVariable.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/variables/UserVariableFactory.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/variables/UserVariableFactory.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/variables/VariablesPlugin.cpp <span style="color: grey">(913aebc)</span></li>
<li>tables/DocBase.h <span style="color: grey">(daf758e)</span></li>
<li>tables/DocBase.cpp <span style="color: grey">(adb9940)</span></li>
<li>words/part/KWAboutData.h <span style="color: grey">(68e9a6f)</span></li>
<li>words/part/KWOdfLoader.cpp <span style="color: grey">(837280a)</span></li>
<li>words/part/KWOdfWriter.cpp <span style="color: grey">(ebfdad9)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103276/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>