<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103044/">http://git.reviewboard.kde.org/r/103044/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra, Marijn Kruisselbrink and Sebastian Sauer.</div>
<div>By Lukáš Tvrdý.</div>
<p style="color: grey;"><i>Updated Nov. 22, 2011, 5 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">o fixed the regressions found on bigger testing set ~3576 xls files (tested with cstester many times)
-Z-index was not working correctly for ODraw objects and thus new code path exposed the bug, see bug 286607
o fixed issues pointed out by Jaroslaw
Know issue:
o I removed end-x, end-y in xls filter for pictures temporary. Will be fixed in different patchset
You can test the code in branch tables-filter-fix-pictures-ltvrdy
I want to merge it to the master as this patchset improves radically the situation with pictures and shapes in xls files.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch uses more of the libmso in excel filter.
So far the pictures were handled as PictureObject class. One problem was that
there was no support for groups for this object. So when you put two images into groups, they
are not displayed because the anchoring information is saved in different data-structure - in the
group structure.
Now I let the records to be handled by libmso, which provides this functionality.
It supports groups and even graphical styles like like borders etc.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I did regression testing against master. My testing set consists of 976 xls files.
I found only positive changes.
Missing frames around pictures are displayed now, missing images are displayed now.
You can test the document.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=244862">244862</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=262865">262865</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=286607">286607</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>filters/libmso/ODrawToOdf.h <span style="color: grey">(0016f8b)</span></li>
<li>filters/libmso/pictures.cpp <span style="color: grey">(f8bfa7c)</span></li>
<li>filters/libmso/shapes.cpp <span style="color: grey">(db001ee)</span></li>
<li>filters/tables/excel/import/ExcelImport.cpp <span style="color: grey">(0f361a4)</span></li>
<li>filters/tables/excel/import/ODrawClient.h <span style="color: grey">(83ed45c)</span></li>
<li>filters/tables/excel/import/ODrawClient.cpp <span style="color: grey">(5a6507b)</span></li>
<li>filters/tables/excel/import/excelimporttoods.cc <span style="color: grey">(287aef7)</span></li>
<li>filters/tables/excel/sidewinder/cell.h <span style="color: grey">(f9f7fc3)</span></li>
<li>filters/tables/excel/sidewinder/cell.cpp <span style="color: grey">(0be93c3)</span></li>
<li>filters/tables/excel/sidewinder/excel.h <span style="color: grey">(2be1f5a)</span></li>
<li>filters/tables/excel/sidewinder/excel.cpp <span style="color: grey">(92d4a41)</span></li>
<li>filters/tables/excel/sidewinder/globalssubstreamhandler.h <span style="color: grey">(77c6e3a)</span></li>
<li>filters/tables/excel/sidewinder/globalssubstreamhandler.cpp <span style="color: grey">(f9c03b1)</span></li>
<li>filters/tables/excel/sidewinder/objects.h <span style="color: grey">(2412f07)</span></li>
<li>filters/tables/excel/sidewinder/objects.cpp <span style="color: grey">(ea60560)</span></li>
<li>filters/tables/excel/sidewinder/sheet.h <span style="color: grey">(060e52e)</span></li>
<li>filters/tables/excel/sidewinder/sheet.cpp <span style="color: grey">(b6ecc82)</span></li>
<li>filters/tables/excel/sidewinder/workbook.h <span style="color: grey">(2e3c2fa)</span></li>
<li>filters/tables/excel/sidewinder/workbook.cpp <span style="color: grey">(9ad61bc)</span></li>
<li>filters/tables/excel/sidewinder/worksheetsubstreamhandler.cpp <span style="color: grey">(2b258ae)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103044/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>