<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103017/">http://git.reviewboard.kde.org/r/103017/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 6th, 2011, 2:01 p.m., <b>Jarosław Staniek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/103017/diff/4/?file=40367#file40367line2104" style="color: black; font-weight: bold; text-decoration: underline;">libs/kotext/styles/KoCharacterStyle.cpp</a>
<span style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void KoCharacterStyle::saveOdf(KoGenStyle &style)</pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void KoCharacterStyle::saveOdf(KoGenStyle &style) const</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">2067</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">return</span> <span class="n">d</span><span class="o">-></span><span class="n">defaultStyle</span><span class="o">-></span><span class="n">value</span><span class="p">(</span><span class="n">key</span><span class="p">);</span> <span class="p">}</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">misplaced "}"</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">i'll fix</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 6th, 2011, 2:01 p.m., <b>Jarosław Staniek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/103017/diff/4/?file=40370#file40370line677" style="color: black; font-weight: bold; text-decoration: underline;">libs/kotext/styles/KoParagraphStyle.h</a>
<span style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">public:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">672</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="kt">void</span> <span class="n">loadOdf</span><span class="p">(</span><span class="k">const</span> <span class="n">KoXmlElement</span> <span class="o">*</span><span class="n">element</span><span class="p">,</span> <span class="n">KoShapeLoadingContext</span> <span class="o">&</span><span class="n">context</span><span class="p"><span class="hl">);</span></span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">675</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="kt">void</span> <span class="n">loadOdf</span><span class="p">(</span><span class="k">const</span> <span class="n">KoXmlElement</span> <span class="o">*</span><span class="n">element</span><span class="p">,</span> <span class="n">KoShapeLoadingContext</span> <span class="o">&</span><span class="n">context</span><span class="p"><span class="hl">,</span></span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Extra bool arg is not good API, one day we'll remove all. Would be nice to avoid adding new signatures like this.
How about this: split to two methods:
void loadOdf(const KoXmlElement *element, KoShapeLoadingContext &context)
void loadOdfWithParents(const KoXmlElement *element, KoShapeLoadingContext &context)
(and move the original method to internal helper)</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">i guess, i mean i dont disagreee
it's just that we already know that styles need a big api restructure anyway so there isn't much point and this was the road of least trouble
i'll give it some thought</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 6th, 2011, 2:01 p.m., <b>Jarosław Staniek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/103017/diff/4/?file=40374#file40374line159" style="color: black; font-weight: bold; text-decoration: underline;">libs/kotext/styles/KoTableCellStyle.h</a>
<span style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">public:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">159</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="kt">void</span> <span class="n">setCharacterStyle</span><span class="p">(</span><span class="n">KoCharacterStyle</span> <span class="o">*</span><span class="n">style</span><span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">152</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">KoParagraphStyle</span> <span class="o">*</span><span class="n">paragraphStyle</span><span class="p">();</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">cannot be const?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">well it's returning an internal member and yes that is bad
and yes that is part of the needed api restructure too</pre>
<br />
<p>- C.</p>
<br />
<p>On November 6th, 2011, 9:47 a.m., C. Boemann wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By C. Boemann.</div>
<p style="color: grey;"><i>Updated Nov. 6, 2011, 9:47 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fix inheritance in paragraph styles
introduce inheritance in character styles</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">cstester, show some improvements and some regressions</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/kotext/KoTextDebug.cpp <span style="color: grey">(45df678)</span></li>
<li>libs/kotext/KoTextEditor.cpp <span style="color: grey">(91dc334)</span></li>
<li>libs/kotext/opendocument/KoTextLoader.cpp <span style="color: grey">(fc7b764)</span></li>
<li>libs/kotext/opendocument/KoTextSharedLoadingData.h <span style="color: grey">(320db92)</span></li>
<li>libs/kotext/opendocument/KoTextSharedLoadingData.cpp <span style="color: grey">(c1991bc)</span></li>
<li>libs/kotext/opendocument/KoTextWriter_p.cpp <span style="color: grey">(e9f1414)</span></li>
<li>libs/kotext/opendocument/tests/TestLoadStyle.cpp <span style="color: grey">(37d39fd)</span></li>
<li>libs/kotext/opendocument/tests/TestLoading.cpp <span style="color: grey">(222fb81)</span></li>
<li>libs/kotext/styles/KoCharacterStyle.h <span style="color: grey">(53e98a1)</span></li>
<li>libs/kotext/styles/KoCharacterStyle.cpp <span style="color: grey">(665e066)</span></li>
<li>libs/kotext/styles/KoListLevelProperties.cpp <span style="color: grey">(4a35398)</span></li>
<li>libs/kotext/styles/KoListStyle.h <span style="color: grey">(aadeb0f)</span></li>
<li>libs/kotext/styles/KoParagraphStyle.h <span style="color: grey">(3f9f40c)</span></li>
<li>libs/kotext/styles/KoParagraphStyle.cpp <span style="color: grey">(cdf16a4)</span></li>
<li>libs/kotext/styles/KoStyleManager.h <span style="color: grey">(ac145f9)</span></li>
<li>libs/kotext/styles/KoStyleManager.cpp <span style="color: grey">(fbbc4ee)</span></li>
<li>libs/kotext/styles/KoTableCellStyle.h <span style="color: grey">(9ba0c3a)</span></li>
<li>libs/kotext/styles/KoTableCellStyle.cpp <span style="color: grey">(eb96cf9)</span></li>
<li>libs/kotext/styles/KoTableCellStyle_p.h <span style="color: grey">(c38556b)</span></li>
<li>libs/kotext/styles/tests/TestOpenDocumentStyle.cpp <span style="color: grey">(be46779)</span></li>
<li>libs/kotext/styles/tests/TestStyles.cpp <span style="color: grey">(ea7a434)</span></li>
<li>libs/textlayout/KoTextLayoutArea.cpp <span style="color: grey">(28e4141)</span></li>
<li>plugins/chartshape/Axis.cpp <span style="color: grey">(d2a82ba)</span></li>
<li>plugins/textshape/TextShape.cpp <span style="color: grey">(cbd9593)</span></li>
<li>plugins/textshape/TextTool.cpp <span style="color: grey">(e699319)</span></li>
<li>plugins/textshape/dialogs/StyleManager.cpp <span style="color: grey">(6110044)</span></li>
<li>plugins/textshape/dialogs/StylesModel.cpp <span style="color: grey">(168ef715)</span></li>
<li>tables/Cell.cpp <span style="color: grey">(378fa03)</span></li>
<li>tables/Map.cpp <span style="color: grey">(956b3e1)</span></li>
<li>words/part/KWDocument.cpp <span style="color: grey">(1941d7a)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103017/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>