<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103003/">http://git.reviewboard.kde.org/r/103003/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks for the fix! =)
Just two small things:
1) I think it would be logical to reset the stroke id right after endStroke(m_strokeId) in mouseReleaseEvent() function. Like:
image->endStroke(m_strokeId);
m_strokeId.clear();
2) And we are using kde coding style for positioning braces around 'if's ;) [1]
[1] - http://techbase.kde.org/Policies/Kdelibs_Coding_Style</pre>
<br />
<p>- Dmitry</p>
<br />
<p>On October 31st, 2011, 7:26 p.m., Torio Mlshi wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Torio Mlshi.</div>
<p style="color: grey;"><i>Updated Oct. 31, 2011, 7:26 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">When image is empty (has no layers), color picker & move tools caused crashes when using. This patch adds checking if currentNode() returns 0. If so, no action is done.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>krita/plugins/tools/defaulttools/kis_tool_colorpicker.cc <span style="color: grey">(006aa78)</span></li>
<li>krita/plugins/tools/defaulttools/kis_tool_move.cc <span style="color: grey">(1ee0baa)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103003/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>