<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102837/">http://git.reviewboard.kde.org/r/102837/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/102837/diff/1/?file=38640#file38640line48" style="color: black; font-weight: bold; text-decoration: underline;">tools/converter/koconverter.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">bool convert( const KUrl & uIn, const QString & /*inputFormat*/, const KUrl & uOut, const QString & outputFormat, const bool batch )</pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">35</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="kt">bool</span> <span class="n">convert</span><span class="p">(</span> <span class="k">const</span> <span class="n">KUrl</span> <span class="o">&</span> <span class="n">uIn</span><span class="p">,</span> <span class="k">const</span> <span class="n">QString</span> <span class="o">&</span> <span class="cm"><span class="hl">/*</span>inputFormat<span class="hl">*/</span></span><span class="p">,</span> <span class="k">const</span> <span class="n">KUrl</span> <span class="o">&</span> <span class="n">uOut</span><span class="p">,</span> <span class="k">const</span> <span class="n">QString</span> <span class="o">&</span> <span class="n">outputFormat</span><span class="p">,</span> <span class="k">const</span> <span class="kt">bool</span> <span class="n">batch</span> <span class="p">)</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">48</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="kt">bool</span> <span class="n">convert</span><span class="p">(</span> <span class="k">const</span> <span class="n">KUrl</span> <span class="o">&</span> <span class="n">uIn</span><span class="p">,</span> <span class="k">const</span> <span class="n">QString</span> <span class="o">&</span> <span class="n">inputFormat</span><span class="p">,</span> <span class="k">const</span> <span class="n">KUrl</span> <span class="o">&</span> <span class="n">uOut</span><span class="p">,</span> <span class="k">const</span> <span class="n">QString</span> <span class="o">&</span> <span class="n">outputFormat</span><span class="p">,</span> <span class="k">const</span> <span class="kt">bool</span> <span class="n">batch</span> <span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">const for bool not needed (I know this was already there but this is opportunity to fix ;)</pre>
</div>
<br />
<p>- Jarosław</p>
<br />
<p>On October 12th, 2011, 2:21 p.m., Dan Leinir Turthra Jensen wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Dan Leinir Turthra Jensen.</div>
<p style="color: grey;"><i>Updated Oct. 12, 2011, 2:21 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">As subject indicates. Using the pdf printing functionality, add support for converting documents to pdf using koconverter.
Furthermore, though this patch does not include it (it pollutes the patch with too many extraneous lines), this also changes the application binary name from koconverter to calligraconverter. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Testing with various documents, all converting accurately to pdf format</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>tools/converter/CMakeLists.txt <span style="color: grey">(d3fee33)</span></li>
<li>tools/converter/koconverter.cpp <span style="color: grey">(abf2a58)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102837/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>