<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102790/">http://git.reviewboard.kde.org/r/102790/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 6th, 2011, 3:03 p.m., <b>Matus Uzak</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/102790/diff/1/?file=37953#file37953line134" style="color: black; font-weight: bold; text-decoration: underline;">filters/words/msword-odf/wv2/src/olestorage.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">49</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">return</span> <span class="n">m_storage</span><span class="o">-></span><span class="n">open</span><span class="p">();</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You could check if the storage is fine.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">We already test to see whether m_storage is not null, Storage::open() returns the boolean result from StorageIO::open(), which checks whether the operation is permitted.</pre>
<br />
<p>- Stuart</p>
<br />
<p>On October 6th, 2011, 1:11 p.m., Stuart Dickson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Stuart Dickson.</div>
<p style="color: grey;"><i>Updated Oct. 6, 2011, 1:11 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Removing libgsf dependency from msword-odf filter, replacing with existing POLE support in libmso.
Using olestream and olestorage within wv2/src as a Facade to Pole.
Cleaned up these classes, removing unused members.
Some more cleanup changes in separate commits.
This change makes msword-odf compile on Windows for the first time.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Loaded documents and run cstester for comparison against previous, libgsf version.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>filters/words/CMakeLists.txt <span style="color: grey">(e5f0d64)</span></li>
<li>filters/words/msword-odf/CMakeLists.txt <span style="color: grey">(a6dd0cb)</span></li>
<li>filters/words/msword-odf/document.cpp <span style="color: grey">(3dcabf6)</span></li>
<li>filters/words/msword-odf/graphicshandler.cpp <span style="color: grey">(f2f9519)</span></li>
<li>filters/words/msword-odf/msdoc.h <span style="color: grey">(460c5c4)</span></li>
<li>filters/words/msword-odf/paragraph.cpp <span style="color: grey">(f7988de)</span></li>
<li>filters/words/msword-odf/tablehandler.h <span style="color: grey">(18167df)</span></li>
<li>filters/words/msword-odf/tablehandler.cpp <span style="color: grey">(8b290e9)</span></li>
<li>filters/words/msword-odf/texthandler.h <span style="color: grey">(5fb28d5)</span></li>
<li>filters/words/msword-odf/texthandler.cpp <span style="color: grey">(4e85fda)</span></li>
<li>filters/words/msword-odf/wv2/CMakeLists.txt <span style="color: grey">(2fc0d70)</span></li>
<li>filters/words/msword-odf/wv2/src/CMakeLists.txt <span style="color: grey">(41c95d5)</span></li>
<li>filters/words/msword-odf/wv2/src/annotations.cpp <span style="color: grey">(722edeb)</span></li>
<li>filters/words/msword-odf/wv2/src/bookmark.cpp <span style="color: grey">(93e14ee)</span></li>
<li>filters/words/msword-odf/wv2/src/crc32.h <span style="color: grey">(d51bb13)</span></li>
<li>filters/words/msword-odf/wv2/src/fields.cpp <span style="color: grey">(03bdcce)</span></li>
<li>filters/words/msword-odf/wv2/src/footnotes97.cpp <span style="color: grey">(0d29d36)</span></li>
<li>filters/words/msword-odf/wv2/src/functordata.h <span style="color: grey">(dcb9b28)</span></li>
<li>filters/words/msword-odf/wv2/src/graphics.cpp <span style="color: grey">(4057822)</span></li>
<li>filters/words/msword-odf/wv2/src/handlers.h <span style="color: grey">(b1c8280)</span></li>
<li>filters/words/msword-odf/wv2/src/headers.cpp <span style="color: grey">(a2039bf)</span></li>
<li>filters/words/msword-odf/wv2/src/lists.cpp <span style="color: grey">(908ecf8)</span></li>
<li>filters/words/msword-odf/wv2/src/olestorage.h <span style="color: grey">(bf768e0)</span></li>
<li>filters/words/msword-odf/wv2/src/olestorage.cpp <span style="color: grey">(a949657)</span></li>
<li>filters/words/msword-odf/wv2/src/olestream.h <span style="color: grey">(32d589a)</span></li>
<li>filters/words/msword-odf/wv2/src/olestream.cpp <span style="color: grey">(01c0612)</span></li>
<li>filters/words/msword-odf/wv2/src/parser9x.cpp <span style="color: grey">(679ce78)</span></li>
<li>filters/words/msword-odf/wv2/src/parserfactory.h <span style="color: grey">(3873660)</span></li>
<li>filters/words/msword-odf/wv2/src/parserfactory.cpp <span style="color: grey">(0b86c09)</span></li>
<li>filters/words/msword-odf/wv2/src/properties97.cpp <span style="color: grey">(71e40ce)</span></li>
<li>filters/words/msword-odf/wv2/src/styles.cpp <span style="color: grey">(f1f8f13)</span></li>
<li>filters/words/msword-odf/wv2/src/ustring.cpp <span style="color: grey">(d840207)</span></li>
<li>filters/words/msword-odf/wv2/src/word97_generated.cpp <span style="color: grey">(bd7ae2a)</span></li>
<li>filters/words/msword-odf/wv2/src/word97_helper.h <span style="color: grey">(fe9bcbf)</span></li>
<li>filters/words/msword-odf/wv2/src/word97_helper.cpp <span style="color: grey">(95d812c)</span></li>
<li>filters/words/msword-odf/wv2/src/word_helper.h <span style="color: grey">(5c5f6e9)</span></li>
<li>filters/words/msword-odf/wv2/src/zcodec.hxx <span style="color: grey">(a099fc1)</span></li>
<li>filters/words/msword-odf/wv2/src/zcodec.cxx <span style="color: grey">(6fee148)</span></li>
<li>filters/words/msword-odf/wv2/tests/CMakeLists.txt <span style="color: grey">(249a156)</span></li>
<li>filters/words/msword-odf/wv2/tests/handlertest.cpp <span style="color: grey">(d94b3b5)</span></li>
<li>filters/words/msword-odf/wv2/tests/helpertest.cpp <span style="color: grey">(a8bc99f)</span></li>
<li>filters/words/msword-odf/wv2/tests/iconvtest.cpp <span style="color: grey">(e53851c)</span></li>
<li>filters/words/msword-odf/wv2/tests/oletest.cpp <span style="color: grey">(dfaa144)</span></li>
<li>filters/words/msword-odf/wv2/tests/parsertest.cpp <span style="color: grey">(5493e84)</span></li>
<li>filters/words/msword-odf/wv2/tests/parsertest_mem.cpp <span style="color: grey">(d004453)</span></li>
<li>filters/words/msword-odf/wv2/tests/regression <span style="color: grey">(1225b45)</span></li>
<li>filters/words/msword-odf/wv2/tests/sharedptrtest.cpp <span style="color: grey">(83e1fcf)</span></li>
<li>filters/words/msword-odf/wv2/tests/test.h <span style="color: grey">(18ddee0)</span></li>
<li>filters/words/msword-odf/wv2/tests/testole.doc <span style="color: grey">(dd94bba)</span></li>
<li>filters/words/msword-odf/wv2/tests/ustringtest.cpp <span style="color: grey">(b26af18)</span></li>
<li>filters/words/msword-odf/wv2/tests/word95_test.cpp <span style="color: grey">(2351c78)</span></li>
<li>filters/words/msword-odf/wv2/tests/word97_test.cpp <span style="color: grey">(902dfc8)</span></li>
<li>libs/kotext/KoTextCommandBase.h <span style="color: grey">(2cf3f63)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102790/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>