<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102809/">http://git.reviewboard.kde.org/r/102809/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 9th, 2011, 2:58 a.m., <b>Thorsten Zachmann</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think we should pass a PaintingContext to the paint method instead of adding new parameters. That has the benefit of making it future prove. There are some things I would like to pass to painting for e.g. animations in stage.</pre>
</blockquote>
<p>On October 9th, 2011, 11:50 a.m., <b>Boudewijn Rempt</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If all that's needed is the KoCanvasResourceManager, I think we should pass that, not the canvas, not a context wrapper that contains the canvas. We're referring to the canvas itself in way too many places already, which makes it possible to make documents actually work without a ready canvas present. And that's something I see as very desirable.</pre>
</blockquote>
<p>On October 9th, 2011, noon, <b>C. Boemann</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Well the context could contain a pointer to the KoCanvasResourceManager. I can see a reason why we may want more than the resource manager.
Also the canvas resource manager conveys information about the settings of the canvas, but if we want to print or paint a thumbail would we then change the settings in the resouce manager.
I'm starting to think a dedicated KoShapePaintingContext is indeed the right thing</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Okay, yes -- that should work. As long as we don't pass the canvas, I'm ok.</pre>
<br />
<p>- Boudewijn</p>
<br />
<p>On October 9th, 2011, 2:50 a.m., C. Boemann wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By C. Boemann.</div>
<p style="color: grey;"><i>Updated Oct. 9, 2011, 2:50 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch passes the canvas to the paint and paintComponent methods of KoShape and decendents.
The reason is that some shapes (notably the text shape) will like to query the canvasResourceManager for info about such things as if it should paint:
- borders around tables
- decoration of spellchecking
- formatting chars (line break, spaces, tabs)
The alternative is to pass some form of a paint context, but since we already pass the canvas to the paintDecorations method and it gives access to the resourcemanager I thought this might be as good a solution as any other.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>braindump/plugins/stateshape/StateShape.h <span style="color: grey">(b8f79d6)</span></li>
<li>braindump/plugins/stateshape/StateShape.cpp <span style="color: grey">(3fae42e)</span></li>
<li>braindump/plugins/webshape/WebShape.h <span style="color: grey">(bdc6583)</span></li>
<li>braindump/plugins/webshape/WebShape.cpp <span style="color: grey">(b4abf0b)</span></li>
<li>braindump/src/Layout.cpp <span style="color: grey">(2cad88a)</span></li>
<li>karbon/plugins/tools/CalligraphyTool/KarbonCalligraphyTool.cpp <span style="color: grey">(e137387)</span></li>
<li>karbon/plugins/tools/KarbonPencilTool.cpp <span style="color: grey">(5d9533d)</span></li>
<li>krita/ui/flake/kis_layer_container_shape.h <span style="color: grey">(ae603ff)</span></li>
<li>krita/ui/flake/kis_layer_container_shape.cc <span style="color: grey">(a9c50d3)</span></li>
<li>krita/ui/flake/kis_node_shape.h <span style="color: grey">(5567c7d)</span></li>
<li>krita/ui/flake/kis_node_shape.cpp <span style="color: grey">(6e695a6)</span></li>
<li>krita/ui/flake/kis_shape_selection.h <span style="color: grey">(c932aa3)</span></li>
<li>krita/ui/flake/kis_shape_selection.cpp <span style="color: grey">(0b72764)</span></li>
<li>libs/flake/KoCanvasControllerWidgetViewport_p.cpp <span style="color: grey">(345f51a)</span></li>
<li>libs/flake/KoPathShape.h <span style="color: grey">(8b54f26)</span></li>
<li>libs/flake/KoPathShape.cpp <span style="color: grey">(4c5ffb6)</span></li>
<li>libs/flake/KoSelection.h <span style="color: grey">(a8d14bf)</span></li>
<li>libs/flake/KoSelection.cpp <span style="color: grey">(0c4f7ed)</span></li>
<li>libs/flake/KoShape.h <span style="color: grey">(6ca2ede)</span></li>
<li>libs/flake/KoShapeContainer.h <span style="color: grey">(483d893)</span></li>
<li>libs/flake/KoShapeContainer.cpp <span style="color: grey">(d9b466a)</span></li>
<li>libs/flake/KoShapeGroup.h <span style="color: grey">(12ca7b4)</span></li>
<li>libs/flake/KoShapeGroup.cpp <span style="color: grey">(0515dce)</span></li>
<li>libs/flake/KoShapeLayer.h <span style="color: grey">(c098b9a)</span></li>
<li>libs/flake/KoShapeLayer.cpp <span style="color: grey">(a17f44b)</span></li>
<li>libs/flake/KoShapeManager.cpp <span style="color: grey">(c3b3484)</span></li>
<li>libs/flake/KoTosContainer.h <span style="color: grey">(98c0f55)</span></li>
<li>libs/flake/KoTosContainer.cpp <span style="color: grey">(3a0aa51)</span></li>
<li>libs/flake/KoUnavailShape.h <span style="color: grey">(e8f1cf4)</span></li>
<li>libs/flake/KoUnavailShape.cpp <span style="color: grey">(e06a8b0)</span></li>
<li>libs/flake/tests/MockShapes.h <span style="color: grey">(5de9cd2)</span></li>
<li>libs/flake/tests/TestShapePainting.cpp <span style="color: grey">(871fe1c)</span></li>
<li>libs/flake/tools/KoCreatePathTool.cpp <span style="color: grey">(fb4a4ea)</span></li>
<li>libs/kopageapp/KoPAPageBase.h <span style="color: grey">(de22a80)</span></li>
<li>libs/kopageapp/KoPAPageBase.cpp <span style="color: grey">(09e2ae3)</span></li>
<li>plugins/artistictextshape/ArtisticTextShape.h <span style="color: grey">(04cc365)</span></li>
<li>plugins/artistictextshape/ArtisticTextShape.cpp <span style="color: grey">(a7835e3)</span></li>
<li>plugins/chartshape/ChartShape.h <span style="color: grey">(a65d6fa)</span></li>
<li>plugins/chartshape/ChartShape.cpp <span style="color: grey">(34db6ee)</span></li>
<li>plugins/chartshape/Legend.h <span style="color: grey">(ac4a419)</span></li>
<li>plugins/chartshape/Legend.cpp <span style="color: grey">(141ecf0)</span></li>
<li>plugins/chartshape/PlotArea.h <span style="color: grey">(85ce07b)</span></li>
<li>plugins/chartshape/PlotArea.cpp <span style="color: grey">(63e425b)</span></li>
<li>plugins/chartshape/TextLabelDummy.h <span style="color: grey">(85bfed2)</span></li>
<li>plugins/chartshape/TextLabelDummy.cpp <span style="color: grey">(4ca0792)</span></li>
<li>plugins/commentshape/CommentShape.h <span style="color: grey">(5b8e231)</span></li>
<li>plugins/commentshape/CommentShape.cpp <span style="color: grey">(0fd7d30)</span></li>
<li>plugins/commentshape/InitialsCommentShape.h <span style="color: grey">(1c49b72)</span></li>
<li>plugins/commentshape/InitialsCommentShape.cpp <span style="color: grey">(9c04211)</span></li>
<li>plugins/dockers/shapecollection/ShapeCollectionDocker.cpp <span style="color: grey">(719d569)</span></li>
<li>plugins/formulashape/KoFormulaShape.h <span style="color: grey">(0afc761)</span></li>
<li>plugins/formulashape/KoFormulaShape.cpp <span style="color: grey">(2aef65d)</span></li>
<li>plugins/musicshape/MusicShape.h <span style="color: grey">(6374d36)</span></li>
<li>plugins/musicshape/MusicShape.cpp <span style="color: grey">(d410360)</span></li>
<li>plugins/pictureshape/PictureShape.h <span style="color: grey">(f8bbc3e)</span></li>
<li>plugins/pictureshape/PictureShape.cpp <span style="color: grey">(66b3c83)</span></li>
<li>plugins/pluginshape/PluginShape.h <span style="color: grey">(e5a50cb)</span></li>
<li>plugins/pluginshape/PluginShape.cpp <span style="color: grey">(5840931)</span></li>
<li>plugins/textshape/ShrinkToFitShapeContainer.h <span style="color: grey">(39d2117)</span></li>
<li>plugins/textshape/ShrinkToFitShapeContainer.cpp <span style="color: grey">(7253479)</span></li>
<li>plugins/textshape/TextShape.h <span style="color: grey">(4ae4941)</span></li>
<li>plugins/textshape/TextShape.cpp <span style="color: grey">(5ee4bba)</span></li>
<li>plugins/textshape/dialogs/SimpleParagraphWidget.cpp <span style="color: grey">(5dbb238)</span></li>
<li>plugins/textshape/dialogs/TableOfContentsPreview.cpp <span style="color: grey">(7b0feaf)</span></li>
<li>plugins/treeshape/TreeShape.h <span style="color: grey">(6370621)</span></li>
<li>plugins/treeshape/TreeShape.cpp <span style="color: grey">(756e2d6)</span></li>
<li>plugins/treeshape/TreeShapeMoveStrategy.cpp <span style="color: grey">(4184f32)</span></li>
<li>plugins/vectorshape/VectorShape.h <span style="color: grey">(cb5ab8e)</span></li>
<li>plugins/vectorshape/VectorShape.cpp <span style="color: grey">(c14e6a7)</span></li>
<li>plugins/videoshape/VideoShape.h <span style="color: grey">(d6bd829)</span></li>
<li>plugins/videoshape/VideoShape.cpp <span style="color: grey">(08e653e)</span></li>
<li>stage/part/KPrNotes.cpp <span style="color: grey">(598a1a0)</span></li>
<li>stage/part/KPrPlaceholderShape.h <span style="color: grey">(184a361)</span></li>
<li>stage/part/KPrPlaceholderShape.cpp <span style="color: grey">(03a9eba)</span></li>
<li>stage/part/KPrPlaceholderStrategy.h <span style="color: grey">(873eaa3)</span></li>
<li>stage/part/KPrPlaceholderStrategy.cpp <span style="color: grey">(6d0761f)</span></li>
<li>stage/part/KPrPlaceholderTextStrategy.h <span style="color: grey">(4202bc6)</span></li>
<li>stage/part/KPrPlaceholderTextStrategy.cpp <span style="color: grey">(9e99f9f)</span></li>
<li>tables/shape/TableShape.h <span style="color: grey">(03b7e9b)</span></li>
<li>tables/shape/TableShape.cpp <span style="color: grey">(d53b069)</span></li>
<li>words/part/commands/KWClipFrameCommand.cpp <span style="color: grey">(b55aafe)</span></li>
<li>words/part/frames/KWCopyShape.h <span style="color: grey">(1ad91ac)</span></li>
<li>words/part/frames/KWCopyShape.cpp <span style="color: grey">(5a77481)</span></li>
<li>words/part/frames/KWFrameLayout.cpp <span style="color: grey">(9790f73)</span></li>
<li>words/part/frames/KWOutlineShape.h <span style="color: grey">(300bfef)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102809/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>