<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101993/">http://git.reviewboard.kde.org/r/101993/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit e08bce93e67dcf0383001ccd3277693af2385fd8 by Boudewijn Rempt to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On July 18th, 2011, 1:03 p.m., Boudewijn Rempt wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Boudewijn Rempt.</div>
<p style="color: grey;"><i>Updated July 18, 2011, 1:03 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch removes the buggy split-view functionality from KoMainWindow. split-view has a number of problems:
* crashes when removing views
* duplicates the actions so when a view is split you cannot e.g. delete a shape with the delete key
* it is limited in that it can only show views on one document, instead of splitting the view and then making it possible to show several documents side-by-side
After discussion on irc, we felt it was better to let the window manager handle side-by-side views. To that end, a patch to optionally hide dockers if the window loses focus will follow.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Started several apps, opened and closed documents.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=239309">239309</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=265200">265200</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=277953">277953</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=278000">278000</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>flow/part/flow.rc <span style="color: grey">(bd2913a)</span></li>
<li>karbon/data/karbon.rc <span style="color: grey">(18c7156)</span></li>
<li>kpresenter/part/stage.rc <span style="color: grey">(d48fd3c)</span></li>
<li>kpresenter/stage.rc <span style="color: grey">(3e0f53d)</span></li>
<li>krita/krita.rc <span style="color: grey">(3d5d85d)</span></li>
<li>libs/main/KoDocument.cpp <span style="color: grey">(515911a)</span></li>
<li>libs/main/KoMainWindow.h <span style="color: grey">(d44aff6)</span></li>
<li>libs/main/KoMainWindow.cpp <span style="color: grey">(c629827)</span></li>
<li>tables/tables.rc <span style="color: grey">(0fde1b6)</span></li>
<li>words/part/words.rc <span style="color: grey">(4e10d36)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101993/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>