I thought we had planned to discuss the kotext/textlayout/textshape architecture at the sprint.<br><br>Pierre<br><br><br><br><div class="gmail_quote">On Thu, Sep 22, 2011 at 10:08 PM, C. Boemann <span dir="ltr"><<a href="mailto:cbr@boemann.dk">cbr@boemann.dk</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<div>
<div style="font-family: Verdana,Arial,Helvetica,Sans-Serif;"><div class="im">
<table style="border: 1px solid rgb(201, 195, 153);" width="100%" bgcolor="#f9f3c9" cellpadding="8">
<tbody><tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102679/" target="_blank">http://git.reviewboard.kde.org/r/102679/</a>
</td>
</tr>
</tbody></table>
<br>
</div><pre style="white-space: pre-wrap; word-wrap: break-word;">In general quite nice. A few remarks, and then i just assumed you moved the commands with maybe a little rename but i din't exactly read all of them. Please advice if i need to.
For the kotexteditor::paste i think we should irc a bit</pre>
<br>
<div>
<table style="border: 1px solid rgb(192, 192, 192); border-collapse: collapse;" width="100%" bgcolor="white" border="0">
<thead>
<tr>
<th colspan="4" style="border-bottom: 1px solid rgb(192, 192, 192); font-size: 9pt; padding: 4px 8px; text-align: left;" bgcolor="#f0f0f0">
<a href="http://git.reviewboard.kde.org/r/102679/diff/1/?file=36769#file36769line160" style="color: black; font-weight: bold; text-decoration: underline;" target="_blank">libs/flake/KoShapeController.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: rgb(228, 217, 203); padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0pt;">KUndo2Command* KoShapeController::addShapeDirect(KoShape *shape, KUndo2Command *parent)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th style="border-right: 1px solid rgb(192, 192, 192);" align="right" bgcolor="#e9eaa8"><font size="2">160</font></th>
<td width="50%" bgcolor="#fdfebc"><pre style="font-size: 8pt; line-height: 140%; margin: 0pt;"> <span>KoToolManager</span><span>::</span><span>instance</span><span>()</span><span>-></span><span>updateShapeControllerBase</span><span>(</span><span>shapeControllerBase</span><span>,</span> <span>canvas</span><span>-></span><span>canvasController</span><span>());</span></pre>
</td>
<th style="border-left: 1px solid rgb(192, 192, 192); border-right: 1px solid rgb(192, 192, 192);" align="right" bgcolor="#e9eaa8"><font size="2">158</font></th>
<td width="50%" bgcolor="#fdfebc"><pre style="font-size: 8pt; line-height: 140%; margin: 0pt;"> <span>d</span><span>-></span><span>shapeBasedDocument</span> <span>=</span> <span>shapeBasedDocument</span><span>;</span></pre>
</td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; word-wrap: break-word;">do we loose funtionality here
i later saw it being done in calligratables but are we sure of the other apps?</pre>
</div>
<br>
<div>
<table style="border: 1px solid rgb(192, 192, 192); border-collapse: collapse;" width="100%" bgcolor="white" border="0">
<thead>
<tr>
<th colspan="4" style="border-bottom: 1px solid rgb(192, 192, 192); font-size: 9pt; padding: 4px 8px; text-align: left;" bgcolor="#f0f0f0">
<a href="http://git.reviewboard.kde.org/r/102679/diff/1/?file=36803#file36803line231" style="color: black; font-weight: bold; text-decoration: underline;" target="_blank">libs/kotext/KoTextEditor.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: rgb(228, 217, 203); padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0pt;">public slots:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th style="border-right: 1px solid rgb(192, 192, 192);" align="right" bgcolor="#b1ebb0"><font size="2"></font></th>
<td width="50%" bgcolor="#c5ffc4"><pre style="font-size: 8pt; line-height: 140%; margin: 0pt;"></pre></td>
<th style="border-left: 1px solid rgb(192, 192, 192); border-right: 1px solid rgb(192, 192, 192);" align="right" bgcolor="#b1ebb0"><font size="2">231</font></th>
<td width="50%" bgcolor="#c5ffc4"><pre style="font-size: 8pt; line-height: 140%; margin: 0pt;"><span> * Insert the selection from the given KoTextEditor</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; word-wrap: break-word;">please improve this description.</pre>
</div>
<br>
<div>
<table style="border: 1px solid rgb(192, 192, 192); border-collapse: collapse;" width="100%" bgcolor="white" border="0">
<thead>
<tr>
<th colspan="4" style="border-bottom: 1px solid rgb(192, 192, 192); font-size: 9pt; padding: 4px 8px; text-align: left;" bgcolor="#f0f0f0">
<a href="http://git.reviewboard.kde.org/r/102679/diff/1/?file=36804#file36804line978" style="color: black; font-weight: bold; text-decoration: underline;" target="_blank">libs/kotext/KoTextEditor.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: rgb(228, 217, 203); padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0pt;"></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0pt;">bool KoTextEditor::paste(KoTextEditor *editor,</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th style="border-right: 1px solid rgb(192, 192, 192);" align="right" bgcolor="#b1ebb0"><font size="2"></font></th>
<td width="50%" bgcolor="#c5ffc4"><pre style="font-size: 8pt; line-height: 140%; margin: 0pt;"></pre></td>
<th style="border-left: 1px solid rgb(192, 192, 192); border-right: 1px solid rgb(192, 192, 192);" align="right" bgcolor="#b1ebb0"><font size="2">978</font></th>
<td width="50%" bgcolor="#c5ffc4"><pre style="font-size: 8pt; line-height: 140%; margin: 0pt;"> <span>if</span> <span>(</span><span>!</span><span>editor</span><span>-></span><span>hasComplexSelection</span><span>())</span> <span>return</span><span>;</span></pre>
</td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; word-wrap: break-word;">so you only want to copy if the source selects part of a table??</pre>
</div>
<br>
<div>
<table style="border: 1px solid rgb(192, 192, 192); border-collapse: collapse;" width="100%" bgcolor="white" border="0">
<thead>
<tr>
<th colspan="4" style="border-bottom: 1px solid rgb(192, 192, 192); font-size: 9pt; padding: 4px 8px; text-align: left;" bgcolor="#f0f0f0">
<a href="http://git.reviewboard.kde.org/r/102679/diff/1/?file=36804#file36804line996" style="color: black; font-weight: bold; text-decoration: underline;" target="_blank">libs/kotext/KoTextEditor.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: rgb(228, 217, 203); padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0pt;"></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0pt;">bool KoTextEditor::paste(KoTextEditor *editor,</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th style="border-right: 1px solid rgb(192, 192, 192);" align="right" bgcolor="#b1ebb0"><font size="2"></font></th>
<td width="50%" bgcolor="#c5ffc4"><pre style="font-size: 8pt; line-height: 140%; margin: 0pt;"></pre></td>
<th style="border-left: 1px solid rgb(192, 192, 192); border-right: 1px solid rgb(192, 192, 192);" align="right" bgcolor="#b1ebb0"><font size="2">996</font></th>
<td width="50%" bgcolor="#c5ffc4"><pre style="font-size: 8pt; line-height: 140%; margin: 0pt;"> <span>editor</span><span>-></span><span>addCommand</span><span>(</span><span>new</span> <span>DeleteCommand</span><span>(</span><span>DeleteCommand</span><span>::</span><span>NextChar</span><span>,</span> <span>d</span><span>-></span><span>document</span><span>,</span> <span>shapeController</span><span>));</span></pre>
</td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; word-wrap: break-word;">editor-> ?? are you sure</pre>
</div>
<br>
<div>
<table style="border: 1px solid rgb(192, 192, 192); border-collapse: collapse;" width="100%" bgcolor="white" border="0">
<thead>
<tr>
<th colspan="4" style="border-bottom: 1px solid rgb(192, 192, 192); font-size: 9pt; padding: 4px 8px; text-align: left;" bgcolor="#f0f0f0">
<a href="http://git.reviewboard.kde.org/r/102679/diff/1/?file=36818#file36818line100" style="color: black; font-weight: bold; text-decoration: underline;" target="_blank">libs/kotext/commands/TextPasteCommand.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: rgb(228, 217, 203); padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0pt;"></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0pt;">void TextPasteCommand::redo()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th style="border-right: 1px solid rgb(192, 192, 192);" align="right" bgcolor="#b1ebb0"><font size="2"></font></th>
<td width="50%" bgcolor="#c5ffc4"><pre style="font-size: 8pt; line-height: 140%; margin: 0pt;"></pre></td>
<th style="border-left: 1px solid rgb(192, 192, 192); border-right: 1px solid rgb(192, 192, 192);" align="right" bgcolor="#b1ebb0"><font size="2">100</font></th>
<td width="50%" bgcolor="#c5ffc4"><pre style="font-size: 8pt; line-height: 140%; margin: 0pt;"><span> </span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; word-wrap: break-word;">can this be fixed </pre>
</div>
<br>
<div>
<table style="border: 1px solid rgb(192, 192, 192); border-collapse: collapse;" width="100%" bgcolor="white" border="0">
<thead>
<tr>
<th colspan="4" style="border-bottom: 1px solid rgb(192, 192, 192); font-size: 9pt; padding: 4px 8px; text-align: left;" bgcolor="#f0f0f0">
<a href="http://git.reviewboard.kde.org/r/102679/diff/1/?file=36854#file36854line33" style="color: black; font-weight: bold; text-decoration: underline;" target="_blank">plugins/textshape/dialogs/ParagraphSettingsDialog.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: rgb(228, 217, 203); padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0pt;"></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th style="border-right: 1px solid rgb(192, 192, 192);" align="right" bgcolor="#f0f0f0"><font size="2">32</font></th>
<td width="50%" bgcolor="#ffffff"><pre style="font-size: 8pt; line-height: 140%; margin: 0pt;"><span>ParagraphSettingsDialog</span><span>::</span><span>ParagraphSettingsDialog</span><span>(</span><span>TextTool</span> <span>*</span><span>tool</span><span>,</span> <span>QTextCursor</span> <span>*</span><span>cursor</span><span>,</span> <span>QWidget</span><span>*</span> <span>parent</span><span>)</span></pre>
</td>
<th style="border-left: 1px solid rgb(192, 192, 192); border-right: 1px solid rgb(192, 192, 192);" align="right" bgcolor="#f0f0f0"><font size="2">32</font></th>
<td width="50%" bgcolor="#ffffff"><pre style="font-size: 8pt; line-height: 140%; margin: 0pt;"><span>ParagraphSettingsDialog</span><span>::</span><span>ParagraphSettingsDialog</span><span>(</span><span>TextTool</span> <span>*</span><span>tool</span><span>,</span> <span>QTextCursor</span> <span>*</span><span>cursor</span><span>,</span> <span>QWidget</span><span>*</span> <span>parent</span><span>)</span></pre>
</td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; word-wrap: break-word;">do we still need cursor here then?</pre>
</div>
<br>
<p>- C.</p><div class="im">
<br>
<p>On September 22nd, 2011, 7:14 p.m., Boudewijn Rempt wrote:</p>
</div><table style="background-repeat: repeat-x; border: 1px solid black;" width="100%" bgcolor="#fefadf" cellpadding="8" cellspacing="0">
<tbody><tr>
<td><div class="im">
<div>Review request for Calligra.</div>
<div>By Boudewijn Rempt.</div>
</div><p style="color: grey;"><i>Updated Sept. 22, 2011, 7:14 p.m.</i></p><div><div></div><div class="h5">
<h1 style="color: rgb(87, 80, 18); font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table style="border: 1px solid rgb(184, 181, 160);" width="100%" bgcolor="#ffffff" cellpadding="10" cellspacing="0">
<tbody><tr>
<td>
<pre style="margin: 0pt; padding: 0pt; white-space: pre-wrap; word-wrap: break-word;">KoTextEditor is meant to be the one and only interface we allow to editing a QTextDocument. TextTool breaks this encapsulation in many ways. This patch improves the situation but doesn't solve it completely yet. Several commands have been moved to kotext and encapsulated in KoTextEditor. This simplifies the code in the textshape quite a bit. The other bits will follow later on.
In order to make it possible to test this code, I wanted to be able to create a KoShapeController without a canvas, so KoShapeController was refactored a bit as well. Because KoShapeControllerBase was confusingly named, I renamed that class after irc discussion.</pre>
</td>
</tr>
</tbody></table>
<h1 style="color: rgb(87, 80, 18); font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table style="border: 1px solid rgb(184, 181, 160);" width="100%" bgcolor="#ffffff" cellpadding="10" cellspacing="0">
<tbody><tr>
<td>
<pre style="margin: 0pt; padding: 0pt; white-space: pre-wrap; word-wrap: break-word;">manual gui test + ran the unittests. Added more testing.</pre>
</td>
</tr>
</tbody></table>
<h1 style="color: rgb(87, 80, 18); font-size: 10pt; margin-top: 1.5em;">Diffs </h1>
<ul style="margin-left: 3em; padding-left: 0pt;">
<li>braindump/src/SectionContainer.h <span style="color: grey;">(ec00b6f)</span></li>
<li>braindump/src/ViewManager.h <span style="color: grey;">(bf4e89c)</span></li>
<li>flow/plugins/dockers/stencilboxdocker/StencilShapeFactory.h <span style="color: grey;">(dffa96e)</span></li>
<li>flow/plugins/dockers/stencilboxdocker/StencilShapeFactory.cpp <span style="color: grey;">(318e483)</span></li>
<li>karbon/common/commands/KarbonBooleanCommand.h <span style="color: grey;">(9c49a74)</span></li>
<li>karbon/common/commands/KarbonBooleanCommand.cpp <span style="color: grey;">(947ba83)</span></li>
<li>karbon/ui/KarbonPart.h <span style="color: grey;">(2dc5f85)</span></li>
<li>karbon/ui/dockers/KarbonLayerDocker.h <span style="color: grey;">(55ee45d)</span></li>
<li>karbon/ui/dockers/KarbonLayerDocker.cpp <span style="color: grey;">(30e1ab2)</span></li>
<li>karbon/ui/dockers/KarbonLayerModel.cpp <span style="color: grey;">(f26666f)</span></li>
<li>krita/plugins/formats/odg/kis_odg_import.cc <span style="color: grey;">(be07b8c)</span></li>
<li>krita/ui/canvas/kis_canvas2.h <span style="color: grey;">(cf1d633)</span></li>
<li>krita/ui/canvas/kis_canvas2.cpp <span style="color: grey;">(6dc2b95)</span></li>
<li>krita/ui/flake/kis_shape_controller.h <span style="color: grey;">(4e0540a)</span></li>
<li>krita/ui/flake/kis_shape_layer.h <span style="color: grey;">(2ec5170)</span></li>
<li>krita/ui/flake/kis_shape_layer.cc <span style="color: grey;">(8004eae)</span></li>
<li>krita/ui/flake/kis_shape_layer_paste.h <span style="color: grey;">(096896f)</span></li>
<li>krita/ui/kis_doc2.h <span style="color: grey;">(faa2e1f)</span></li>
<li>krita/ui/kis_doc2.cc <span style="color: grey;">(ed11964)</span></li>
<li>libs/flake/CMakeLists.txt <span style="color: grey;">(4311bd0)</span></li>
<li>libs/flake/KoCanvasBase.h <span style="color: grey;">(5f8f0ab)</span></li>
<li>libs/flake/KoCanvasBase.cpp <span style="color: grey;">(2361bc1)</span></li>
<li>libs/flake/KoCanvasController.h <span style="color: grey;">(3fc370e)</span></li>
<li>libs/flake/KoDataCenterBase.h <span style="color: grey;">(de447fa)</span></li>
<li>libs/flake/KoShape.h <span style="color: grey;">(84bdbfc)</span></li>
<li>libs/flake/KoShapeBasedDocumentBase.h <span style="color: grey;">(PRE-CREATION)</span></li>
<li>libs/flake/KoShapeBasedDocumentBase.cpp <span style="color: grey;">(PRE-CREATION)</span></li>
<li>libs/flake/KoShapeController.h <span style="color: grey;">(e3c65ab)</span></li>
<li>libs/flake/KoShapeController.cpp <span style="color: grey;">(27722b3)</span></li>
<li>libs/flake/KoShapeControllerBase.h <span style="color: grey;">(5d1db1f)</span></li>
<li>libs/flake/KoShapeControllerBase.cpp <span style="color: grey;">(3f9d9a2)</span></li>
<li>libs/flake/KoShapeLoadingContext.h <span style="color: grey;">(b0e0358)</span></li>
<li>libs/flake/KoShapeLoadingContext.cpp <span style="color: grey;">(50d50bb)</span></li>
<li>libs/flake/KoShapePaste.cpp <span style="color: grey;">(d94dc11)</span></li>
<li>libs/flake/KoToolBase.h <span style="color: grey;">(13dc3c7)</span></li>
<li>libs/flake/KoToolBase.cpp <span style="color: grey;">(627591e)</span></li>
<li>libs/flake/KoToolManager.h <span style="color: grey;">(48cbaa8)</span></li>
<li>libs/flake/KoToolManager.cpp <span style="color: grey;">(8c612b0)</span></li>
<li>libs/flake/commands/KoPathCombineCommand.h <span style="color: grey;">(a34edb5)</span></li>
<li>libs/flake/commands/KoPathCombineCommand.cpp <span style="color: grey;">(72aaed4)</span></li>
<li>libs/flake/commands/KoPathPointRemoveCommand.cpp <span style="color: grey;">(fa748a6)</span></li>
<li>libs/flake/commands/KoPathSeparateCommand.h <span style="color: grey;">(4b52a60)</span></li>
<li>libs/flake/commands/KoPathSeparateCommand.cpp <span style="color: grey;">(a7b0ab7)</span></li>
<li>libs/flake/commands/KoShapeClipCommand.h <span style="color: grey;">(883402c)</span></li>
<li>libs/flake/commands/KoShapeClipCommand.cpp <span style="color: grey;">(7159c91)</span></li>
<li>libs/flake/commands/KoShapeCreateCommand.h <span style="color: grey;">(4a9f3b8)</span></li>
<li>libs/flake/commands/KoShapeCreateCommand.cpp <span style="color: grey;">(6322c8d)</span></li>
<li>libs/flake/commands/KoShapeDeleteCommand.h <span style="color: grey;">(1d1eac4)</span></li>
<li>libs/flake/commands/KoShapeDeleteCommand.cpp <span style="color: grey;">(452ffea)</span></li>
<li>libs/flake/commands/KoShapeUnclipCommand.h <span style="color: grey;">(8903e33)</span></li>
<li>libs/flake/commands/KoShapeUnclipCommand.cpp <span style="color: grey;">(94d2308)</span></li>
<li>libs/flake/tests/MockShapes.h <span style="color: grey;">(3f7ba47)</span></li>
<li>libs/flake/tests/TestSnapStrategy.cpp <span style="color: grey;">(7f2b63b)</span></li>
<li>libs/kopageapp/KoPADocument.h <span style="color: grey;">(cfc9822)</span></li>
<li>libs/kopageapp/KoPADocumentModel.cpp <span style="color: grey;">(b968182)</span></li>
<li>libs/kopageapp/KoPADocumentStructureDocker.cpp <span style="color: grey;">(15c3224)</span></li>
<li>libs/kotext/CMakeLists.txt <span style="color: grey;">(b174f5d)</span></li>
<li>libs/kotext/KoDocumentRdfBase.h <span style="color: grey;">(165f8fd)</span></li>
<li>libs/kotext/KoDocumentRdfBase.cpp <span style="color: grey;">(f6445e6)</span></li>
<li>libs/kotext/KoTextCommandBase.h <span style="color: grey;">(PRE-CREATION)</span></li>
<li>libs/kotext/KoTextCommandBase.cpp <span style="color: grey;">(PRE-CREATION)</span></li>
<li>libs/kotext/KoTextDocument.cpp <span style="color: grey;">(1265e2c)</span></li>
<li>libs/kotext/KoTextEditor.h <span style="color: grey;">(4947db8)</span></li>
<li>libs/kotext/KoTextEditor.cpp <span style="color: grey;">(d6d6738)</span></li>
<li>libs/kotext/KoTextOdfSaveHelper.h <span style="color: grey;">(4e247c2)</span></li>
<li>libs/kotext/KoTextOdfSaveHelper.cpp <span style="color: grey;">(9d5add8)</span></li>
<li>libs/kotext/KoTextPaste.h <span style="color: grey;">(61321d9)</span></li>
<li>libs/kotext/KoTextPaste.cpp <span style="color: grey;">(067d238)</span></li>
<li>libs/kotext/commands/ChangeListCommand.h <span style="color: grey;">(PRE-CREATION)</span></li>
<li>libs/kotext/commands/ChangeListCommand.cpp <span style="color: grey;">(PRE-CREATION)</span></li>
<li>libs/kotext/commands/ChangeTrackedDeleteCommand.h <span style="color: grey;">(PRE-CREATION)</span></li>
<li>libs/kotext/commands/ChangeTrackedDeleteCommand.cpp <span style="color: grey;">(PRE-CREATION)</span></li>
<li>libs/kotext/commands/DeleteCommand.h <span style="color: grey;">(PRE-CREATION)</span></li>
<li>libs/kotext/commands/DeleteCommand.cpp <span style="color: grey;">(PRE-CREATION)</span></li>
<li>libs/kotext/commands/ListItemNumberingCommand.h <span style="color: grey;">(PRE-CREATION)</span></li>
<li>libs/kotext/commands/ListItemNumberingCommand.cpp <span style="color: grey;">(PRE-CREATION)</span></li>
<li>libs/kotext/commands/TextPasteCommand.h <span style="color: grey;">(PRE-CREATION)</span></li>
<li>libs/kotext/commands/TextPasteCommand.cpp <span style="color: grey;">(PRE-CREATION)</span></li>
<li>libs/kotext/opendocument/KoTextWriter.h <span style="color: grey;">(04ea489)</span></li>
<li>libs/kotext/opendocument/KoTextWriter.cpp <span style="color: grey;">(f5d9d77)</span></li>
<li>libs/kotext/tests/TestKoTextEditor.h <span style="color: grey;">(8013086)</span></li>
<li>libs/kotext/tests/TestKoTextEditor.cpp <span style="color: grey;">(85fab42)</span></li>
<li>libs/main/rdf/KoDocumentRdf.h <span style="color: grey;">(219ff42)</span></li>
<li>libs/main/rdf/KoDocumentRdf.cpp <span style="color: grey;">(42b557d)</span></li>
<li>plugins/dockers/shapecollection/CollectionShapeFactory.h <span style="color: grey;">(870fe2e)</span></li>
<li>plugins/dockers/shapecollection/CollectionShapeFactory.cpp <span style="color: grey;">(020e1af)</span></li>
<li>plugins/pictureshape/PictureShapeFactory.cpp <span style="color: grey;">(9ae730c)</span></li>
<li>plugins/pluginshape/PluginShapeFactory.cpp <span style="color: grey;">(ee5f508)</span></li>
<li>plugins/textshape/CMakeLists.txt <span style="color: grey;">(3df7aa5)</span></li>
<li>plugins/textshape/TextShapeFactory.cpp <span style="color: grey;">(4100b47)</span></li>
<li>plugins/textshape/TextTool.h <span style="color: grey;">(6aaef61)</span></li>
<li>plugins/textshape/TextTool.cpp <span style="color: grey;">(142d934)</span></li>
<li>plugins/textshape/commands/AcceptChangeCommand.h <span style="color: grey;">(2945d9e)</span></li>
<li>plugins/textshape/commands/AcceptChangeCommand.cpp <span style="color: grey;">(66b121c)</span></li>
<li>plugins/textshape/commands/ChangeListCommand.h <span style="color: grey;">(a7c2f7e)</span></li>
<li>plugins/textshape/commands/ChangeListCommand.cpp <span style="color: grey;">(8981a1b)</span></li>
<li>plugins/textshape/commands/ChangeListLevelCommand.h <span style="color: grey;">(f657ee1)</span></li>
<li>plugins/textshape/commands/ChangeListLevelCommand.cpp <span style="color: grey;">(bad0b68)</span></li>
<li>plugins/textshape/commands/ChangeTrackedDeleteCommand.h <span style="color: grey;">(6acf4bd)</span></li>
<li>plugins/textshape/commands/ChangeTrackedDeleteCommand.cpp <span style="color: grey;">(f155681)</span></li>
<li>plugins/textshape/commands/DeleteCommand.h <span style="color: grey;">(b85bbb9)</span></li>
<li>plugins/textshape/commands/DeleteCommand.cpp <span style="color: grey;">(cd741dc)</span></li>
<li>plugins/textshape/commands/ListItemNumberingCommand.h <span style="color: grey;">(4457d84)</span></li>
<li>plugins/textshape/commands/ListItemNumberingCommand.cpp <span style="color: grey;">(f00162b)</span></li>
<li>plugins/textshape/commands/RejectChangeCommand.h <span style="color: grey;">(925138d)</span></li>
<li>plugins/textshape/commands/RejectChangeCommand.cpp <span style="color: grey;">(3338875)</span></li>
<li>plugins/textshape/commands/ShowChangesCommand.h <span style="color: grey;">(cacd86a)</span></li>
<li>plugins/textshape/commands/ShowChangesCommand.cpp <span style="color: grey;">(e61f883)</span></li>
<li>plugins/textshape/commands/TextCommandBase.h <span style="color: grey;">(d6306db)</span></li>
<li>plugins/textshape/commands/TextCommandBase.cpp <span style="color: grey;">(be52032)</span></li>
<li>plugins/textshape/commands/TextCutCommand.cpp <span style="color: grey;">(31776f9)</span></li>
<li>plugins/textshape/commands/TextPasteCommand.h <span style="color: grey;">(90f4c3d)</span></li>
<li>plugins/textshape/commands/TextPasteCommand.cpp <span style="color: grey;">(36a1f76)</span></li>
<li>plugins/textshape/dialogs/ParagraphSettingsDialog.cpp <span style="color: grey;">(cdddbe3)</span></li>
<li>plugins/textshape/dialogs/SimpleParagraphWidget.cpp <span style="color: grey;">(5b843ba)</span></li>
<li>plugins/textshape/tests/CMakeLists.txt <span style="color: grey;">(e6ab42a)</span></li>
<li>plugins/videoshape/VideoShapeFactory.cpp <span style="color: grey;">(f1c8d79)</span></li>
<li>stage/part/KPrPlaceholderStrategy.h <span style="color: grey;">(e5ea2cb)</span></li>
<li>tables/Sheet.h <span style="color: grey;">(0e7285a)</span></li>
<li>tables/Sheet.cpp <span style="color: grey;">(6c15a2e)</span></li>
<li>tables/part/CanvasItem.cpp <span style="color: grey;">(1ba27a1)</span></li>
<li>tables/part/View.cpp <span style="color: grey;">(1384ec6)</span></li>
<li>words/part/KWDocument.h <span style="color: grey;">(4143803)</span></li>
<li>words/part/commands/KWFrameCreateCommand.h <span style="color: grey;">(354486d)</span></li>
<li>words/part/commands/KWFrameCreateCommand.cpp <span style="color: grey;">(b4a4fb1)</span></li>
<li>words/part/commands/KWFrameDeleteCommand.h <span style="color: grey;">(1bc79b8)</span></li>
<li>words/part/commands/KWFrameDeleteCommand.cpp <span style="color: grey;">(c5d3c4b)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102679/diff/" style="margin-left: 3em;" target="_blank">View Diff</a></p>
</div></div></td>
</tr>
</tbody></table>
</div>
</div>
<br>_______________________________________________<br>
calligra-devel mailing list<br>
<a href="mailto:calligra-devel@kde.org">calligra-devel@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/calligra-devel" target="_blank">https://mail.kde.org/mailman/listinfo/calligra-devel</a><br>
<br></blockquote></div><br>