<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102666/">http://git.reviewboard.kde.org/r/102666/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 19th, 2011, 8:34 p.m., <b>Jan Hambrecht</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Is there any reason why you are not using KoShape::setApplicationData/KoShape::applicationData?</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">yes it already used for kotextshapedata in text shapes</pre>
<br />
<p>- C.</p>
<br />
<p>On September 19th, 2011, 3:52 p.m., C. Boemann wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By C. Boemann.</div>
<p style="color: grey;"><i>Updated Sept. 19, 2011, 3:52 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Stores a new class KoAnchor on shapes. It's kind of like an extra user data for applications that support anchoring.
By having a pointer from the shape to anchoring information lot's of code in words become easier to maintain.
Plus we will be able to finally support smart positioning of page anchored shapes in words
I tried to keep it out of flake, but since it was impossible to transfer that data from KoTextLoader to words without going through hoops, and we already had two methods in KoShape that I could change hold this (in effect void) pointer I chose the latter.
Tables will be able to attach it's own variation of anchoring info to KoShape too by doing it's own subclassing of KoAnchor just like kotext does with KoTextAnchor</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/flake/CMakeLists.txt <span style="color: grey">(4311bd0)</span></li>
<li>libs/flake/KoAnchor.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/flake/KoAnchor.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/flake/KoShape.h <span style="color: grey">(55f8e97)</span></li>
<li>libs/flake/KoShape.cpp <span style="color: grey">(1c3fcef)</span></li>
<li>libs/flake/KoShape_p.h <span style="color: grey">(d055056)</span></li>
<li>libs/kotext/KoTextAnchor.h <span style="color: grey">(0819c9b)</span></li>
<li>libs/kotext/KoTextAnchor.cpp <span style="color: grey">(f324505)</span></li>
<li>libs/kotext/opendocument/KoTextLoader.cpp <span style="color: grey">(6ce4695)</span></li>
<li>words/part/KWRootAreaProvider.cpp <span style="color: grey">(6c30e28)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102666/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>