<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102520/">http://git.reviewboard.kde.org/r/102520/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">There are two different issues in bug 281112 and bug 281164. An invalid Header document, to be specific header/footer stories are missing. And Header documents of Word6 files have to be validated in a different way. I already have a fix for both. Going to commit tomorrow. </pre>
<br />
<p>- Matus</p>
<br />
<p>On September 2nd, 2011, 11:50 a.m., Sebastian Sauer wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra and Matus Uzak.</div>
<div>By Sebastian Sauer.</div>
<p style="color: grey;"><i>Updated Sept. 2, 2011, 11:50 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Attached patch fixes the both crash bugs https://bugs.kde.org/show_bug.cgi?id=281112 and https://bugs.kde.org/show_bug.cgi?id=281164 .
I know it is a rather dirty way (see comments I added to bug 281112 for more details) but then
1) it fixes the crashes
2) it doesn't reopen the original problem that code tried to fix
3) it makes it more easy to understand the code (I seriously have no idea what that new code is supposed to do - hint: a comment explaining what it does for what reason would be *veryyyyyyyyyyy* useful here)
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>filters/words/msword-odf/wv2/src/headers.cpp <span style="color: grey">(877f557)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102520/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>