<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/102474/">http://git.reviewboard.kde.org/r/102474/</a>
     </td>
    </tr>
   </table>
   <br />



 <p>Ship it!</p>



 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks for this patch! Please look at my notes, apply them, and then you can commit.</pre>
 <br />







<p>- JarosÅ‚aw</p>


<br />
<p>On August 28th, 2011, 11:55 a.m., Jaime Torres Amate wrote:</p>






<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for Calligra.</div>
<div>By Jaime Torres Amate.</div>


<p style="color: grey;"><i>Updated Aug. 28, 2011, 11:55 a.m.</i></p>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add null pointer safeguards
Initialize some variables that could be used uninitialized
change a parameter to be passed by reference</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">no change in make test</pre>
  </td>
 </tr>
</table>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kexi/formeditor/commands.cpp <span style="color: grey">(0508a92)</span></li>

 <li>kexi/formeditor/editlistviewdialog.cpp <span style="color: grey">(31245d1)</span></li>

 <li>kexi/kexidb/drivers/mySQL/mysqlconnection.cpp <span style="color: grey">(a5c8228)</span></li>

 <li>kexi/kexidb/drivers/oracle/oracleconnection.cpp <span style="color: grey">(7634c73)</span></li>

 <li>kexi/kexidb/drivers/oracle/oracleconnection_p.cpp <span style="color: grey">(29bfe1f)</span></li>

 <li>kexi/kexidb/drivers/pqxx/pqxxconnection.cpp <span style="color: grey">(eb3029c)</span></li>

 <li>kexi/kexidb/drivers/sqlite/sqliteconnection.cpp <span style="color: grey">(9c4e676)</span></li>

 <li>kexi/kexidb/drivers/sybase/sybaseconnection.cpp <span style="color: grey">(32437f4)</span></li>

 <li>kexi/kexidb/drivers/xbase/xbaseconnection.cpp <span style="color: grey">(351ac3d)</span></li>

 <li>kexi/kexidb/utils.h <span style="color: grey">(f941a08)</span></li>

 <li>kexi/main/KexiMainWindow.cpp <span style="color: grey">(104849b)</span></li>

 <li>kexi/main/printing/kexisimpleprintingpagesetup.cpp <span style="color: grey">(37f6fa2)</span></li>

 <li>kexi/plugins/forms/kexiformview.cpp <span style="color: grey">(105b5f9)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/102474/diff/" style="margin-left: 3em;">View Diff</a></p>




  </td>
 </tr>
</table>








  </div>
 </body>
</html>