<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102385/">http://git.reviewboard.kde.org/r/102385/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">After fixing the comments please push. Nice work. Thanks</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/102385/diff/2/?file=32419#file32419line272" style="color: black; font-weight: bold; text-decoration: underline;">libs/koproperty/editors/spinbox.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">DoubleSpinBox::DoubleSpinBox(const Property* prop, QWidget *parent, int itemHeight)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">271</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">sb</span><span class="o">-></span><span class="n">setFrame</span><span class="p">(</span><span class="kc">false</span><span class="p">);</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">272</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">sb</span><span class="o">-></span><span class="n">setFrame</span><span class="p">(</span><span class="kc">false</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">should be moved into the if (se) block above</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/102385/diff/2/?file=32419#file32419line273" style="color: black; font-weight: bold; text-decoration: underline;">libs/koproperty/editors/spinbox.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">DoubleSpinBox::DoubleSpinBox(const Property* prop, QWidget *parent, int itemHeight)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">272</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">le</span><span class="o">-></span><span class="n">setFrame</span><span class="p">(</span><span class="kc">false</span><span class="p">);</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">273</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">le</span><span class="o">-></span><span class="n">setFrame</span><span class="p">(</span><span class="kc">false</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Should be moved in the if (le) block above</pre>
</div>
<br />
<p>- Thorsten</p>
<br />
<p>On August 20th, 2011, 4 p.m., Jaime Torres Amate wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Jaime Torres Amate.</div>
<p style="color: grey;"><i>Updated Aug. 20, 2011, 4 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Use references por QRectF and QString.
One //FIXME because I can not see where the error variable gets a value.
One //TODO to avoid code duplication.
safeguards for possible null pointer dereferences.
Remove some unused variables.
Remove a double break;
Reduce the scope of variables.
Create a destructor to avoid a memory leak in FrameIterator.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">No differences in make tests</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/flake/KoShapeFactoryBase.cpp <span style="color: grey">(fbbab41)</span></li>
<li>libs/kopageapp/KoPACanvasBase.h <span style="color: grey">(85b82e7)</span></li>
<li>libs/kopageapp/KoPACanvasBase.cpp <span style="color: grey">(4ee4bd3)</span></li>
<li>libs/koproperty/editors/spinbox.cpp <span style="color: grey">(fbe49d5)</span></li>
<li>libs/koreport/renderer/KoReportPreRenderer.cpp <span style="color: grey">(ce809c4)</span></li>
<li>libs/koreport/wrtembed/KoReportDesignerItemRectBase.cpp <span style="color: grey">(7de1ed6)</span></li>
<li>libs/kotext/opendocument/KoTextLoader.cpp <span style="color: grey">(ff1c793)</span></li>
<li>libs/kotext/opendocument/KoTextWriter.cpp <span style="color: grey">(01cb31f)</span></li>
<li>libs/odf/KoXmlNS.h <span style="color: grey">(41a1658)</span></li>
<li>libs/odf/KoXmlNS.cpp <span style="color: grey">(65a6316)</span></li>
<li>libs/pigment/KoColorConversionSystem_p.h <span style="color: grey">(d87b05a)</span></li>
<li>libs/pigment/KoColorConversions.cpp <span style="color: grey">(5c3f708)</span></li>
<li>libs/textlayout/FrameIterator.h <span style="color: grey">(56138ae)</span></li>
<li>libs/textlayout/FrameIterator.cpp <span style="color: grey">(e7dd615)</span></li>
<li>libs/textlayout/KoTextShapeContainerModel.cpp <span style="color: grey">(80ac07b)</span></li>
<li>libs/widgets/KoUniColorChooser.cpp <span style="color: grey">(68a9e60)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102385/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>