<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102351/">http://git.reviewboard.kde.org/r/102351/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/102351/diff/2/?file=32131#file32131line210" style="color: black; font-weight: bold; text-decoration: underline;">stage/part/KPrSlidesManagerView.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">bool KPrSlidesManagerView::eventFilter(QObject *watched, QEvent *event)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">210</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">QModelIndex</span> <span class="n">last_index</span> <span class="o">=</span> <span class="n">model</span><span class="p">()</span><span class="o">-></span><span class="n">index</span><span class="p">(</span><span class="n">cursorSlideIndex</span><span class="p">()</span><span class="hl"> </span><span class="o"><span class="hl">-</span></span><span class="hl"> </span><span class="mi"><span class="hl">1</span></span><span class="p">,</span> <span class="mi">0</span><span class="p">,</span> <span class="n">QModelIndex</span><span class="p">());</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">210</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">QModelIndex</span> <span class="n">last_index</span> <span class="o">=</span> <span class="n">model</span><span class="p">()</span><span class="o">-></span><span class="n">index</span><span class="p">(</span><span class="n">cursorSlideIndex</span><span class="p">(),</span> <span class="mi">0</span><span class="p">,</span> <span class="n">QModelIndex</span><span class="p">());</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">cursorSlideIndex() method is used in drag&drop to determine where a slide must be inserted, so when the user clicks in the white space after the last slide, this method return an index outside the pages list.
The -1 on line 210 lets select the slide that is placed just before the place where the user click, without the -1 the slide selected is the slide under the cursor or just after the cursor position (this behaviour seems logical except when you click in the margin at the end of a row and the slide selected is at the beggining of the next row).
In both cases there must be tested a exception case: In the first case it must be checked if the cursor is over or before the first slide because in that case nothing gets selected.
In the second case it must be checked if the cursor is after the last slide or the app crash as I explained before.
I am not sure of which case is better. Maybe there is other solution.
</pre>
</div>
<br />
<p>- Paul</p>
<br />
<p>On August 17th, 2011, 7:25 p.m., Peter Simonsson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Peter Simonsson.</div>
<p style="color: grey;"><i>Updated Aug. 17, 2011, 7:25 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The slides sorter crashed on right click outside a page when the page itself is bigger than the viewport. Also fixed so that a page gets selected on right click if none is selected already as the code says it should be.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>stage/part/KPrSlidesManagerView.cpp <span style="color: grey">(1e3d08e)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102351/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>