<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102315/">http://git.reviewboard.kde.org/r/102315/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 19th, 2011, 5:10 a.m., <b>Thorsten Zachmann</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/102315/diff/1/?file=31846#file31846line140" style="color: black; font-weight: bold; text-decoration: underline;">karbon/ui/KarbonPart.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">KarbonPart::KarbonPart(QWidget* parentWidget, const char* widgetName, QObject* parent, const char* name, bool singleViewMode)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">140</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">KoShapeRegistry</span><span class="o">::</span><span class="n">instance</span><span class="p">()</span><span class="o">-></span><span class="n">addFactory</span><span class="p">(</span><span class="k">new</span> <span class="n">SvgShapeFactory</span><span class="p">());</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I guess that code should only be executed once as otherwise the same factory gets added again when you open a new document. You can see the class InitOnce in KPrDocument on how I solved it there</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes you are right, solved it in a lightly different way</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 19th, 2011, 5:10 a.m., <b>Thorsten Zachmann</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/102315/diff/1/?file=31874#file31874line43" style="color: black; font-weight: bold; text-decoration: underline;">libs/flake/svg/SvgSerializable.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">protected:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">43</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="kt">void</span> <span class="n">saveSvgStyle</span><span class="p">(</span><span class="n">KoShape</span> <span class="o">*</span><span class="n">shape</span><span class="p">,</span> <span class="n">SvgSavingContext</span> <span class="o">&</span><span class="n">context</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Is there any special reason you added this function and not call SvgStyleWriter::saveSvgStyle directly?
In all cases it is called it is called with this a shape and then it can be removed and it not needed to pass.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I probably thought there is more to come when saving style. Turns out I was wrong, removed it.</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 19th, 2011, 5:10 a.m., <b>Thorsten Zachmann</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/102315/diff/1/?file=31889#file31889line80" style="color: black; font-weight: bold; text-decoration: underline;">plugins/artistictextshape/ArtisticTextShape.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void ArtisticTextShape::paint(QPainter &painter, const KoViewConverter &converter)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">80</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">SvgWriter</span> <span class="n">svgWriter</span><span class="p">(</span><span class="n">QList</span><span class="o"><</span><span class="n">KoShape</span><span class="o">*></span><span class="p">()</span> <span class="o"><<</span> <span class="p">(</span><span class="n">KoShape</span><span class="o">*</span><span class="p">)</span><span class="k">this</span><span class="p">,</span> <span class="n">size</span><span class="p">());</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">how about using a static_cast<KoShape*> here instead of the c cast?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Unfortunately I have to cast away the constness of "this" as it is a const function. Used a const_cast now to make that more clear.</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 19th, 2011, 5:10 a.m., <b>Thorsten Zachmann</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/102315/diff/1/?file=31890#file31890line48" style="color: black; font-weight: bold; text-decoration: underline;">plugins/artistictextshape/ArtisticTextShapeFactory.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">48</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="p">{</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">46</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="p">{</span></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">49</font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">Q_UNUSED</span><span class="p">(</span><span class="n">context</span><span class="p">);</span></pre></td>
<th bgcolor="#ebb1ba" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
<tr>
<th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">50</font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span><span class="o">!</span><span class="p">(</span><span class="n">e</span><span class="p">.</span><span class="n">localName</span><span class="p">()</span> <span class="o">==</span> <span class="s">"custom-shape"</span> <span class="o">&&</span> <span class="n">e</span><span class="p">.</span><span class="n">namespaceURI</span><span class="p">()</span> <span class="o">==</span> <span class="n">KoXmlNS</span><span class="o">::</span><span class="n">draw</span><span class="p">))</span> <span class="p">{</span></pre></td>
<th bgcolor="#ebb1ba" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">51</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">return</span> <span class="kc">false</span><span class="p">;</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">47</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">return</span> <span class="kc">false</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">With this change the factory will never be used to load the artistic path shape.
And should we not provide backward compatibility for the feature?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yeah, it will never load it directly from odf. There is SvgShapeFactory which takes care of that when embedded into odf.</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 19th, 2011, 5:10 a.m., <b>Thorsten Zachmann</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/102315/diff/1/?file=31899#file31899line400" style="color: black; font-weight: bold; text-decoration: underline;">plugins/pathshapes/ellipse/EllipseShape.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">bool EllipseShape::saveSvg(SvgSavingContext &context)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">400</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="p">}</span> <span class="k">else</span> <span class="p">{</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">401</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">return</span> <span class="kc">false</span><span class="p">;</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">402</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="p">}</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Will that result in not saving it if the arc is not a full arc?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The svg writer will take care of saving that as a path then.</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 19th, 2011, 5:10 a.m., <b>Thorsten Zachmann</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/102315/diff/1/?file=31899#file31899line412" style="color: black; font-weight: bold; text-decoration: underline;">plugins/pathshapes/ellipse/EllipseShape.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">bool EllipseShape::saveSvg(SvgSavingContext &context)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">412</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">const</span> <span class="n">qreal</span> <span class="n">cx</span> <span class="o">=</span> <span class="n">element</span><span class="p">.</span><span class="n">attribute</span><span class="p">(</span><span class="s">"cx"</span><span class="p">).</span><span class="n">isEmpty</span><span class="p">()</span> <span class="o">?</span> <span class="mf">0.0</span> <span class="o">:</span> <span class="n">SvgUtil</span><span class="o">::</span><span class="n">parseUnitX</span><span class="p">(</span><span class="n">context</span><span class="p">.</span><span class="n">currentGC</span><span class="p">(),</span> <span class="n">element</span><span class="p">.</span><span class="n">attribute</span><span class="p">(</span><span class="s">"cx"</span><span class="p">));</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">413</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">const</span> <span class="n">qreal</span> <span class="n">cy</span> <span class="o">=</span> <span class="n">element</span><span class="p">.</span><span class="n">attribute</span><span class="p">(</span><span class="s">"cy"</span><span class="p">).</span><span class="n">isEmpty</span><span class="p">()</span> <span class="o">?</span> <span class="mf">0.0</span> <span class="o">:</span> <span class="n">SvgUtil</span><span class="o">::</span><span class="n">parseUnitY</span><span class="p">(</span><span class="n">context</span><span class="p">.</span><span class="n">currentGC</span><span class="p">(),</span> <span class="n">element</span><span class="p">.</span><span class="n">attribute</span><span class="p">(</span><span class="s">"cy"</span><span class="p">));</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">getting the elemente twise is expensive. the attribute methods allows a default value to returned when it is not found. The only one lookup is needed.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fixed.</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 19th, 2011, 5:10 a.m., <b>Thorsten Zachmann</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/102315/diff/1/?file=31899#file31899line420" style="color: black; font-weight: bold; text-decoration: underline;">plugins/pathshapes/ellipse/EllipseShape.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">bool EllipseShape::saveSvg(SvgSavingContext &context)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">420</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">const</span> <span class="n">qreal</span> <span class="n">cx</span> <span class="o">=</span> <span class="n">element</span><span class="p">.</span><span class="n">attribute</span><span class="p">(</span><span class="s">"cx"</span><span class="p">).</span><span class="n">isEmpty</span><span class="p">()</span> <span class="o">?</span> <span class="mf">0.0</span> <span class="o">:</span> <span class="n">SvgUtil</span><span class="o">::</span><span class="n">parseUnitX</span><span class="p">(</span><span class="n">context</span><span class="p">.</span><span class="n">currentGC</span><span class="p">(),</span> <span class="n">element</span><span class="p">.</span><span class="n">attribute</span><span class="p">(</span><span class="s">"cx"</span><span class="p">));</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">421</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">const</span> <span class="n">qreal</span> <span class="n">cy</span> <span class="o">=</span> <span class="n">element</span><span class="p">.</span><span class="n">attribute</span><span class="p">(</span><span class="s">"cy"</span><span class="p">).</span><span class="n">isEmpty</span><span class="p">()</span> <span class="o">?</span> <span class="mf">0.0</span> <span class="o">:</span> <span class="n">SvgUtil</span><span class="o">::</span><span class="n">parseUnitY</span><span class="p">(</span><span class="n">context</span><span class="p">.</span><span class="n">currentGC</span><span class="p">(),</span> <span class="n">element</span><span class="p">.</span><span class="n">attribute</span><span class="p">(</span><span class="s">"cy"</span><span class="p">));</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">422</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">setSize</span><span class="p">(</span><span class="n">QSizeF</span><span class="p">(</span><span class="mi">2</span><span class="o">*</span><span class="n">r</span><span class="p">,</span> <span class="mi">2</span><span class="o">*</span><span class="n">r</span><span class="p">));</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">423</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">setPosition</span><span class="p">(</span><span class="n">QPointF</span><span class="p">(</span><span class="n">cx</span> <span class="o">-</span> <span class="n">r</span><span class="p">,</span> <span class="n">cy</span> <span class="o">-</span> <span class="n">r</span><span class="p">));</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Could this part be used commonly?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes, done.</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 19th, 2011, 5:10 a.m., <b>Thorsten Zachmann</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/102315/diff/1/?file=31903#file31903line331" style="color: black; font-weight: bold; text-decoration: underline;">plugins/pathshapes/rectangle/RectangleShape.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">bool RectangleShape::loadSvg(const KoXmlElement &element, SvgLoadingContext &context)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">331</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">const</span> <span class="kt">bool</span> <span class="n">hasRx</span> <span class="o">=</span> <span class="n">element</span><span class="p">.</span><span class="n">hasAttribute</span><span class="p">(</span><span class="s">"rx"</span><span class="p">);</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">332</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">const</span> <span class="kt">bool</span> <span class="n">hasRy</span> <span class="o">=</span> <span class="n">element</span><span class="p">.</span><span class="n">hasAttribute</span><span class="p">(</span><span class="s">"ry"</span><span class="p">);</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">333</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="kt">double</span> <span class="n">rx</span> <span class="o">=</span> <span class="n">hasRx</span> <span class="o">?</span> <span class="n">SvgUtil</span><span class="o">::</span><span class="n">parseUnitX</span><span class="p">(</span><span class="n">context</span><span class="p">.</span><span class="n">currentGC</span><span class="p">(),</span> <span class="n">element</span><span class="p">.</span><span class="n">attribute</span><span class="p">(</span><span class="s">"rx"</span><span class="p">))</span> <span class="o">:</span> <span class="mf">0.0</span><span class="p">;</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">334</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="kt">double</span> <span class="n">ry</span> <span class="o">=</span> <span class="n">hasRy</span> <span class="o">?</span> <span class="n">SvgUtil</span><span class="o">::</span><span class="n">parseUnitY</span><span class="p">(</span><span class="n">context</span><span class="p">.</span><span class="n">currentGC</span><span class="p">(),</span> <span class="n">element</span><span class="p">.</span><span class="n">attribute</span><span class="p">(</span><span class="s">"ry"</span><span class="p">))</span> <span class="o">:</span> <span class="mf">0.0</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Is it not possible to use the attribute method with a default value of 0.0. That will speedup the loading as it only needs to lookup the data once.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fixed.</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 19th, 2011, 5:10 a.m., <b>Thorsten Zachmann</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/102315/diff/1/?file=31908#file31908line354" style="color: black; font-weight: bold; text-decoration: underline;">plugins/pictureshape/PictureShape.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">bool PictureShape::loadSvg(const KoXmlElement &element, SvgLoadingContext &context)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">350</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">const</span> <span class="n">qreal</span> <span class="n">x</span> <span class="o">=</span> <span class="n">element</span><span class="p">.</span><span class="n">hasAttribute</span><span class="p">(</span><span class="s">"x"</span><span class="p">)</span> <span class="o">?</span> <span class="n">SvgUtil</span><span class="o">::</span><span class="n">parseUnitX</span><span class="p">(</span><span class="n">context</span><span class="p">.</span><span class="n">currentGC</span><span class="p">(),</span> <span class="n">element</span><span class="p">.</span><span class="n">attribute</span><span class="p">(</span><span class="s">"x"</span><span class="p">))</span> <span class="o">:</span> <span class="mi">0</span><span class="p">;</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">351</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">const</span> <span class="n">qreal</span> <span class="n">y</span> <span class="o">=</span> <span class="n">element</span><span class="p">.</span><span class="n">hasAttribute</span><span class="p">(</span><span class="s">"x"</span><span class="p">)</span> <span class="o">?</span> <span class="n">SvgUtil</span><span class="o">::</span><span class="n">parseUnitY</span><span class="p">(</span><span class="n">context</span><span class="p">.</span><span class="n">currentGC</span><span class="p">(),</span> <span class="n">element</span><span class="p">.</span><span class="n">attribute</span><span class="p">(</span><span class="s">"y"</span><span class="p">))</span> <span class="o">:</span> <span class="mi">0</span><span class="p">;</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">352</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">const</span> <span class="n">qreal</span> <span class="n">w</span> <span class="o">=</span> <span class="n">element</span><span class="p">.</span><span class="n">hasAttribute</span><span class="p">(</span><span class="s">"width"</span><span class="p">)</span> <span class="o">?</span> <span class="n">SvgUtil</span><span class="o">::</span><span class="n">parseUnitX</span><span class="p">(</span><span class="n">context</span><span class="p">.</span><span class="n">currentGC</span><span class="p">(),</span> <span class="n">element</span><span class="p">.</span><span class="n">attribute</span><span class="p">(</span><span class="s">"width"</span><span class="p">))</span> <span class="o">:</span> <span class="mi">0</span><span class="p">;</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">353</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">const</span> <span class="n">qreal</span> <span class="n">h</span> <span class="o">=</span> <span class="n">element</span><span class="p">.</span><span class="n">hasAttribute</span><span class="p">(</span><span class="s">"height"</span><span class="p">)</span> <span class="o">?</span> <span class="n">SvgUtil</span><span class="o">::</span><span class="n">parseUnitY</span><span class="p">(</span><span class="n">context</span><span class="p">.</span><span class="n">currentGC</span><span class="p">(),</span> <span class="n">element</span><span class="p">.</span><span class="n">attribute</span><span class="p">(</span><span class="s">"height"</span><span class="p">))</span> <span class="o">:</span> <span class="mi">0</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Please read the value only ones as described before.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fixed.</pre>
<br />
<p>- Jan</p>
<br />
<p>On August 13th, 2011, 4:53 p.m., Jan Hambrecht wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Jan Hambrecht.</div>
<p style="color: grey;"><i>Updated Aug. 13, 2011, 4:53 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch adds support for loading and saving embedded svg files within odf documents. There is an interface SvgSerializable which shapes can choose to implement to provide support for saving and loading themselves to and from svg. There are already some shapes ported to use that interface, namely ArtisticTextShape, EllipseShape, RectangleShape, PictureShape.
It also adds support for saving generic shapes to svg by utilizing the QSvgGenerator. Saving generic shapes to svg might be further improved in the future by having support to save odf to a single (flat) xml files which could be embedded into a svg document. This way we could utilize the native saving and loading support of non-svg shapes to not lose any data. Compatibility with other svg applications is ensured by using a svg:switch element which makes it possible to save different representations of a shape inside a svg document.
I put the svg classes into the flake library for now as I created a circular dependency between flake and the svg stuff while working on the patch.
However this dependency is currently not there anymore, so we might put these svg classes back into a separate lib. There are two things which might be considered which would then not allow separating flake and the svg classes.
1. There is a shape factory SvgShapeFactory which must be added to the shape registry to allow creating individual shapes from embedded svg content instead of using the VectorShape to display embedded svg content. The thing is, that this decision is probably application specific as e.g. karbon absolutely wants to have individual shape created from embeded svg content, whereas words might be perfectly happy to have the vector shape display svg content. If the factory is not added to the shape registry then copy pasting pure svg shapes like the artistic text shape is not possible without losing data (it would save itself to an embedded svg file but copying would produce a vector shape). So if we want the SvgShapeFactory always added to the shape registry, we probably would do that inside the shape registry itself.
2. Merging the two functions from SvgSerializable into KoShape. If we want to do that we would depend on the svg classes and separating them from flake would no longre be possible.
</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=236562">236562</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=271360">271360</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=274654">274654</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(d85a06f)</span></li>
<li>braindump/plugins/stateshape/StateShapeFactory.cpp <span style="color: grey">(526c182)</span></li>
<li>braindump/plugins/webshape/WebShapeFactory.cpp <span style="color: grey">(9c18655)</span></li>
<li>filters/karbon/CMakeLists.txt <span style="color: grey">(a979a73)</span></li>
<li>filters/karbon/svg/CMakeLists.txt <span style="color: grey">(14debd3)</span></li>
<li>filters/karbon/svg/SvgClipPathHelper.h <span style="color: grey">(05c4e62)</span></li>
<li>filters/karbon/svg/SvgClipPathHelper.cpp <span style="color: grey">(0fc6378)</span></li>
<li>filters/karbon/svg/SvgCssHelper.h <span style="color: grey">(86238b5)</span></li>
<li>filters/karbon/svg/SvgCssHelper.cpp <span style="color: grey">(d4a959b)</span></li>
<li>filters/karbon/svg/SvgExport.cpp <span style="color: grey">(1c49c7c)</span></li>
<li>filters/karbon/svg/SvgFilterHelper.h <span style="color: grey">(64d5828)</span></li>
<li>filters/karbon/svg/SvgFilterHelper.cpp <span style="color: grey">(56a093a)</span></li>
<li>filters/karbon/svg/SvgGradientHelper.h <span style="color: grey">(83486c2)</span></li>
<li>filters/karbon/svg/SvgGradientHelper.cpp <span style="color: grey">(c2a6090)</span></li>
<li>filters/karbon/svg/SvgGraphicContext.h <span style="color: grey">(0daa8cd)</span></li>
<li>filters/karbon/svg/SvgLoadingContext.h <span style="color: grey">(770a304)</span></li>
<li>filters/karbon/svg/SvgLoadingContext.cpp <span style="color: grey">(a7bb4a1)</span></li>
<li>filters/karbon/svg/SvgParser.h <span style="color: grey">(bd8a9dd)</span></li>
<li>filters/karbon/svg/SvgParser.cpp <span style="color: grey">(c539e90)</span></li>
<li>filters/karbon/svg/SvgPatternHelper.h <span style="color: grey">(70b14ac)</span></li>
<li>filters/karbon/svg/SvgPatternHelper.cpp <span style="color: grey">(42da550)</span></li>
<li>filters/karbon/svg/SvgSavingContext.h <span style="color: grey">(2022b00)</span></li>
<li>filters/karbon/svg/SvgSavingContext.cpp <span style="color: grey">(2333910)</span></li>
<li>filters/karbon/svg/SvgTextHelper.h <span style="color: grey">(b0b3060)</span></li>
<li>filters/karbon/svg/SvgTextHelper.cpp <span style="color: grey">(6104664)</span></li>
<li>filters/karbon/svg/SvgUtil.h <span style="color: grey">(87a8f14)</span></li>
<li>filters/karbon/svg/SvgUtil.cpp <span style="color: grey">(92f635c)</span></li>
<li>filters/karbon/svg/SvgWriter.h <span style="color: grey">(2644ce1)</span></li>
<li>filters/karbon/svg/SvgWriter.cpp <span style="color: grey">(2bcc664)</span></li>
<li>karbon/ui/KarbonPart.cpp <span style="color: grey">(1eb5319)</span></li>
<li>kexi/shapes/relationdesign/kexirelationdesignfactory.cpp <span style="color: grey">(2cfd5b9)</span></li>
<li>kpresenter/part/KPrPlaceholderShapeFactory.cpp <span style="color: grey">(fdca058)</span></li>
<li>libs/flake/CMakeLists.txt <span style="color: grey">(b9f388f)</span></li>
<li>libs/flake/KoConnectionShapeFactory.cpp <span style="color: grey">(7e96f2b)</span></li>
<li>libs/flake/KoPathShapeFactory.cpp <span style="color: grey">(c62658e)</span></li>
<li>libs/flake/KoShapeFactoryBase.h <span style="color: grey">(79a893d)</span></li>
<li>libs/flake/KoShapeFactoryBase.cpp <span style="color: grey">(fbbab41)</span></li>
<li>libs/flake/KoShapeRegistry.h <span style="color: grey">(593e61a)</span></li>
<li>libs/flake/KoShapeRegistry.cpp <span style="color: grey">(06e4c7c)</span></li>
<li>libs/flake/svg/SvgClipPathHelper.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/flake/svg/SvgClipPathHelper.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/flake/svg/SvgCssHelper.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/flake/svg/SvgCssHelper.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/flake/svg/SvgFilterHelper.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/flake/svg/SvgFilterHelper.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/flake/svg/SvgGradientHelper.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/flake/svg/SvgGradientHelper.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/flake/svg/SvgGraphicContext.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/flake/svg/SvgGraphicContext.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/flake/svg/SvgLoadingContext.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/flake/svg/SvgLoadingContext.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/flake/svg/SvgParser.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/flake/svg/SvgParser.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/flake/svg/SvgPatternHelper.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/flake/svg/SvgPatternHelper.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/flake/svg/SvgSavingContext.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/flake/svg/SvgSavingContext.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/flake/svg/SvgSerializable.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/flake/svg/SvgSerializable.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/flake/svg/SvgShapeFactory.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/flake/svg/SvgShapeFactory.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/flake/svg/SvgStyleParser.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/flake/svg/SvgStyleParser.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/flake/svg/SvgStyleWriter.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/flake/svg/SvgStyleWriter.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/flake/svg/SvgUtil.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/flake/svg/SvgUtil.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/flake/svg/SvgWriter.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/flake/svg/SvgWriter.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/artistictextshape/ArtisticTextLoadingContext.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/artistictextshape/ArtisticTextLoadingContext.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/artistictextshape/ArtisticTextShape.h <span style="color: grey">(253113e)</span></li>
<li>plugins/artistictextshape/ArtisticTextShape.cpp <span style="color: grey">(1883968)</span></li>
<li>plugins/artistictextshape/ArtisticTextShapeFactory.cpp <span style="color: grey">(de4ad1f)</span></li>
<li>plugins/artistictextshape/ArtisticTextTool.cpp <span style="color: grey">(2c57c07)</span></li>
<li>plugins/artistictextshape/CMakeLists.txt <span style="color: grey">(f92533d)</span></li>
<li>plugins/chartshape/ChartShapeFactory.cpp <span style="color: grey">(793aa46)</span></li>
<li>plugins/commentshape/CommentShapeFactory.cpp <span style="color: grey">(869cc66)</span></li>
<li>plugins/formulashape/KoFormulaShapeFactory.cpp <span style="color: grey">(588a9e2)</span></li>
<li>plugins/musicshape/MusicShapeFactory.cpp <span style="color: grey">(c61e9fc)</span></li>
<li>plugins/pathshapes/CMakeLists.txt <span style="color: grey">(e773367)</span></li>
<li>plugins/pathshapes/ellipse/EllipseShape.h <span style="color: grey">(4bc766e)</span></li>
<li>plugins/pathshapes/ellipse/EllipseShape.cpp <span style="color: grey">(0576f5d)</span></li>
<li>plugins/pathshapes/ellipse/EllipseShapeFactory.cpp <span style="color: grey">(9fa50fe)</span></li>
<li>plugins/pathshapes/enhancedpath/EnhancedPathShapeFactory.cpp <span style="color: grey">(4086698)</span></li>
<li>plugins/pathshapes/rectangle/RectangleShape.h <span style="color: grey">(08d5423)</span></li>
<li>plugins/pathshapes/rectangle/RectangleShape.cpp <span style="color: grey">(9caca45)</span></li>
<li>plugins/pathshapes/rectangle/RectangleShapeFactory.cpp <span style="color: grey">(51c92fb)</span></li>
<li>plugins/pathshapes/star/StarShapeFactory.cpp <span style="color: grey">(984b938)</span></li>
<li>plugins/pictureshape/CMakeLists.txt <span style="color: grey">(1539312)</span></li>
<li>plugins/pictureshape/PictureShape.h <span style="color: grey">(527d2e4)</span></li>
<li>plugins/pictureshape/PictureShape.cpp <span style="color: grey">(5dc1c7b)</span></li>
<li>plugins/pictureshape/PictureShapeFactory.cpp <span style="color: grey">(313e1be)</span></li>
<li>plugins/pluginshape/PluginShapeFactory.cpp <span style="color: grey">(6aa335a)</span></li>
<li>plugins/textshape/TextShapeFactory.cpp <span style="color: grey">(365b2e7)</span></li>
<li>plugins/treeshape/TreeShapeFactory.cpp <span style="color: grey">(b7b36ec)</span></li>
<li>plugins/vectorshape/VectorShapeFactory.cpp <span style="color: grey">(eeb1674)</span></li>
<li>plugins/videoshape/VideoShapeFactory.cpp <span style="color: grey">(7b27bd4)</span></li>
<li>tables/shape/TableShapeFactory.cpp <span style="color: grey">(ef9cccf)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102315/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>