<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102200/">http://git.reviewboard.kde.org/r/102200/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Pierre Ducroquet.</div>
<p style="color: grey;"><i>Updated Aug. 3, 2011, 8:50 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fix whitespaces</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">First refactoring of KoText table borders :
- get rid of the rendering code that was sitting in kotext/styles and move it to its own class in textlayout
- simplify KoTableCellStyle by kicking KoTableBorderStyle and removing the edges/borders private members
Next step : get rid of most of these properties and replace them with a KoBorder property.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">- Compilation
- Running unit tests
- Rendering of sample documents</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>filters/libmsooxml/MsooXmlDrawingTableStyleReader.cpp <span style="color: grey">(849d4bad4d5b6e9f7a658d1f9def3092486c0b27)</span></li>
<li>filters/words/docx/DocxXmlDocumentReader.cpp <span style="color: grey">(98ddcf56cfbc08c6d109a9f2b4967695f6022cf9)</span></li>
<li>libs/kotext/CMakeLists.txt <span style="color: grey">(46c194fc27d3fd6437675afd90e96833e75df7f0)</span></li>
<li>libs/kotext/KoTextBlockBorderData.cpp <span style="color: grey">(c829b5cd857f004d60002a09b2ba38b4b60bd065)</span></li>
<li>libs/kotext/KoTextDebug.cpp <span style="color: grey">(3d65b666efb1dfee24b9054e5c6346d454bd31df)</span></li>
<li>libs/kotext/KoTextEditor.cpp <span style="color: grey">(70c421d6011e7871a17acca1b2a91f80cf553c0f)</span></li>
<li>libs/kotext/opendocument/tests/TestLoading.cpp <span style="color: grey">(c36deda2816a2709e965208adca41d41a7e17672)</span></li>
<li>libs/kotext/styles/KoTableBorderStyle.h <span style="color: grey">(2bb46dd9c91398ef29928de97a027d3e09a73b2a)</span></li>
<li>libs/kotext/styles/KoTableBorderStyle.cpp <span style="color: grey">(ab88d8d2d555996d38d900a9ebb6bada668378f7)</span></li>
<li>libs/kotext/styles/KoTableBorderStyle_p.h <span style="color: grey">(ca9d32d2466fbb808791a3d23618b2e3bb778a34)</span></li>
<li>libs/kotext/styles/KoTableCellStyle.h <span style="color: grey">(dfb6967b846b21e6608e74a55f06441265df900b)</span></li>
<li>libs/kotext/styles/KoTableCellStyle.cpp <span style="color: grey">(f68cd03d93f048dbfcded91d53e51c2737c4b7a9)</span></li>
<li>libs/kotext/styles/KoTableCellStyle_p.h <span style="color: grey">(3935c8190bc4f0c8c40f01886d9a7279fc22b689)</span></li>
<li>libs/kotext/styles/tests/TestTableCellStyle.cpp <span style="color: grey">(e752e239db388f9144d13f575da0b1c52abc1689)</span></li>
<li>libs/odf/KoBorder.h <span style="color: grey">(c7b9b5d97772569026dfc6bf3723ee93f7331f8a)</span></li>
<li>libs/odf/KoBorder.cpp <span style="color: grey">(4772305867b260acd76dab549c9de5ebeaaceb6a)</span></li>
<li>libs/textlayout/CMakeLists.txt <span style="color: grey">(a364ac50240e8bd6e93d9aca73c43ae426d1bfd1)</span></li>
<li>libs/textlayout/KoTextLayoutCellHelper.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/textlayout/KoTextLayoutCellHelper.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/textlayout/KoTextLayoutTableArea.cpp <span style="color: grey">(28aebe3a949fd089619ab686a984ccc9333160ee)</span></li>
<li>words/part/KWCanvasBase.cpp <span style="color: grey">(9589f08dd172b097771369929f777e35b4d7f7dc)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102200/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>