<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102168/">http://git.reviewboard.kde.org/r/102168/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Since no one complained</pre>
<br />
<p>- Casper</p>
<br />
<p>On August 1st, 2011, 9:07 a.m., Boudewijn Rempt wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Boudewijn Rempt.</div>
<p style="color: grey;"><i>Updated Aug. 1, 2011, 9:07 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">KoTextEditor used to be KoTextSelectionHandler and back then was ties to KoToolSelection. KoToolSelection was meant to allow access to the selection the tool handles inside the shape data, not to allow edit access to the entire data inside the shape. KoTextEditor was refactored to belong to the QTextDocument inside a text shape and be a generic editing interface.
This patch takes the initial refactoring further along and removes the connection between KoToolSelection and KoTextEditor by adding a new TextToolSelection class that proxies for to KoTextEditor::hasSelection, but doesn't return the KoTextEditor of the document the tool is acting on.
Instead, it's now possible to query the canvas for the currently selected shapes, check whether one of those shapes has a KoTextShapeDataBase and then return the associated KoTextEditor for that, following Pierre's idea of making KoTextEditor associated not with the current tool but with the shapes.
(For the patches individually, see my mail to the mailing list)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/flake/KoToolProxy.h <span style="color: grey">(ced32ac)</span></li>
<li>libs/flake/KoToolProxy.cpp <span style="color: grey">(3576b78)</span></li>
<li>libs/kotext/InsertInlineObjectActionBase.cpp <span style="color: grey">(9647a56)</span></li>
<li>libs/kotext/InsertTextLocator.cpp <span style="color: grey">(2195a02)</span></li>
<li>libs/kotext/KoTextDocument.h <span style="color: grey">(f74a9bd)</span></li>
<li>libs/kotext/KoTextEditor.h <span style="color: grey">(02d0ef1)</span></li>
<li>libs/kotext/KoTextEditor.cpp <span style="color: grey">(70c421d)</span></li>
<li>libs/main/rdf/InsertSemanticObjectActionBase.h <span style="color: grey">(28b0b83)</span></li>
<li>libs/main/rdf/InsertSemanticObjectActionBase.cpp <span style="color: grey">(cc37e4c)</span></li>
<li>libs/main/rdf/KoDocumentRdf.h <span style="color: grey">(676c84c)</span></li>
<li>libs/main/rdf/KoDocumentRdf.cpp <span style="color: grey">(b9d2525)</span></li>
<li>libs/main/rdf/KoDocumentRdfEditWidget.cpp <span style="color: grey">(6114daa)</span></li>
<li>libs/main/rdf/KoRdfSemanticItem.cpp <span style="color: grey">(c92634e)</span></li>
<li>libs/main/rdf/KoRdfSemanticItemViewSite.cpp <span style="color: grey">(3e8d2d0)</span></li>
<li>libs/main/rdf/KoRdfSemanticTreeWidgetItem.cpp <span style="color: grey">(de2c34c)</span></li>
<li>libs/main/rdf/RdfSemanticTreeWidgetAction.h <span style="color: grey">(438fb43)</span></li>
<li>libs/main/rdf/RdfSemanticTreeWidgetAction.cpp <span style="color: grey">(c55b477)</span></li>
<li>libs/main/rdf/RdfSemanticTreeWidgetSelectAction.cpp <span style="color: grey">(4e527ff)</span></li>
<li>plugins/textshape/TextTool.cpp <span style="color: grey">(8eb7483)</span></li>
<li>plugins/textshape/commands/TextPasteCommand.cpp <span style="color: grey">(514fe70)</span></li>
<li>tools/koabstraction/KoAbstractApplicationController.cpp <span style="color: grey">(89440a0)</span></li>
<li>tools/mobile/ApplicationController.cpp <span style="color: grey">(008233c)</span></li>
<li>words/part/KWView.cpp <span style="color: grey">(0232eae)</span></li>
<li>words/part/dialogs/KWInsertInlineNoteDialog.cpp <span style="color: grey">(abe18a9)</span></li>
<li>words/part/dockers/KWRdfDocker.cpp <span style="color: grey">(b8ebd83)</span></li>
<li>words/part/dockers/KWRdfDockerTree.h <span style="color: grey">(d9a2e3c)</span></li>
<li>words/part/dockers/KWRdfDockerTree.cpp <span style="color: grey">(619135a)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102168/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>