<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102072/">http://git.reviewboard.kde.org/r/102072/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/102072/diff/4/?file=30652#file30652line63" style="color: black; font-weight: bold; text-decoration: underline;">libs/flake/KoShapeGroup.cpp</a>
<span style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void KoShapeGroup::shapeCountChanged()</pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">62</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="kt">void</span> <span class="n">KoShapeGroup</span><span class="o">::</span><span class="n">shapeCountChanged</span><span class="p">()</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">63</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="n">QRectF</span> <span class="n">KoShapeGroup</span><span class="o">::</span><span class="n">boundingRect</span><span class="p">()</span> <span class="k">const</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Please check that this patch doesn't regress on bug 227512 and the things described in https://svn.reviewboard.kde.org/r/5231/ and https://svn.reviewboard.kde.org/r/5253/. You need to test in Krita for that, I'm afraid.</pre>
</div>
<br />
<p>- Boudewijn</p>
<br />
<p>On August 3rd, 2011, 7:20 a.m., Yue Liu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Yue Liu.</div>
<p style="color: grey;"><i>Updated Aug. 3, 2011, 7:20 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Added support for drawing the shadow for a shape group, fixed shadow blur zooming bug.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">http://my.cdash.org/viewTest.php?onlydelta&buildid=212010</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/flake/KoShapeContainer.cpp <span style="color: grey">(e7585ec)</span></li>
<li>libs/flake/KoShapeGroup.h <span style="color: grey">(5ccd574)</span></li>
<li>libs/flake/KoShapeGroup.cpp <span style="color: grey">(aaa58b4)</span></li>
<li>libs/flake/KoShapeShadow.h <span style="color: grey">(07c760c)</span></li>
<li>libs/flake/KoShapeShadow.cpp <span style="color: grey">(5485b19)</span></li>
<li>libs/flake/tests/TestShapeGroupCommand.cpp <span style="color: grey">(397c17b)</span></li>
<li>libs/widgets/KoShadowConfigWidget.cpp <span style="color: grey">(1a41042)</span></li>
<li>plugins/dockers/shadowdocker/ShadowDocker.cpp <span style="color: grey">(ef53fae)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102072/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/102072/s/210/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2011/07/24/snapshot1_400x100.png" style="border: 1px black solid;" alt="groupshadow / shape shadow" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>