<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102072/">http://git.reviewboard.kde.org/r/102072/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think the fix to set the size of the group shape simply to zero is wrong. The filter effects can be applied to a group and these need a proper size of a shape to work correctly.</pre>
<br />
<p>- Jan</p>
<br />
<p>On August 3rd, 2011, 7:20 a.m., Yue Liu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Yue Liu.</div>
<p style="color: grey;"><i>Updated Aug. 3, 2011, 7:20 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Added support for drawing the shadow for a shape group, fixed shadow blur zooming bug.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">http://my.cdash.org/viewTest.php?onlydelta&buildid=212010</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/flake/KoShapeContainer.cpp <span style="color: grey">(e7585ec)</span></li>
<li>libs/flake/KoShapeGroup.h <span style="color: grey">(5ccd574)</span></li>
<li>libs/flake/KoShapeGroup.cpp <span style="color: grey">(aaa58b4)</span></li>
<li>libs/flake/KoShapeShadow.h <span style="color: grey">(07c760c)</span></li>
<li>libs/flake/KoShapeShadow.cpp <span style="color: grey">(5485b19)</span></li>
<li>libs/flake/tests/TestShapeGroupCommand.cpp <span style="color: grey">(397c17b)</span></li>
<li>libs/widgets/KoShadowConfigWidget.cpp <span style="color: grey">(1a41042)</span></li>
<li>plugins/dockers/shadowdocker/ShadowDocker.cpp <span style="color: grey">(ef53fae)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102072/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/102072/s/210/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2011/07/24/snapshot1_400x100.png" style="border: 1px black solid;" alt="groupshadow / shape shadow" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>