<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102127/">http://git.reviewboard.kde.org/r/102127/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm fine with this.
Pierre?</pre>
<br />
<p>- Casper</p>
<br />
<p>On July 29th, 2011, 8:47 a.m., Boudewijn Rempt wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra, Pierre Stirnweiss and Casper Boemann.</div>
<div>By Boudewijn Rempt.</div>
<p style="color: grey;"><i>Updated July 29, 2011, 8:47 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Using KoToolProxy->selection and casting that into a KoTextEditor is is
confusing: it is meant to allow access to the selection, not to allow
access to the complete contents of a shape. The KoTexSelectionHandler
to KoTextEditor change was meant to get away from the dependency on the
active tool.
Now we get the selected shape from the active canvas and if it has the
right userdata, get the right KoTextEditor from it, and use that to
insert the variable.
Also, KoTextEditor now return the variable instead of a bool, because
the InsertInlineObjectActionBase::createInlineObject wants to return
that object.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/kotext/InsertTextLocator.cpp <span style="color: grey">(2195a02)</span></li>
<li>libs/kotext/KoTextEditor.h <span style="color: grey">(02d0ef1)</span></li>
<li>libs/kotext/KoTextEditor.cpp <span style="color: grey">(70c421d)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102127/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>