<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102108/">http://git.reviewboard.kde.org/r/102108/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">just a few small cosmetic issues, but otherwise good</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/102108/diff/1/?file=30179#file30179line783" style="color: black; font-weight: bold; text-decoration: underline;">libs/kotext/KoTextEditor.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void KoTextEditor::insertInlineObject(KoInlineObject *inliner)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">783</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="ew"> </span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">spaces</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/102108/diff/1/?file=30184#file30184line43" style="color: black; font-weight: bold; text-decoration: underline;">libs/kotext/KoTextSoftPageBreak.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">public:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">43</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">virtual</span> <span class="kt">void</span> <span class="n">updatePosition</span><span class="p">(</span><span class="k">const</span> <span class="n">QTextDocument</span> <span class="o">*</span><span class="n">document</span><span class="p">,</span> <span class="n"><span class="hl">QTextInlineObject</span></span><span class="hl"> </span><span class="n"><span class="hl">object</span></span><span class="p"><span class="hl">,</span></span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">43</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">virtual</span> <span class="kt">void</span> <span class="n">updatePosition</span><span class="p">(</span><span class="k">const</span> <span class="n">QTextDocument</span> <span class="o">*</span><span class="n">document</span><span class="p">,</span><span class="ew"> </span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">space at end</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/102108/diff/1/?file=30185#file30185line52" style="color: black; font-weight: bold; text-decoration: underline;">libs/kotext/KoTextSoftPageBreak.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void KoTextSoftPageBreak::saveOdf(KoShapeSavingContext &context)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">52</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="kt">void</span> <span class="n">KoTextSoftPageBreak</span><span class="o">::</span><span class="n">updatePosition</span><span class="p">(</span><span class="k">const</span> <span class="n">QTextDocument</span> <span class="o">*</span><span class="n">document</span><span class="p">,</span> <span class="n"><span class="hl">QTextInlineObject</span></span><span class="hl"> </span><span class="n"><span class="hl">object</span></span><span class="p"><span class="hl">,</span></span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">52</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="kt">void</span> <span class="n">KoTextSoftPageBreak</span><span class="o">::</span><span class="n">updatePosition</span><span class="p">(</span><span class="k">const</span> <span class="n">QTextDocument</span> <span class="o">*</span><span class="n">document</span><span class="p">,</span><span class="ew"> </span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">space at end</pre>
</div>
<br />
<p>- Casper</p>
<br />
<p>On July 28th, 2011, 12:51 p.m., Boudewijn Rempt wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Boudewijn Rempt.</div>
<p style="color: grey;"><i>Updated July 28, 2011, 12:51 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Remove unused and confusing parameter from KoInlineObject.
The QTextObject parameter was added in the initial commit of KoInlineObjectBase but never used. This patch removes the confusing parameter.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">ran the tests & words.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/kotext/KoBookmark.h <span style="color: grey">(747dbfe)</span></li>
<li>libs/kotext/KoBookmark.cpp <span style="color: grey">(256111e)</span></li>
<li>libs/kotext/KoInlineNote.h <span style="color: grey">(0bb1106)</span></li>
<li>libs/kotext/KoInlineNote.cpp <span style="color: grey">(98876c7)</span></li>
<li>libs/kotext/KoInlineObject.h <span style="color: grey">(653c951)</span></li>
<li>libs/kotext/KoInlineTextObjectManager.h <span style="color: grey">(c6c4f15)</span></li>
<li>libs/kotext/KoTextAnchor.h <span style="color: grey">(f8fcd01)</span></li>
<li>libs/kotext/KoTextAnchor.cpp <span style="color: grey">(c0a6f8c)</span></li>
<li>libs/kotext/KoTextEditor.cpp <span style="color: grey">(7dba349)</span></li>
<li>libs/kotext/KoTextLocator.h <span style="color: grey">(d8d5f0a)</span></li>
<li>libs/kotext/KoTextLocator.cpp <span style="color: grey">(e35ea1c)</span></li>
<li>libs/kotext/KoTextMeta.h <span style="color: grey">(1160079)</span></li>
<li>libs/kotext/KoTextMeta.cpp <span style="color: grey">(4f0fd18)</span></li>
<li>libs/kotext/KoTextSoftPageBreak.h <span style="color: grey">(af311a9)</span></li>
<li>libs/kotext/KoTextSoftPageBreak.cpp <span style="color: grey">(b961541)</span></li>
<li>libs/kotext/KoVariable.h <span style="color: grey">(eb0e465)</span></li>
<li>libs/kotext/KoVariable.cpp <span style="color: grey">(fe53f2e)</span></li>
<li>libs/kotext/changetracker/KoDeleteChangeMarker.h <span style="color: grey">(4e90dcb)</span></li>
<li>libs/kotext/changetracker/KoDeleteChangeMarker.cpp <span style="color: grey">(1ce3c32)</span></li>
<li>libs/kotext/opendocument/KoTextLoader.cpp <span style="color: grey">(eadeeae)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102108/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>