<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101820/">http://git.reviewboard.kde.org/r/101820/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hello Paul,
I did not yet look at the code. However I have tested the patch and found the following:
When changing the zoom level in the slide sorted only the zoom in the upper window changes not the one on the custom slide show. Both lists should be updated when changing the zoom. When the zoom is changed and then you move a item from up to down the position indicator is wrong. This is related to the not zooming of the lower (custom slide show)
</pre>
<br />
<p>- Thorsten</p>
<br />
<p>On July 18th, 2011, 10:38 p.m., Paul Mendez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Paul Mendez.</div>
<p style="color: grey;"><i>Updated July 18, 2011, 10:38 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">(preliminary) new GUI for manage custom slide shows.
Note: As some GUI integration is still missing, it's only a review request, it isn't for merge with master branch.
(part of GSoC project)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">build and run</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kpresenter/part/CMakeLists.txt <span style="color: grey">(613ff8d3de84a19776df1651c0bd3604fc395099)</span></li>
<li>kpresenter/part/KPrAnimationDirector.cpp <span style="color: grey">(d9600e220546f5d5ed29f73e1988f3d130f69770)</span></li>
<li>kpresenter/part/KPrCustomSlideShows.h <span style="color: grey">(7d8a91b67e14e32312fd2706dcede6efac6e1aa7)</span></li>
<li>kpresenter/part/KPrCustomSlideShows.cpp <span style="color: grey">(632dda6b772417b3d26a84992352f9caa33ca158)</span></li>
<li>kpresenter/part/KPrCustomSlideShowsModel.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kpresenter/part/KPrCustomSlideShowsModel.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kpresenter/part/KPrDocument.h <span style="color: grey">(7756f5e542738232bb3ea278453319a71d28ce9d)</span></li>
<li>kpresenter/part/KPrDocument.cpp <span style="color: grey">(02bf53cf087746f1942adad5db3f1e4d30a1b618)</span></li>
<li>kpresenter/part/KPrSlidesManagerView.h <span style="color: grey">(6f345e049cdf746e00fdfd9e3e7644668ff9e96e)</span></li>
<li>kpresenter/part/KPrSlidesManagerView.cpp <span style="color: grey">(39e80b1b770584f97e6bfcbcebc06bd107bc1a68)</span></li>
<li>kpresenter/part/KPrSlidesSorterDocumentModel.h <span style="color: grey">(a5b65a4d87f8af6a51b4e1992c2ac2a3d23aed37)</span></li>
<li>kpresenter/part/KPrSlidesSorterDocumentModel.cpp <span style="color: grey">(4938e3696bed3fb90c017aba5997c40268ce3e99)</span></li>
<li>kpresenter/part/KPrSlidesSorterItemDelegate.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kpresenter/part/KPrSlidesSorterItemDelegate.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kpresenter/part/KPrView.h <span style="color: grey">(a558a2e171731a2390bf5a709a829132082b993b)</span></li>
<li>kpresenter/part/KPrView.cpp <span style="color: grey">(04d502d4d61551ad0bd6dfabff9b8237e378b38c)</span></li>
<li>kpresenter/part/KPrViewModePresentation.cpp <span style="color: grey">(46b61e1de8a9bdcab8bcb81ac3ea2830ff6f2e24)</span></li>
<li>kpresenter/part/KPrViewModeSlidesSorter.h <span style="color: grey">(240bd9e0c6b4158ff0726f2e72e4c79982a9ea18)</span></li>
<li>kpresenter/part/KPrViewModeSlidesSorter.cpp <span style="color: grey">(61866f8a1344e1999224444d71a46a1a21a1864e)</span></li>
<li>kpresenter/part/commands/KPrAddCustomSlideShowCommand.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kpresenter/part/commands/KPrAddCustomSlideShowCommand.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kpresenter/part/commands/KPrDelCustomSlideShowCommand.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kpresenter/part/commands/KPrDelCustomSlideShowCommand.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kpresenter/part/commands/KPrDeleteSlidesCommand.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kpresenter/part/commands/KPrDeleteSlidesCommand.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kpresenter/part/commands/KPrEditCustomSlideShowsCommand.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kpresenter/part/commands/KPrEditCustomSlideShowsCommand.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kpresenter/part/commands/KPrRenameCustomSlideShowCommand.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kpresenter/part/commands/KPrRenameCustomSlideShowCommand.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kpresenter/part/commands/KPrSetCustomSlideShowsCommand.h <span style="color: grey">(6cc29e2cd44ef4fc2b63efbc1c3187cfd4ccd198)</span></li>
<li>kpresenter/part/commands/KPrSetCustomSlideShowsCommand.cpp <span style="color: grey">(24b99969ce4cbe55a480e43e98d2ae370c20e721)</span></li>
<li>kpresenter/part/tests/CMakeLists.txt <span style="color: grey">(f9b56a6ed55ebe610ae30cd21437975c00c317d1)</span></li>
<li>kpresenter/part/tests/PAMock.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kpresenter/part/tests/TestAddCustomSlideShowCommand.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kpresenter/part/tests/TestAddCustomSlideShowCommand.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kpresenter/part/tests/TestDelCustomSlideShowCommand.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kpresenter/part/tests/TestDelCustomSlideShowCommand.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kpresenter/part/tests/TestEditCustomSlideShowsCommand.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kpresenter/part/tests/TestEditCustomSlideShowsCommand.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kpresenter/part/tests/TestRenameCustomSlideShowCommand.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kpresenter/part/tests/TestRenameCustomSlideShowCommand.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kpresenter/part/ui/KPrConfigureSlideShowDialog.h <span style="color: grey">(1c7794a2ff08e096b8a86cf2673db0e6f206eeb6)</span></li>
<li>kpresenter/part/ui/KPrConfigureSlideShowDialog.cpp <span style="color: grey">(847a5a54a08fb46dab34bbd828da8d1ab21c6342)</span></li>
<li>kpresenter/part/ui/KPrCustomSlideShowsDialog.h <span style="color: grey">(f5d53f90ca2d1e7c53ac4779a751a8d58e384a0c)</span></li>
<li>kpresenter/part/ui/KPrCustomSlideShowsDialog.cpp <span style="color: grey">(da697e04426c8c8c4d8684af1da9fd10c7faac61)</span></li>
<li>kpresenter/part/ui/KPrCustomSlideShowsDialog.ui <span style="color: grey">(be25bc8932809e41a139f364478d2097eaa78110)</span></li>
<li>libs/kopageapp/KoPADocument.h <span style="color: grey">(9347ae9c8a302c0dc6c0139c2d1e0951cd5a6091)</span></li>
<li>libs/kopageapp/KoPADocument.cpp <span style="color: grey">(2a03e42fde69f5d4b0b144ccbde915ef826de70d)</span></li>
<li>libs/kopageapp/KoPADocumentStructureDocker.cpp <span style="color: grey">(02af38237e08e075934cd5110efe59e56234a9e2)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101820/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>