<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101873/">http://git.reviewboard.kde.org/r/101873/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I tested the patch. Unfortunately the chosen implementation to paint the subpath separately does not work out. There are 2 problems I can see:
1. When a shape has a filling and you create a shape with a hole in it like a doughnut it now also fills the hole in the center as both path are handled separately which they should not.
2. If you have a gradient background each subpath shows the full gradient inside itself instead over the complete shape.
I have uploaded a test file which shows both problems and screenshots with and without the patch
www.zagge.de/anchor/fill/
</pre>
<br />
<p>- Thorsten</p>
<br />
<p>On July 12th, 2011, 3:59 p.m., Lukáš Tvrdý wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra, Jan Hambrecht and Thorsten Zachmann.</div>
<div>By Lukáš Tvrdý.</div>
<p style="color: grey;"><i>Updated July 12, 2011, 3:59 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch implements S and F commands in draw:enhanced-path. So far there were no support for this.
The idea is that the path is now rendered per sub-path, because S (no stroke) and F (no fill) can be
specified per subpath in the draw:enhanced-path.
I changed typedef KoSubpath to standalone class as it needs attributes about no fill and no stroke.
I moved the code that operates only on KoSubpath to that class from KoPathShape.
Then I render the output per QPainterPath with appropriate attributes (I turn off the pen temporary if no stroke and turn of the brush if no fill)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">From bug 239561:
a) before patch http://wstaw.org/m/2011/07/07/nofill_nostroke_example_before.png
b) with my patch http://wstaw.org/m/2011/07/07/nofill_nostroke_example_after.png
I first managed to break several unit tests (TestPointMergeCommand and TestPathShape),
but I fixed all the problems and no tests are broken by this patch now.
</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=239561">239561</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>karbon/plugins/tools/CalligraphyTool/KarbonSimplifyPath.cpp <span style="color: grey">(d292508)</span></li>
<li>libs/flake/CMakeLists.txt <span style="color: grey">(b9f388f)</span></li>
<li>libs/flake/KoPathShape.h <span style="color: grey">(8b54f26)</span></li>
<li>libs/flake/KoPathShape.cpp <span style="color: grey">(da6c928)</span></li>
<li>libs/flake/KoPathShape_p.h <span style="color: grey">(e1e2843)</span></li>
<li>libs/flake/KoSubpath.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/flake/KoSubpath.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/flake/commands/KoSubpathRemoveCommand.cpp <span style="color: grey">(79894f0)</span></li>
<li>plugins/pathshapes/ellipse/EllipseShape.cpp <span style="color: grey">(0576f5d)</span></li>
<li>plugins/pathshapes/enhancedpath/EnhancedPathCommand.cpp <span style="color: grey">(a58d67e)</span></li>
<li>plugins/pathshapes/enhancedpath/EnhancedPathShape.cpp <span style="color: grey">(46d76de)</span></li>
<li>plugins/pathshapes/star/StarShape.cpp <span style="color: grey">(5fc8562)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101873/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>