<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101820/">http://git.reviewboard.kde.org/r/101820/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 11th, 2011, 4 a.m., <b>Thorsten Zachmann</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Some things I noticed when testing:
The custom slide show name is not fully readable when the name is to long for the combobox. The combo box should use a bigger width if available (not the full width that is available) so that the full name is readable. At the moment it is just to small.
It is not possible to add the same slide to a custom slide show multiple time. That should be possible as the user does not need to create copies of the slide if he wants to use it multiple times.
The animation that is show when a custom slide show gets selected should be faster. At the moment it takes quite some time.
The old way of adding custom slide shows should be removed the same time the new custom slide shows are added. To make the feature easier to find the menu entry in Edit menu should bring you to the new stuff.
If a slide is deleted (e.g. in the normal slide sorter) that is part of a custom slide show it is not readadded to the custom slide show when the delete of the slide is undone.</pre>
</blockquote>
<p>On July 11th, 2011, 4:03 a.m., <b>Thorsten Zachmann</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Forget the most important thing. This all looks very nice and I like it very much. Good work.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks, I haven't notice the combobox length problem, because when you work with a document that already have some custom shows, the combobox takes the length of the longest name. So now, I will fix it.
I have to explore more how to add the same slide multiple times, because I could easily add it to the custom show list, but when you go to presentation mode it shows only one slide and in some occasions I got some extrange behaviour like infinite loops, or things like that.
The animation is fast in my computer, but I think there isn't problem on reduce the animation time.
I was thinking to work in the integration with application menus this week.
I started working in the undo command for deleted slides last week but I couldn't yet find a way to recover the delete cmd and then concatenate it with a new delete command, or other way to make the two commands work at the same time.
</pre>
<br />
<p>- Paul</p>
<br />
<p>On July 8th, 2011, 8:02 p.m., Paul Mendez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Paul Mendez.</div>
<p style="color: grey;"><i>Updated July 8, 2011, 8:02 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">(preliminary) new GUI for manage custom slide shows.
Note: As some GUI integration is still missing, it's only a review request, it isn't for merge with master branch.
(part of GSoC project)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">build and run</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kpresenter/part/CMakeLists.txt <span style="color: grey">(613ff8d3de84a19776df1651c0bd3604fc395099)</span></li>
<li>kpresenter/part/KPrCustomSlideShows.h <span style="color: grey">(7d8a91b67e14e32312fd2706dcede6efac6e1aa7)</span></li>
<li>kpresenter/part/KPrCustomSlideShows.cpp <span style="color: grey">(4088a7446d2992d3d56059bec4ad646b4bbfc77f)</span></li>
<li>kpresenter/part/KPrCustomSlideShowsModel.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kpresenter/part/KPrCustomSlideShowsModel.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kpresenter/part/KPrSlidesManagerView.h <span style="color: grey">(6f345e049cdf746e00fdfd9e3e7644668ff9e96e)</span></li>
<li>kpresenter/part/KPrSlidesManagerView.cpp <span style="color: grey">(39e80b1b770584f97e6bfcbcebc06bd107bc1a68)</span></li>
<li>kpresenter/part/KPrSlidesSorterDocumentModel.h <span style="color: grey">(a5b65a4d87f8af6a51b4e1992c2ac2a3d23aed37)</span></li>
<li>kpresenter/part/KPrSlidesSorterDocumentModel.cpp <span style="color: grey">(4938e3696bed3fb90c017aba5997c40268ce3e99)</span></li>
<li>kpresenter/part/KPrSlidesSorterItemDelegate.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kpresenter/part/KPrSlidesSorterItemDelegate.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kpresenter/part/KPrViewModeSlidesSorter.h <span style="color: grey">(240bd9e0c6b4158ff0726f2e72e4c79982a9ea18)</span></li>
<li>kpresenter/part/KPrViewModeSlidesSorter.cpp <span style="color: grey">(61866f8a1344e1999224444d71a46a1a21a1864e)</span></li>
<li>kpresenter/part/commands/KPrAddCustomSlideShowCommand.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kpresenter/part/commands/KPrAddCustomSlideShowCommand.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kpresenter/part/commands/KPrDelCustomSlideShowCommand.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kpresenter/part/commands/KPrDelCustomSlideShowCommand.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kpresenter/part/commands/KPrEditCustomSlideShowsCommand.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kpresenter/part/commands/KPrEditCustomSlideShowsCommand.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kpresenter/part/commands/KPrRenameCustomSlideShowCommand.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kpresenter/part/commands/KPrRenameCustomSlideShowCommand.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kpresenter/part/tests/CMakeLists.txt <span style="color: grey">(f9b56a6ed55ebe610ae30cd21437975c00c317d1)</span></li>
<li>kpresenter/part/tests/PAMock.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kpresenter/part/tests/TestAddCustomSlideShowCommand.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kpresenter/part/tests/TestAddCustomSlideShowCommand.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kpresenter/part/tests/TestDelCustomSlideShowCommand.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kpresenter/part/tests/TestDelCustomSlideShowCommand.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kpresenter/part/tests/TestEditCustomSlideShowsCommand.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kpresenter/part/tests/TestEditCustomSlideShowsCommand.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kpresenter/part/tests/TestRenameCustomSlideShowCommand.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kpresenter/part/tests/TestRenameCustomSlideShowCommand.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101820/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>