<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101820/">http://git.reviewboard.kde.org/r/101820/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 1st, 2011, 10:25 p.m., <b>Jarosław Staniek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/101820/diff/1/?file=25792#file25792line76" style="color: black; font-weight: bold; text-decoration: underline;">kpresenter/part/KPrSlidesSorterDocumentModel.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">public:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">76</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="kt">void</span> <span class="n">doDrop</span><span class="p">(</span><span class="n">QList</span><span class="o"><</span><span class="n">KoPAPageBase</span> <span class="o">*></span> <span class="n">slides</span><span class="p">,</span> <span class="n">KoPAPageBase</span> <span class="o">*</span><span class="n">pageAfter</span><span class="p">,</span> <span class="n">Qt</span><span class="o">::</span><span class="n">DropAction</span> <span class="n">action</span><span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">76</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="kt">void</span> <span class="n">doDrop</span><span class="p">(</span><span class="n">QList</span><span class="o"><</span><span class="n">KoPAPageBase</span> <span class="o">*></span> <span class="o"><span class="hl">&</span></span><span class="n">slides</span><span class="p">,</span> <span class="n">KoPAPageBase</span> <span class="o">*</span><span class="n">pageAfter</span><span class="p">,</span> <span class="n">Qt</span><span class="o">::</span><span class="n">DropAction</span> <span class="n">action</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The convetion for in-out args is to use pointers instead of references (and the other arg - pageAfter - uses that).</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Can you please point out the place where this convention is said. However as the value is not used afterwards I guess passing as a reference is just so it can be modified. If that is the case it should be change to QList<KoPAPageBase *> slides or it should pass a const reference and make a copy of that in the function.</pre>
<br />
<p>- Thorsten</p>
<br />
<p>On July 1st, 2011, 10:11 p.m., Paul Mendez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Paul Mendez.</div>
<p style="color: grey;"><i>Updated July 1, 2011, 10:11 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">(preliminary) new GUI for manage custom slide shows.
Note: As some GUI integration is still missing, it's only a review request, it isn't for merge with master branch.
(part of GSoC project)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">build and run</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kpresenter/part/CMakeLists.txt <span style="color: grey">(613ff8d3de84a19776df1651c0bd3604fc395099)</span></li>
<li>kpresenter/part/KPrCustomSlideShows.h <span style="color: grey">(7d8a91b67e14e32312fd2706dcede6efac6e1aa7)</span></li>
<li>kpresenter/part/KPrCustomSlideShows.cpp <span style="color: grey">(4088a7446d2992d3d56059bec4ad646b4bbfc77f)</span></li>
<li>kpresenter/part/KPrCustomSlideShowsModel.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kpresenter/part/KPrCustomSlideShowsModel.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kpresenter/part/KPrSlidesManagerView.h <span style="color: grey">(6f345e049cdf746e00fdfd9e3e7644668ff9e96e)</span></li>
<li>kpresenter/part/KPrSlidesManagerView.cpp <span style="color: grey">(39e80b1b770584f97e6bfcbcebc06bd107bc1a68)</span></li>
<li>kpresenter/part/KPrSlidesSorterDocumentModel.h <span style="color: grey">(a5b65a4d87f8af6a51b4e1992c2ac2a3d23aed37)</span></li>
<li>kpresenter/part/KPrSlidesSorterDocumentModel.cpp <span style="color: grey">(4938e3696bed3fb90c017aba5997c40268ce3e99)</span></li>
<li>kpresenter/part/KPrSlidesSorterItemDelegate.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kpresenter/part/KPrSlidesSorterItemDelegate.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kpresenter/part/KPrViewModeSlidesSorter.h <span style="color: grey">(240bd9e0c6b4158ff0726f2e72e4c79982a9ea18)</span></li>
<li>kpresenter/part/KPrViewModeSlidesSorter.cpp <span style="color: grey">(61866f8a1344e1999224444d71a46a1a21a1864e)</span></li>
<li>kpresenter/part/commands/KPrAddCustomSlideShowCommand.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kpresenter/part/commands/KPrAddCustomSlideShowCommand.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kpresenter/part/commands/KPrDelCustomSlideShowCommand.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kpresenter/part/commands/KPrDelCustomSlideShowCommand.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kpresenter/part/commands/KPrEditCustomSlideShowsCommand.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kpresenter/part/commands/KPrEditCustomSlideShowsCommand.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kpresenter/part/commands/KPrRenameCustomSlideShowCommand.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kpresenter/part/commands/KPrRenameCustomSlideShowCommand.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kpresenter/part/tests/CMakeLists.txt <span style="color: grey">(f9b56a6ed55ebe610ae30cd21437975c00c317d1)</span></li>
<li>kpresenter/part/tests/PAMock.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kpresenter/part/tests/TestEditCustomSlideShowsCommand.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kpresenter/part/tests/TestEditCustomSlideShowsCommand.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101820/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>