<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101818/">http://git.reviewboard.kde.org/r/101818/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 225a51c6eee4bb5da5a2210cc06f7a9ccfaf1998 by Jaime Torres to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On July 1st, 2011, 6:04 p.m., Jaime Torres Amate wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Jaime Torres Amate.</div>
<p style="color: grey;"><i>Updated July 1, 2011, 6:04 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I should not mix so many patches, but I still have some trouble with git stash and similar.
I hope this time the parenthesis for the ? operator are safe. (last group of them).
Last group of exceptions to const exceptions&
Two = operators that should return class&
And one variable and a parameter missing in tables. (last group of same expresion in both sides of ==).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I can not test them. I'm using gcc 4.6.1 and can not compile.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>filters/tables/xlsx/NumberFormatParser.cpp <span style="color: grey">(c686cdc)</span></li>
<li>filters/words/msword-odf/mswordodfimport.cpp <span style="color: grey">(baf667c)</span></li>
<li>filters/words/mswrite/mswriteimport.cc <span style="color: grey">(dfc39b5)</span></li>
<li>kexi/kexidb/drivers/oracle/oracleconnection.cpp <span style="color: grey">(c2e96f9)</span></li>
<li>kexi/kexidb/drivers/oracle/oracleconnection_p.cpp <span style="color: grey">(be7c125)</span></li>
<li>kexi/kexidb/drivers/oracle/oraclecursor.cpp <span style="color: grey">(ff4e66e)</span></li>
<li>krita/plugins/extensions/tonemapping/operators/trilateral/pfstmo_trilateral.cpp <span style="color: grey">(f8f55b3)</span></li>
<li>krita/plugins/tools/tool_curves/kis_curve_framework.h <span style="color: grey">(6f9a79c)</span></li>
<li>plugins/chartshape/kdchart/src/KDChartCartesianAxis.cpp <span style="color: grey">(cbf0d66)</span></li>
<li>plugins/reporting/barcode/codeean.cpp <span style="color: grey">(0d70f39)</span></li>
<li>plugins/reporting/barcode/codeeanpaint.cpp <span style="color: grey">(0542417)</span></li>
<li>tables/PrintSettings.cpp <span style="color: grey">(ff785da)</span></li>
<li>tables/commands/AutoFillCommand.cpp <span style="color: grey">(ef52d28)</span></li>
<li>tables/database/Filter.cpp <span style="color: grey">(3b01637)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101818/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>