<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101803/">http://git.reviewboard.kde.org/r/101803/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On June 30th, 2011, 6:38 a.m., <b>Thorsten Zachmann</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/101803/diff/1/?file=25714#file25714line81" style="color: black; font-weight: bold; text-decoration: underline;">krita/plugins/filters/blur/kis_blur_filter.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void KisBlurFilter::process(KisPaintDeviceSP device,</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">81</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="kt">int</span> <span class="n">strength</span> <span class="o">=</span> <span class="mi">100</span> <span class="o">-</span> <span class="p">(</span><span class="n">config</span><span class="o">-></span><span class="n">getProperty</span><span class="p">(</span><span class="s">"strength"</span><span class="p">,</span> <span class="n">value</span><span class="p">))</span> <span class="o">?</span> <span class="n">value</span><span class="p">.</span><span class="n">toUInt</span><span class="p">()</span> <span class="o">:</span> <span class="mi">0</span><span class="p">;</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">81</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="kt">int</span> <span class="n">strength</span> <span class="o">=</span> <span class="p"><span class="hl">(</span></span><span class="mi">100</span> <span class="o">-</span> <span class="p">(</span><span class="n">config</span><span class="o">-></span><span class="n">getProperty</span><span class="p">(</span><span class="s">"strength"</span><span class="p">,</span> <span class="n">value</span><span class="p">))<span class="hl">)</span></span> <span class="o">?</span> <span class="n">value</span><span class="p">.</span><span class="n">toUInt</span><span class="p">()</span> <span class="o">:</span> <span class="mi">0</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Does that give the same result?
If not is this chnage correct. Krita guys any idea?</pre>
</blockquote>
<p>On June 30th, 2011, 7 a.m., <b>Elvis Stansvik</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It should. Subtraction is evaluated before a ternary conditional, so the adding of parenthesis is just a clarification. But I wonder, couldn't this one be rewritten as a qMax somehow to make it even more clearer?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">But then again, maybe not worth poking at something that works, as there seems to be many such constructs around there.</pre>
<br />
<p>- Elvis</p>
<br />
<p>On June 29th, 2011, 8:32 p.m., Jaime Torres Amate wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Jaime Torres Amate.</div>
<p style="color: grey;"><i>Updated June 29, 2011, 8:32 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">the changes are:
(easy)
1. in formulas is to return the FormulaToken& as recommended by C++. (even if there is no a=b=c chain).
2. in ustring is to compare with NaN to know when a value is NaN instead of compare to itself.
3. in kis_blur_effect is to clarify the priority of - and ?.
(hard)
4. in kotextloader to remove 3 duplicated code. (at least the first and sencond, the third one is sligly different from the previous incarnation of the code).
They are previously in the same else if chain.
5. in kotablerowstyle, remove 1 duplicated code (or is it missing some option?)
6. in kodfgraphicstyles, remove 1 dead entry (or it should compare to some other word?)
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>filters/tables/excel/sidewinder/formulas.h <span style="color: grey">(98559c8)</span></li>
<li>filters/tables/excel/sidewinder/formulas.cpp <span style="color: grey">(5903dd6)</span></li>
<li>filters/words/msword-odf/wv2/src/ustring.cpp <span style="color: grey">(d9f1707)</span></li>
<li>krita/plugins/filters/blur/kis_blur_filter.cpp <span style="color: grey">(3a45bc2)</span></li>
<li>libs/kotext/opendocument/KoTextLoader.cpp <span style="color: grey">(ce7c7a3)</span></li>
<li>libs/kotext/styles/KoTableRowStyle.cpp <span style="color: grey">(6fc53c6)</span></li>
<li>libs/odf/KoOdfGraphicStyles.cpp <span style="color: grey">(f5860b9)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101803/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>