<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101793/">http://git.reviewboard.kde.org/r/101793/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">good work, but a couple of remarks:
* there really should be a unittest for the new tagging class
* interaction wise, there is still some room for improvement.
** The icons under the tagging lineedit seem to belong to the tagging process, but they don't. Maybe the tooltips for the icons can be improved.
** It's not clear how I can actually search for resources with a tag. I added a couple of tags to one preset, then entered a tag in the "search Preset" line edit -- but that only searched by filename. I think it should also search by by tag. This seems to work fine for for instance gradients.
** The tag lineedit gets enabled in the popup when a tag is selected for the first time, but not disabled when tags are no longer selected. This is kind of confusing.
** there should be a way to select more than one resource at a time so we can apply a tag to all of those.</pre>
<br />
<p>- Boudewijn</p>
<br />
<p>On June 28th, 2011, 1:29 a.m., Srikanth Tiyyagura wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Srikanth Tiyyagura.</div>
<p style="color: grey;"><i>Updated June 28, 2011, 1:29 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tagging for the resources is completed and needs a review for merging into master. So, I created a diff file between master and krita_resource-management-tagging-tiyyagura branches and posted that here.
I think all the functionalities required are implemented; If I miss anything, please suggest me the ideas and I will implement them into tagging.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>krita/plugins/paintops/libpaintop/kis_brush_chooser.cpp <span style="color: grey">(33e5310)</span></li>
<li>krita/ui/kis_palette_manager.cpp <span style="color: grey">(e16d748)</span></li>
<li>krita/ui/widgets/kis_gradient_chooser.cc <span style="color: grey">(6852c0b)</span></li>
<li>krita/ui/widgets/kis_paintop_presets_chooser_popup.h <span style="color: grey">(557d1d5)</span></li>
<li>krita/ui/widgets/kis_paintop_presets_chooser_popup.cpp <span style="color: grey">(54f7bc0)</span></li>
<li>krita/ui/widgets/kis_pattern_chooser.cc <span style="color: grey">(4a08ea9)</span></li>
<li>krita/ui/widgets/kis_preset_chooser.h <span style="color: grey">(a27dfaa)</span></li>
<li>krita/ui/widgets/kis_preset_chooser.cpp <span style="color: grey">(30b624c)</span></li>
<li>libs/widgets/CMakeLists.txt <span style="color: grey">(6ff1df9)</span></li>
<li>libs/widgets/KoResourceItemChooser.h <span style="color: grey">(245e727)</span></li>
<li>libs/widgets/KoResourceItemChooser.cpp <span style="color: grey">(5ef3d63)</span></li>
<li>libs/widgets/KoResourceServer.h <span style="color: grey">(fbae66e)</span></li>
<li>libs/widgets/KoResourceServerAdapter.h <span style="color: grey">(5422fe3)</span></li>
<li>libs/widgets/KoResourceTagging.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/widgets/KoResourceTagging.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101793/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>