<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101414/">http://git.reviewboard.kde.org/r/101414/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hi, please consider adding this patch to avoid infinite recursion. Needed at least on g++ is (SUSE Linux) 4.5.0 20100604 [gcc-4_5-branch revision 160292].
diff --git a/libs/kundo2/kundo2stack.cpp b/libs/kundo2/kundo2stack.cpp
index 6af1d05..658df1f 100644
--- a/libs/kundo2/kundo2stack.cpp
+++ b/libs/kundo2/kundo2stack.cpp
@@ -1062,7 +1062,7 @@ bool KUndo2QStack::isActive() const
QAction* KUndo2QStack::createRedoAction(KActionCollection* actionCollection, const QString& actionName)
{
- QAction* action = createRedoAction(actionCollection);
+ QAction* action = createRedoAction(static_cast<QObject*>(actionCollection));
if(actionName.isEmpty()) {
action->setObjectName(KStandardAction::name(KStandardAction::Redo));
@@ -1081,7 +1081,7 @@ QAction* KUndo2QStack::createRedoAction(KActionCollection* actionCollection, con
QAction* KUndo2QStack::createUndoAction(KActionCollection* actionCollection, const QString& actionName)
{
- QAction* action = createUndoAction(actionCollection);
+ QAction* action = createUndoAction(static_cast<QObject*>(actionCollection));
if(actionName.isEmpty()) {
action->setObjectName(KStandardAction::name(KStandardAction::Undo));
</pre>
<br />
<p>- Jarosław</p>
<br />
<p>On May 22nd, 2011, 12:17 p.m., Alexander Potashev wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Alexander Potashev.</div>
<p style="color: grey;"><i>Updated May 22, 2011, 12:17 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">kundo2 is a fork of Qt's Undo Framework (QUndoStack, QUndoView, ...).
It contains two bugfixes the are going to be available only in Qt 4.8:
https://qt.gitorious.org/qt/qt/merge_requests/1212
https://qt.gitorious.org/qt/qt/merge_requests/2610
To start using kundo2, one should port Calligra to it. This can be done
by adding target_link_libraries(... kundo2) into CMakeLists.txt files
for all modules from Calligra that use Qt Undo Framework, and by
switching from QUndo**** classes to KUndo2**** classes.
(switching to KUndo2 classes can easily be done by using a script)
Script for forward and backward porting: https://github.com/aspotashev/libkundo2/blob/master/port-kundo2.sh
After Calligra starts requiring Qt 4.8+, this library can be removed,
because it has no advantages over Qt's Undo Framework 4.8.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It compiles.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/CMakeLists.txt <span style="color: grey">(6179f0a)</span></li>
<li>libs/kundo2/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/kundo2/kundo2_export.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/kundo2/kundo2command.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/kundo2/kundo2group.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/kundo2/kundo2group.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/kundo2/kundo2model.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/kundo2/kundo2model.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/kundo2/kundo2qstack.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/kundo2/kundo2stack.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/kundo2/kundo2stack.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/kundo2/kundo2stack_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/kundo2/kundo2view.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/kundo2/kundo2view.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101414/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>