<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101730/">http://git.reviewboard.kde.org/r/101730/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On June 23rd, 2011, 9:47 a.m., <b>Matus Uzak</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Please revert the changes committed to both ParsedPresentation.cpp and ODrawToOdf.cpp, check the definition of IOException in libmso.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Done. Sorry I forgot to write the tag in the commit. I'll use kdevelop instead of kate. Detecting this things is a lot easier.</pre>
<br />
<p>- Jaime Torres</p>
<br />
<p>On June 22nd, 2011, 9:46 p.m., Jaime Torres Amate wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Jaime Torres Amate.</div>
<p style="color: grey;"><i>Updated June 22, 2011, 9:46 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The two comparations are obvious.
The memory leak, I think Qt will not delete them.
The exceptions, following C++ style guides, the variable is preferred by reference.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>filters/karbon/applixgraphics/applixgraphicimport.cc <span style="color: grey">(e8407fd)</span></li>
<li>filters/kpresenter/powerpoint/ParsedPresentation.cpp <span style="color: grey">(0f375b9)</span></li>
<li>filters/libmso/ODrawToOdf.cpp <span style="color: grey">(6551a62)</span></li>
<li>filters/tables/excel/sidewinder/format.h <span style="color: grey">(e744a1c)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101730/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>