<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101415/">http://git.reviewboard.kde.org/r/101415/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Usually, we don't link separately to a library that is already linked to a library we already link to, but export the linkage like this:
target_link_libraries(komain LINK_INTERFACE_LIBRARIES kotext kowidgets ${KDE4_KPARTS_LIBS})
where LINK_INTERFACE_LIBRARIES makes sure that everything linked to komain is linked to kotext and kowidgets and doesn't have to explicitly link. I think it would be good to export kundo2 with the first library that links to it in the hierarchy.
</pre>
<br />
<p>- Boudewijn</p>
<br />
<p>On May 22nd, 2011, 12:20 p.m., Alexander Potashev wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Alexander Potashev.</div>
<p style="color: grey;"><i>Updated May 22, 2011, 12:20 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add target_link_libraries(... kundo2) to CMakeLists.txt files of all
modules of Calligra that use Qt's Undo Framework.
Requires https://git.reviewboard.kde.org/r/101414/</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This cannot possibly break anything. Of course, if you have already applied https://git.reviewboard.kde.org/r/101414/</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>braindump/plugins/stateshape/CMakeLists.txt <span style="color: grey">(72c38eb)</span></li>
<li>braindump/plugins/webshape/CMakeLists.txt <span style="color: grey">(5234f63)</span></li>
<li>karbon/common/CMakeLists.txt <span style="color: grey">(e940d9f)</span></li>
<li>karbon/plugins/flattenpath/CMakeLists.txt <span style="color: grey">(f83620b)</span></li>
<li>karbon/plugins/refinepath/CMakeLists.txt <span style="color: grey">(caf6aa7)</span></li>
<li>karbon/plugins/roundcorners/CMakeLists.txt <span style="color: grey">(82b7159)</span></li>
<li>karbon/plugins/tools/CMakeLists.txt <span style="color: grey">(7e4aeb6)</span></li>
<li>karbon/plugins/whirlpinch/CMakeLists.txt <span style="color: grey">(2e920e2)</span></li>
<li>karbon/ui/CMakeLists.txt <span style="color: grey">(0773216)</span></li>
<li>kexi/formeditor/CMakeLists.txt <span style="color: grey">(0f48560)</span></li>
<li>kexi/plugins/forms/CMakeLists.txt <span style="color: grey">(8d9c2d8)</span></li>
<li>kformula/CMakeLists.txt <span style="color: grey">(8f46594)</span></li>
<li>kformula/flake/CMakeLists.txt <span style="color: grey">(5b3b7bc)</span></li>
<li>kplato/CMakeLists.txt <span style="color: grey">(605535f)</span></li>
<li>kplato/libs/kernel/CMakeLists.txt <span style="color: grey">(6dc30b1)</span></li>
<li>kplato/libs/models/CMakeLists.txt <span style="color: grey">(ad9f50c)</span></li>
<li>kplato/libs/ui/CMakeLists.txt <span style="color: grey">(6d64c1c)</span></li>
<li>kplato/workpackage/CMakeLists.txt <span style="color: grey">(b9ef576)</span></li>
<li>kpresenter/part/CMakeLists.txt <span style="color: grey">(a2b01ee)</span></li>
<li>kpresenter/plugins/eventactions/CMakeLists.txt <span style="color: grey">(e4810cd)</span></li>
<li>krita/image/CMakeLists.txt <span style="color: grey">(47d13c3)</span></li>
<li>krita/plugins/extensions/dockers/historydocker/CMakeLists.txt <span style="color: grey">(513dae3)</span></li>
<li>krita/plugins/tools/tool_transform2/CMakeLists.txt <span style="color: grey">(fe93230)</span></li>
<li>krita/ui/CMakeLists.txt <span style="color: grey">(517adb6)</span></li>
<li>libs/flake/CMakeLists.txt <span style="color: grey">(c2164b7)</span></li>
<li>libs/kopageapp/CMakeLists.txt <span style="color: grey">(4cdf024)</span></li>
<li>libs/kopageapp/tools/backgroundTool/CMakeLists.txt <span style="color: grey">(ba1ddc3)</span></li>
<li>libs/kotext/CMakeLists.txt <span style="color: grey">(bacba79)</span></li>
<li>libs/main/CMakeLists.txt <span style="color: grey">(55a71a3)</span></li>
<li>libs/textlayout/CMakeLists.txt <span style="color: grey">(4fb35c5)</span></li>
<li>plugins/artistictextshape/CMakeLists.txt <span style="color: grey">(638edac)</span></li>
<li>plugins/chartshape/CMakeLists.txt <span style="color: grey">(2daccfc)</span></li>
<li>plugins/defaultTools/CMakeLists.txt <span style="color: grey">(6c7f138)</span></li>
<li>plugins/musicshape/CMakeLists.txt <span style="color: grey">(3fa3d87)</span></li>
<li>plugins/pathshapes/CMakeLists.txt <span style="color: grey">(e773367)</span></li>
<li>plugins/pictureshape/CMakeLists.txt <span style="color: grey">(373c589)</span></li>
<li>plugins/textshape/CMakeLists.txt <span style="color: grey">(a583a2a)</span></li>
<li>plugins/treeshape/CMakeLists.txt <span style="color: grey">(da0917d)</span></li>
<li>plugins/vectorshape/CMakeLists.txt <span style="color: grey">(b629e7f)</span></li>
<li>plugins/videoshape/CMakeLists.txt <span style="color: grey">(697ed5b)</span></li>
<li>tables/CMakeLists.txt <span style="color: grey">(a6445ba)</span></li>
<li>tools/koabstraction/CMakeLists.txt <span style="color: grey">(f9b3882)</span></li>
<li>words/part/CMakeLists.txt <span style="color: grey">(dd3b917)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101415/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>