<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101467/">http://git.reviewboard.kde.org/r/101467/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Srikanth Tiyyagura.</div>
<p style="color: grey;"><i>Updated May 29, 2011, 3:48 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I changed the diff file by merging master into the branch krita_resource-management-tagging-tiyyagura and then creating the diff file between the branches.
I updated the changes suggested by Boudewijn Rempt and also removed some spaces in the code.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Review request for the branch krita_resource-management-tagging-tiyyagura under calligra repository
I want to merge this branch into master. Before that, I want to review it first. I already tried to post this review using post-review but it is giving error like this
File "/usr/lib/python2.7/httplib.py", line 809, in _send_output
msg += message_body
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc5 in position 44353: ordinal not in range(128)
So, I created a diff file between master and krita_resource-management-tagging-tiyyagura branch using the following command and posting that diff file
git diff master krita_resource-management-tagging-tiyyagura
I didn't know whether this way is correct or wrong ? If it is wrong, please intimate me with correct procedure.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>krita/data/CMakeLists.txt <span style="color: grey">(4b07140)</span></li>
<li>krita/data/kritabrushes.knsrc <span style="color: grey">(PRE-CREATION)</span></li>
<li>krita/data/kritagradients.knsrc <span style="color: grey">(PRE-CREATION)</span></li>
<li>krita/data/kritapatterns.knsrc <span style="color: grey">(PRE-CREATION)</span></li>
<li>krita/data/kritapresets.knsrc <span style="color: grey">(PRE-CREATION)</span></li>
<li>krita/plugins/paintops/libpaintop/kis_brush_chooser.cpp <span style="color: grey">(55efdec)</span></li>
<li>krita/ui/kis_paintop_box.cc <span style="color: grey">(aeebcae)</span></li>
<li>krita/ui/widgets/kis_gradient_chooser.cc <span style="color: grey">(86ecfdf)</span></li>
<li>krita/ui/widgets/kis_pattern_chooser.cc <span style="color: grey">(5b6661b)</span></li>
<li>krita/ui/widgets/kis_preset_chooser.cpp <span style="color: grey">(c0da30d)</span></li>
<li>libs/widgets/KoResourceItemChooser.h <span style="color: grey">(eee16cb)</span></li>
<li>libs/widgets/KoResourceItemChooser.cpp <span style="color: grey">(03cd55c)</span></li>
<li>libs/widgets/KoResourceModel.cpp <span style="color: grey">(b007740)</span></li>
<li>libs/widgets/KoResourceServer.h <span style="color: grey">(cd9e42b)</span></li>
<li>libs/widgets/KoResourceServerAdapter.h <span style="color: grey">(dacc12f)</span></li>
<li>libs/widgets/KoResourceServerProvider.cpp <span style="color: grey">(27f2203)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101467/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>