<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101384/">http://git.reviewboard.kde.org/r/101384/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">A few more style issues, but other than that it's time to get this comitted.
Do you have write access to git?</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/101384/diff/4/?file=17933#file17933line486" style="color: black; font-weight: bold; text-decoration: underline;">karbon/plugins/tools/filterEffectTool/KarbonFilterEffectsTool.cpp</a>
<span style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">QMap<QString, QWidget *> KarbonFilterEffectsTool::createOptionWidgets()</pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">QList<QWidget *> KarbonFilterEffectsTool::createOptionWidgets()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">486</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="ew"> </span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">no spaces with nothing after please</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/101384/diff/4/?file=17957#file17957line90" style="color: black; font-weight: bold; text-decoration: underline;">libs/main/KoToolDocker.cpp</a>
<span style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">public:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">90</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n"><span class="hl">iter</span></span><span class="hl"> </span><span class="o"><span class="hl">=</span></span> <span class="n">currentWidget<span class="hl">Map</span></span><span class="p"><span class="hl">.</span></span><span class="n"><span class="hl">constBegin</span></span><span class="p"><span class="hl">();</span></span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">88</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n"><span class="hl">foreach</span></span><span class="p"><span class="hl">(</span></span><span class="n"><span class="hl">QWidget</span></span><span class="o"><span class="hl">*</span></span><span class="hl"> </span><span class="n"><span class="hl">widget</span></span><span class="p"><span class="hl">,</span></span> <span class="n">currentWidget<span class="hl">List</span></span><span class="p"><span class="hl">)</span></span><span class="hl"> </span><span class="p"><span class="hl">{</span></span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">foreach (const QWidget *widget, currentWidgetList) {</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/101384/diff/4/?file=17957#file17957line132" style="color: black; font-weight: bold; text-decoration: underline;">libs/main/KoToolDocker.cpp</a>
<span style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">public:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">130</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">for</span> <span class="p">(</span><span class="kt">int</span> <span class="n">cnt</span> <span class="o">=</span> <span class="mi">0</span><span class="p">;</span> <span class="n">iter</span> <span class="o">!=</span> <span class="n">currentWidgetMap</span><span class="p">.</span><span class="n">constEnd</span><span class="p">();</span> <span class="o">++</span><span class="n">cnt</span><span class="p">)</span> <span class="p">{</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">126</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">foreach</span><span class="p">(</span><span class="n">QWidget</span><span class="o">*</span> <span class="n">widget</span><span class="p">,</span> <span class="n">currentWidgetList</span><span class="p">)</span> <span class="p">{</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">foreach (QWidget *widget, currentWidgetList) {</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/101384/diff/4/?file=17960#file17960line600" style="color: black; font-weight: bold; text-decoration: underline;">plugins/artistictextshape/ArtisticTextTool.cpp</a>
<span style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void ArtisticTextTool::setTextCursorInternal( int textCursor )</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">600</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span> <span class="n">m_textCursor</span> <span class="o"><</span> <span class="mi">0</span> <span class="o">||</span> <span class="o">!</span> <span class="n">m_currentShape</span> <span class="p">)</span><span class="ew"> </span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">594</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span> <span class="n">m_textCursor</span> <span class="o"><</span> <span class="mi">0</span> <span class="o">||</span> <span class="o">!</span> <span class="n">m_currentShape</span> <span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">if (m_textCursor < 0 || ! m_currentShape)</pre>
</div>
<br />
<p>- Casper</p>
<br />
<p>On May 23rd, 2011, 7:53 p.m., Samuel Buttigieg wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Samuel Buttigieg.</div>
<p style="color: grey;"><i>Updated May 23, 2011, 7:53 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">As requested by boemann, this patch replaces all instances of QMaps used to represent Widgets with QLists. Using QLists allows the widgets to be displayed in the order you like them to.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">checking if user interface still works and making sure no crashes occur</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>braindump/plugins/stateshape/StateTool.h <span style="color: grey">(7ab14cb)</span></li>
<li>braindump/plugins/stateshape/StateTool.cpp <span style="color: grey">(79d7927)</span></li>
<li>braindump/plugins/webshape/WebTool.h <span style="color: grey">(2998d09)</span></li>
<li>braindump/plugins/webshape/WebTool.cpp <span style="color: grey">(44901ae)</span></li>
<li>karbon/plugins/tools/KarbonGradientTool.h <span style="color: grey">(bb87f8f)</span></li>
<li>karbon/plugins/tools/KarbonGradientTool.cpp <span style="color: grey">(02718b0)</span></li>
<li>karbon/plugins/tools/KarbonPatternTool.h <span style="color: grey">(f9792a0)</span></li>
<li>karbon/plugins/tools/KarbonPatternTool.cpp <span style="color: grey">(51e57dd)</span></li>
<li>karbon/plugins/tools/filterEffectTool/KarbonFilterEffectsTool.h <span style="color: grey">(a25b54e)</span></li>
<li>karbon/plugins/tools/filterEffectTool/KarbonFilterEffectsTool.cpp <span style="color: grey">(1d02cca)</span></li>
<li>karbon/ui/KarbonView.cpp <span style="color: grey">(c5b682b)</span></li>
<li>kpresenter/part/tools/animationtool/KPrAnimationTool.h <span style="color: grey">(117bc61)</span></li>
<li>kpresenter/part/tools/animationtool/KPrAnimationTool.cpp <span style="color: grey">(0a1b997)</span></li>
<li>krita/plugins/tools/defaulttools/kis_tool_path.h <span style="color: grey">(f57a1fa)</span></li>
<li>krita/plugins/tools/defaulttools/kis_tool_path.cc <span style="color: grey">(80a31cf)</span></li>
<li>krita/plugins/tools/selectiontools/kis_tool_select_path.h <span style="color: grey">(7bb8a14)</span></li>
<li>krita/plugins/tools/selectiontools/kis_tool_select_path.cc <span style="color: grey">(cd4c40d)</span></li>
<li>krita/ui/kis_view2.cpp <span style="color: grey">(bd0d82f)</span></li>
<li>libs/flake/KoCanvasControllerWidget.h <span style="color: grey">(384c928)</span></li>
<li>libs/flake/KoCanvasControllerWidget.cpp <span style="color: grey">(7da9e38)</span></li>
<li>libs/flake/KoToolBase.h <span style="color: grey">(860a77c)</span></li>
<li>libs/flake/KoToolBase.cpp <span style="color: grey">(456587d)</span></li>
<li>libs/flake/KoToolBase_p.h <span style="color: grey">(49bc2f9)</span></li>
<li>libs/flake/KoToolManager.cpp <span style="color: grey">(bf68ad9)</span></li>
<li>libs/flake/tools/KoCreatePathTool.h <span style="color: grey">(325af3b)</span></li>
<li>libs/flake/tools/KoCreatePathTool.cpp <span style="color: grey">(ca8f373)</span></li>
<li>libs/flake/tools/KoPathTool.h <span style="color: grey">(bcd6d95)</span></li>
<li>libs/flake/tools/KoPathTool.cpp <span style="color: grey">(157d387)</span></li>
<li>libs/kopageapp/KoPAView.cpp <span style="color: grey">(141e46c)</span></li>
<li>libs/kopageapp/tools/backgroundTool/KoPABackgroundTool.h <span style="color: grey">(17a83b2)</span></li>
<li>libs/kopageapp/tools/backgroundTool/KoPABackgroundTool.cpp <span style="color: grey">(0b16048)</span></li>
<li>libs/main/KoDockerManager.h <span style="color: grey">(3ec84b9)</span></li>
<li>libs/main/KoDockerManager.cpp <span style="color: grey">(93f1b3e)</span></li>
<li>libs/main/KoToolDocker.cpp <span style="color: grey">(c9aacce)</span></li>
<li>libs/main/KoToolDocker_p.h <span style="color: grey">(3f76df7)</span></li>
<li>plugins/artistictextshape/ArtisticTextTool.h <span style="color: grey">(e9b6347)</span></li>
<li>plugins/artistictextshape/ArtisticTextTool.cpp <span style="color: grey">(68debef)</span></li>
<li>plugins/defaultTools/connectionTool/ConnectionTool.h <span style="color: grey">(09ece57)</span></li>
<li>plugins/defaultTools/connectionTool/ConnectionTool.cpp <span style="color: grey">(e0d4594)</span></li>
<li>plugins/defaultTools/defaulttool/DefaultTool.h <span style="color: grey">(724798f)</span></li>
<li>plugins/defaultTools/defaulttool/DefaultTool.cpp <span style="color: grey">(c9fb9ab)</span></li>
<li>plugins/defaultTools/guidestool/GuidesTool.h <span style="color: grey">(2cc8d00)</span></li>
<li>plugins/defaultTools/guidestool/GuidesTool.cpp <span style="color: grey">(635518b)</span></li>
<li>plugins/textshape/ReferencesTool.h <span style="color: grey">(7fb9424)</span></li>
<li>plugins/textshape/ReferencesTool.cpp <span style="color: grey">(47d1fbd)</span></li>
<li>plugins/textshape/ReviewTool.h <span style="color: grey">(90e8bf0)</span></li>
<li>plugins/textshape/ReviewTool.cpp <span style="color: grey">(2920ea8)</span></li>
<li>plugins/textshape/TextTool.h <span style="color: grey">(5460ba8)</span></li>
<li>plugins/textshape/TextTool.cpp <span style="color: grey">(44035a6)</span></li>
<li>plugins/treeshape/TreeTool.h <span style="color: grey">(0c8733c)</span></li>
<li>plugins/treeshape/TreeTool.cpp <span style="color: grey">(5c26dc9)</span></li>
<li>tables/part/View.cpp <span style="color: grey">(82bbcbf)</span></li>
<li>tables/shape/TableTool.h <span style="color: grey">(45a9ab1)</span></li>
<li>tables/shape/TableTool.cpp <span style="color: grey">(1d54e92)</span></li>
<li>tables/ui/CellToolBase.h <span style="color: grey">(1e85233)</span></li>
<li>tables/ui/CellToolBase.cpp <span style="color: grey">(3557fb1)</span></li>
<li>words/part/KWGui.cpp <span style="color: grey">(7ec4d16)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101384/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>