<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101361/">http://git.reviewboard.kde.org/r/101361/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks very good
only one small thing that isn't even really needed</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/101361/diff/1/?file=16446#file16446line1245" style="color: black; font-weight: bold; text-decoration: underline;">libs/flake/KoShape.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">QString KoShape::saveStyle(KoGenStyle &style, KoShapeSavingContext &context) const</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">1245</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">style</span><span class="p">.</span><span class="n">addProperty</span><span class="p">(</span><span class="s">"style:wrap-dynamic-threshold"</span><span class="p">,</span> <span class="n">QString</span><span class="o">::</span><span class="n">number</span><span class="p">(</span><span class="n">textRunAroundThreshold</span><span class="p">())</span> <span class="o">+</span> <span class="s">"pt"</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">addPropertyPt does this for you</pre>
</div>
<br />
<p>- Casper</p>
<br />
<p>On May 14th, 2011, 2:49 p.m., Elvis Stansvik wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra and Casper Boemann.</div>
<div>By Elvis Stansvik.</div>
<p style="color: grey;"><i>Updated May 14, 2011, 2:49 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch adds support for style:wrap-dynamic-threshold [1], allowing the user to specify a threshold when dynamic wrap (a.k.a. EnoughRunAroundSide in KoShape API) is used. See the UI screenshot.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I tried adding some lorem ipsum text and a picture and activate the option. Works as expected. Did a save/load roundtrip and everything looks good.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/flake/KoShape.h <span style="color: grey">(99e185b)</span></li>
<li>libs/flake/KoShape.cpp <span style="color: grey">(dd8e91c)</span></li>
<li>libs/flake/KoShape_p.h <span style="color: grey">(428304d)</span></li>
<li>libs/textlayout/KoTextLayoutObstruction.h <span style="color: grey">(1b81492)</span></li>
<li>libs/textlayout/KoTextLayoutObstruction.cpp <span style="color: grey">(323ba360)</span></li>
<li>libs/textlayout/RunAroundHelper.cpp <span style="color: grey">(c318d4a)</span></li>
<li>words/part/dialogs/KWRunAroundProperties.h <span style="color: grey">(c23bf36)</span></li>
<li>words/part/dialogs/KWRunAroundProperties.cpp <span style="color: grey">(a6ea6d0)</span></li>
<li>words/part/dialogs/KWRunAroundProperties.ui <span style="color: grey">(d1ce389)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101361/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/101361/s/168/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2011/05/14/wrap-dynamic-threshold_400x100.png" style="border: 1px black solid;" alt="The UI of the feature." /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>