<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101281/">http://git.reviewboard.kde.org/r/101281/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On May 3rd, 2011, 10:17 p.m., <b>Pierre Ducroquet</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hi
Nice work, but I've got two questions :
- where is that defined in the OpenDocument specification ? I can not find it, and it was never reported by the automated unit tests...
- did you check whether the tests still compiled ?
Thanks</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">15.11.12 <text-properties> says that the element is usable within <style:style>
it does not say that it would require a certain family to be used.
Libreoffice seems to interpret this in the way that it's usable within cell styles as
they sometimes generate such documents.
With unittests:
Before the patch in TestOpenDocumentStyle 4 pass / 35 failed,
seems like a major reason is that cellstyle does not save many things in saveOdf
After the patch, the situation is the same. ie patch does not affect the situation in anyway.</pre>
<br />
<p>- Lassi Taneli</p>
<br />
<p>On May 4th, 2011, 8:45 a.m., Lassi Taneli Nieminen wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Lassi Taneli Nieminen.</div>
<p style="color: grey;"><i>Updated May 4, 2011, 8:45 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Odf allows text properties for cell-styles, previous kotext did not support this.
This patch adds support for that.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/kotext/styles/KoTableCellStyle.cpp <span style="color: grey">(ecae702)</span></li>
<li>libs/kotext/opendocument/KoTextSharedLoadingData.cpp <span style="color: grey">(532c752)</span></li>
<li>libs/kotext/styles/KoTableCellStyle.h <span style="color: grey">(89e3862)</span></li>
<li>libs/kotext/opendocument/KoTextSharedLoadingData.h <span style="color: grey">(0348049)</span></li>
<li>libs/kotext/styles/KoTableCellStyle_p.h <span style="color: grey">(15f4dfe)</span></li>
<li>libs/kotext/styles/tests/TestOpenDocumentStyle.h <span style="color: grey">(89d7c5c)</span></li>
<li>libs/kotext/styles/tests/TestOpenDocumentStyle.cpp <span style="color: grey">(cd44e03)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101281/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>