<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101271/">http://git.reviewboard.kde.org/r/101271/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra and David Faure.</div>
<div>By Inge Wallin.</div>
<p style="color: grey;"><i>Updated May 2, 2011, 1:40 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I was asked to ask David specifically to review.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Lately, a lot of document has been cropping up that have names like foo.doc but that really are docx files inside. Similar goes for xls/xlsx and ppt/pptx. This patch handles this case by not just using the name for determining the mimetype of the file while loading, but also looking at the contents (KMimeType:findByContents). It also introduces a replacement scheme to take care of reported mimetypes like application/zip instead of, say, docx.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch is tested on all combinations of doc/docx, ppt/pptx and xls/xlsx as well as on files containing the actual format that the names suggest.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>krita/plugins/filters/fastcolortransfer/fastcolortransfer.cpp <span style="color: grey">(fc94465)</span></li>
<li>krita/sdk/tests/filestest.h <span style="color: grey">(ef6f0f0)</span></li>
<li>krita/ui/kis_import_catcher.cc <span style="color: grey">(8c2c42a)</span></li>
<li>libs/main/KoDocument.cpp <span style="color: grey">(1ed2052)</span></li>
<li>libs/main/KoFilterManager.h <span style="color: grey">(fc7731c)</span></li>
<li>libs/main/KoFilterManager.cpp <span style="color: grey">(f840f69)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101271/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>