<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101271/">http://git.reviewboard.kde.org/r/101271/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On May 2nd, 2011, 1:40 p.m., <b>David Faure</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/101271/diff/1/?file=15794#file15794line1396" style="color: black; font-weight: bold; text-decoration: underline;">libs/main/KoDocument.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">bool KoDocument::openFile()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">1396</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span><span class="n">filename</span><span class="p">.</span><span class="n">endsWith</span><span class="p">(</span><span class="s">".doc"</span><span class="p">))</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Oh, I hadn't seen that the list includes the result of "findByFileContents" already.
But then why these additional ifs here? Isn't this covered by the list?
At least for xls and ppt, you should get reliable results from findByUrl, so testing this again with fiename.endsWith() seems redundant.
(Note that .doc is different; the extension doesn't imply msword, because linux has .doc plain text files).</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">All I can say that is that it doesn't suffice with just simple checks. There seem to be corner cases that elude the simple checks. See above for more details.</pre>
<br />
<p>- Inge</p>
<br />
<p>On May 2nd, 2011, 1:40 p.m., Inge Wallin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra and David Faure.</div>
<div>By Inge Wallin.</div>
<p style="color: grey;"><i>Updated May 2, 2011, 1:40 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Lately, a lot of document has been cropping up that have names like foo.doc but that really are docx files inside. Similar goes for xls/xlsx and ppt/pptx. This patch handles this case by not just using the name for determining the mimetype of the file while loading, but also looking at the contents (KMimeType:findByContents). It also introduces a replacement scheme to take care of reported mimetypes like application/zip instead of, say, docx.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch is tested on all combinations of doc/docx, ppt/pptx and xls/xlsx as well as on files containing the actual format that the names suggest.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>krita/plugins/filters/fastcolortransfer/fastcolortransfer.cpp <span style="color: grey">(fc94465)</span></li>
<li>krita/sdk/tests/filestest.h <span style="color: grey">(ef6f0f0)</span></li>
<li>krita/ui/kis_import_catcher.cc <span style="color: grey">(8c2c42a)</span></li>
<li>libs/main/KoDocument.cpp <span style="color: grey">(1ed2052)</span></li>
<li>libs/main/KoFilterManager.h <span style="color: grey">(fc7731c)</span></li>
<li>libs/main/KoFilterManager.cpp <span style="color: grey">(f840f69)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101271/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>