<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101129/">http://git.reviewboard.kde.org/r/101129/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 22nd, 2011, 5:21 a.m., <b>Thorsten Zachmann</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/101129/diff/3/?file=14790#file14790line459" style="color: black; font-weight: bold; text-decoration: underline;">kpresenter/part/KPrView.cpp</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void KPrView::zoomChanged(KoZoomMode::Mode mode, qreal zoom)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">459</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">centerPage</span><span class="p">();</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Center the page when zooming is wrong. The zoom should always keep the current center when zooming. (This seems to be broken at the moment)</pre>
</blockquote>
<p>On April 23rd, 2011, 8:05 p.m., <b>Paul Mendez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ok, so I can expect that it's going to be fixed in the future?.
As zooming is a function used in all calligra suite I didn't want to modify the zooming mechanism directly. Putting centerPage() in a specific Stage View, let me to correct the wrong behaviour, and avoid broke other parts of calligra.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I have fixed the broken zooming behaviour. Maybe you can use what I committed to make it work.</pre>
<br />
<p>- Thorsten</p>
<br />
<p>On April 20th, 2011, 2:52 a.m., Paul Mendez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Paul Mendez.</div>
<p style="color: grey;"><i>Updated April 20, 2011, 2:52 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add save of zoom factor and mode for normal view and slides sorter. Also eliminate page and width options of zooming in Slides Sorter (these options doesn't make much sense in that view).
Finally I eliminate the white space around the slide because it make the slide lost focus when zooming and when I restore the previous zoom value (the zoom function center the white space too), in addition the white space make too big the default size of shapes when inserted.
(I ask in calligra channel, and the white space was added to have an area for insert things, maybe it could be added in a better way).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">build and run</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kpresenter/part/KPrView.h <span style="color: grey">(80b67520be60500ecf11df0827f1d4ee8eeab4e7)</span></li>
<li>kpresenter/part/KPrView.cpp <span style="color: grey">(aef56d9fcb919a314f0095629bea1927916f8059)</span></li>
<li>kpresenter/part/KPrViewModeSlidesSorter.h <span style="color: grey">(ec5f6691072115eb7818f1eb224f6a03fe9bf13c)</span></li>
<li>kpresenter/part/KPrViewModeSlidesSorter.cpp <span style="color: grey">(b4fee3c755aebf65e9bff0cef5516776533ec4a6)</span></li>
<li>libs/kopageapp/KoPAView.h <span style="color: grey">(5585364c4bf0503e312a302b91f762653aaf98bb)</span></li>
<li>libs/kopageapp/KoPAView.cpp <span style="color: grey">(c53edecb309098949f66e9d50238bc60f26f9bee)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101129/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>