<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101129/">http://git.reviewboard.kde.org/r/101129/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 17th, 2011, 11:19 a.m., <b>Thorsten Zachmann</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Would it be enough to save the zoom in the destructor of the KPrView and KPrViewModeSlidesSorter? Then it is only written once and not with every change which will also save resources. Also it will make the code simpler.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It could work if I store only one zoom value. I have been trying to store the zoom value for normal view and other for slides sorter view. As both views are destroyed at the same time, It would store the zoom value used in the last view visible, and then restore it as the default value for all views.
I am going to try, moving the store code to the deactivate function of the slides sorter view, but I am not sure if that work when you close the program while you are still in the slides sorter view. I will write the result later.</pre>
<br />
<p>- Paul</p>
<br />
<p>On April 16th, 2011, 8:45 p.m., Paul Mendez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Paul Mendez.</div>
<p style="color: grey;"><i>Updated April 16, 2011, 8:45 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add save of zoom factor and mode for normal view and slides sorter. Also eliminate page and width options of zooming in Slides Sorter (these options doesn't make much sense in that view).
Finally I eliminate the white space around the slide because it make the slide lost focus when zooming and when I restore the previous zoom value (the zoom function center the white space too), in addition the white space make too big the default size of shapes when inserted.
(I ask in calligra channel, and the white space was added to have an area for insert things, maybe it could be added in a better way).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">build and run</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kpresenter/part/KPrView.h <span style="color: grey">(80b67520be60500ecf11df0827f1d4ee8eeab4e7)</span></li>
<li>kpresenter/part/KPrView.cpp <span style="color: grey">(aef56d9fcb919a314f0095629bea1927916f8059)</span></li>
<li>kpresenter/part/KPrViewModeSlidesSorter.h <span style="color: grey">(ec5f6691072115eb7818f1eb224f6a03fe9bf13c)</span></li>
<li>kpresenter/part/KPrViewModeSlidesSorter.cpp <span style="color: grey">(b4fee3c755aebf65e9bff0cef5516776533ec4a6)</span></li>
<li>libs/kopageapp/KoPAView.cpp <span style="color: grey">(c53edecb309098949f66e9d50238bc60f26f9bee)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101129/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>