<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100918/">http://git.reviewboard.kde.org/r/100918/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 11th, 2011, 1:06 p.m., <b>Matus Uzak</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/100918/diff/3/?file=14108#file14108line2022" style="color: black; font-weight: bold; text-decoration: underline;">plugins/textshape/TextShapeLayout.cpp</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void TextShapeLayout::drawListItem(QPainter *painter, const QTextBlock &block, KoImageCollection *imageCollection)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">2007</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span><span class="n">listFormat</span><span class="p">.</span><span class="n">hasProperty</span><span class="p">(</span><span class="n">KoListStyle</span><span class="o">::</span><span class="n">BulletSize</span><span class="p">))</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I would still appreciate if you could rename KoListStyle::BulletSize into KoListStyle::RelativeBulletSize. The name RelativeBulletSize evokes the usage of percentage values, whereas the name BulletSize usage of absolute values. </pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Well, sure... But let's get the patch committed, then we can change that. I think that patches are lingering too long on reviewboard again at the moment.</pre>
<br />
<p>- Boudewijn</p>
<br />
<p>On April 10th, 2011, 4:09 a.m., Gopalakrishna Bhat wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Gopalakrishna Bhat.</div>
<p style="color: grey;"><i>Updated April 10, 2011, 4:09 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fixes the following problems in list rendering
1)The type of list item was not shown in the paragraph docker(SimpleParagraphWidget).
2)Takes into account the font-size percent while loading and saving lists.
3) Prefixes and suffixes are now displayed for bulleted lists.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=260099">260099</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=264143">264143</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>filters/words/oowriter/oowriterimport.cc <span style="color: grey">(2bd55ee)</span></li>
<li>libs/kotext/styles/KoCharacterStyle.h <span style="color: grey">(0c9cc9c)</span></li>
<li>libs/kotext/styles/KoCharacterStyle.cpp <span style="color: grey">(072cb2f)</span></li>
<li>libs/kotext/styles/KoListLevelProperties.h <span style="color: grey">(14814fe)</span></li>
<li>libs/kotext/styles/KoListLevelProperties.cpp <span style="color: grey">(62a5175)</span></li>
<li>libs/kotext/styles/KoListStyle.h <span style="color: grey">(bee4eaf)</span></li>
<li>libs/kotext/styles/KoListStyle.cpp <span style="color: grey">(52d7c2f)</span></li>
<li>libs/odf/KoStyleStack.h <span style="color: grey">(2f4d2cf)</span></li>
<li>libs/odf/KoStyleStack.cpp <span style="color: grey">(491f14e)</span></li>
<li>plugins/textshape/ListItemsHelper.cpp <span style="color: grey">(aa61481)</span></li>
<li>plugins/textshape/TextShapeLayout.cpp <span style="color: grey">(b980379)</span></li>
<li>plugins/textshape/commands/ChangeListCommand.cpp <span style="color: grey">(23eeee0)</span></li>
<li>plugins/textshape/dialogs/ParagraphBulletsNumbers.cpp <span style="color: grey">(14c5fd7)</span></li>
<li>plugins/textshape/dialogs/SimpleParagraphWidget.cpp <span style="color: grey">(a991665)</span></li>
<li>plugins/textshape/tests/TestChangeListCommand.cpp <span style="color: grey">(4da46d1)</span></li>
<li>plugins/textshape/tests/TestLists.cpp <span style="color: grey">(316f5f6)</span></li>
<li>tools/mobile/ApplicationController.cpp <span style="color: grey">(83ebe6e)</span></li>
<li>words/part/KWDLoader.cpp <span style="color: grey">(e99435a)</span></li>
<li>words/part/KWDocument.cpp <span style="color: grey">(21ce4ba)</span></li>
<li>words/plugins/scripting/Style.h <span style="color: grey">(a72c0d2)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100918/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>