<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101022/">http://git.reviewboard.kde.org/r/101022/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 4th, 2011, 6:31 a.m., <b>Casper Boemann</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think the 100% should staty. That is what Anna-lisa said too
Also I'm not either for or against it, but the options in the widget in the bottom corner is removed too with this patch</pre>
</blockquote>
<p>On April 4th, 2011, 10:15 p.m., <b>Suresh Chande</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">by "but the options in the widget in the bottom corner is removed too with this patch" I guess you are talking about the slider for zooming, right ?. There was a discussion to add the slider into the zoom. i am not entirely comfortable as this is not totally according the UI Experience where a slider exists inside a drop-down menu.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">What Casper means is the different zoom levels in the combobox in the bottom left corner. I personally think those should stay, so instead of modifying the zoom action, which provides those zoom levels, you might want to look at the code where these zoom levels are added to the menu.</pre>
<br />
<p>- Arjen</p>
<br />
<p>On April 3rd, 2011, 9:12 p.m., Suresh Chande wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra, Marijn Kruisselbrink, Thorsten Zachmann, and Casper Boemann.</div>
<div>By Suresh Chande.</div>
<p style="color: grey;"><i>Updated April 3, 2011, 9:12 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ok Here comes my first fix..
Here is my fix I made to the zoom levels based on discussion and agreement at the Calligra sprint that we do not want to have 33, 57 and 127 etc % zoom levels . This fix removes the different zoom levels but leaves fit to width and fit to page.
See testing done, Any suggestion how this should be it be fixed for Tables ?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This was tested in the Words and Stage application and it functions according to expected outcome. I tested the Tables it seems as Tables does not have Fit to Width or Fit to Page the menu is currently empty. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/widgets/KoZoomAction.cpp <span style="color: grey">(488652c)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101022/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>