<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100938/">http://git.reviewboard.kde.org/r/100938/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good to me .As this is an app setting it makes sense to handle it that way.
One thing I noted when testing the patch is that if the handles are big it is not possible to select the handle at the full handle size. Only if you go to the center you can select it.</pre>
<br />
<p>- Thorsten</p>
<br />
<p>On March 23rd, 2011, 10:21 p.m., Jan Hambrecht wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Jan Hambrecht.</div>
<p style="color: grey;"><i>Updated March 23, 2011, 10:21 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch changes the scope of the handle radius and grab sensitivity settings from the canvas resource to the document resource. I also added some convenience functions to KoToolBase and KoInteractionStrategy so that users of these settings do not need to know from which resource manager to pulle these settings. This fixes changing both settings from the shared config page used in karbon, kpresenter and flow.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>karbon/plugins/tools/KarbonGradientTool.cpp <span style="color: grey">(44fe28b)</span></li>
<li>karbon/plugins/tools/KarbonPatternTool.cpp <span style="color: grey">(476787d)</span></li>
<li>karbon/plugins/tools/KarbonPencilTool.cpp <span style="color: grey">(2238fe4)</span></li>
<li>karbon/plugins/tools/filterEffectTool/KarbonFilterEffectsTool.cpp <span style="color: grey">(8f7a40f)</span></li>
<li>karbon/ui/KarbonPart.cpp <span style="color: grey">(9c63c14)</span></li>
<li>libs/flake/KoResourceManager.h <span style="color: grey">(bc93692)</span></li>
<li>libs/flake/KoResourceManager.cpp <span style="color: grey">(da12bb5)</span></li>
<li>libs/flake/KoShapeControllerBase.cpp <span style="color: grey">(6352fd6)</span></li>
<li>libs/flake/KoToolBase.h <span style="color: grey">(db16ac2)</span></li>
<li>libs/flake/KoToolBase.cpp <span style="color: grey">(52090a2)</span></li>
<li>libs/flake/tools/KoCreatePathTool.cpp <span style="color: grey">(884ea1f)</span></li>
<li>libs/flake/tools/KoCreatePathTool_p.h <span style="color: grey">(a9b2ee6)</span></li>
<li>libs/flake/tools/KoInteractionStrategy.h <span style="color: grey">(2f45219)</span></li>
<li>libs/flake/tools/KoInteractionStrategy.cpp <span style="color: grey">(a730c3d)</span></li>
<li>libs/flake/tools/KoPathTool.cpp <span style="color: grey">(6c38ca5)</span></li>
<li>libs/flake/tools/KoPathToolHandle.h <span style="color: grey">(f11ea34)</span></li>
<li>libs/flake/tools/KoPathToolHandle.cpp <span style="color: grey">(e5eea1f)</span></li>
<li>libs/flake/tools/KoPathToolSelection.cpp <span style="color: grey">(6372e8d)</span></li>
<li>libs/main/config/KoConfigMiscPage.cpp <span style="color: grey">(71140ca)</span></li>
<li>plugins/defaultTools/connectionTool/ConnectionTool.cpp <span style="color: grey">(f19d256)</span></li>
<li>plugins/defaultTools/connectionTool/MoveConnectionPointStrategy.cpp <span style="color: grey">(582cdd7)</span></li>
<li>plugins/defaultTools/defaulttool/DefaultTool.cpp <span style="color: grey">(1e33ca4)</span></li>
<li>plugins/defaultTools/defaulttool/ShapeMoveStrategy.cpp <span style="color: grey">(e0cc028)</span></li>
<li>plugins/defaultTools/defaulttool/ShapeResizeStrategy.cpp <span style="color: grey">(32cb211)</span></li>
<li>plugins/defaultTools/defaulttool/ShapeRotateStrategy.cpp <span style="color: grey">(30b8d84)</span></li>
<li>plugins/defaultTools/defaulttool/ShapeShearStrategy.cpp <span style="color: grey">(f2ec9e1)</span></li>
<li>plugins/defaultTools/guidestool/GuidesTool.cpp <span style="color: grey">(631c61a)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100938/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>