<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100809/">http://git.reviewboard.kde.org/r/100809/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Jan Hambrecht.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch implements clipping for shapes using arbitrary clipping paths. This is needed to properly support svg clipping.
There is a new class KoClipPath which can be set on a shape. The clipping path is then used when painting the shape to set the clipping path on the painter.
There are also two commands to set and to unset a clipping path on a shape.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested with svg files from the svg test suite as well as some kde icons like akregator.svgz (see bug 264411)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>filters/karbon/svg/CMakeLists.txt <span style="color: grey">(2a89825)</span></li>
<li>filters/karbon/svg/SvgClipPathHelper.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/karbon/svg/SvgClipPathHelper.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/karbon/svg/SvgGraphicContext.h <span style="color: grey">(dbb28ae)</span></li>
<li>filters/karbon/svg/SvgParser.h <span style="color: grey">(c9a09b1)</span></li>
<li>filters/karbon/svg/SvgParser.cpp <span style="color: grey">(0372fde)</span></li>
<li>filters/karbon/svg/svgexport.h <span style="color: grey">(6689299)</span></li>
<li>filters/karbon/svg/svgexport.cc <span style="color: grey">(7627006)</span></li>
<li>karbon/data/karbon.rc <span style="color: grey">(cf0a238)</span></li>
<li>karbon/ui/KarbonView.h <span style="color: grey">(235720f)</span></li>
<li>karbon/ui/KarbonView.cpp <span style="color: grey">(c4e3603)</span></li>
<li>libs/flake/CMakeLists.txt <span style="color: grey">(e153e14)</span></li>
<li>libs/flake/KoClipPath.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/flake/KoClipPath.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/flake/KoShape.h <span style="color: grey">(b4b3033)</span></li>
<li>libs/flake/KoShape.cpp <span style="color: grey">(c5f0fd9)</span></li>
<li>libs/flake/KoShapeManager.cpp <span style="color: grey">(7f225f9)</span></li>
<li>libs/flake/KoShapeManagerPaintingStrategy.cpp <span style="color: grey">(4a267c5)</span></li>
<li>libs/flake/KoShape_p.h <span style="color: grey">(5874cbd)</span></li>
<li>libs/flake/commands/KoShapeClipCommand.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/flake/commands/KoShapeClipCommand.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/flake/commands/KoShapeUnclipCommand.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/flake/commands/KoShapeUnclipCommand.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100809/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>