<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100716/">http://git.reviewboard.kde.org/r/100716/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Marijn Kruisselbrink.</div>
<p style="color: grey;"><i>Updated Feb. 23, 2011, 11:48 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It now at least shows the preview inline in the file dialog (when run in KDE), getting rid of the second preview is a bit more difficult due to the async nature of KIO (and the potential for a long wait for a remote image). If you insert a remote image currently the UI will not block, but you just won't see an image in the dialog/will be able to insert an image until the download is completed (you are able to cancel insertion though). I guess we somehow could do this in the background in some other way, but doing that without blocking the UI is tricky.
I haven't yet done anything about the size of the preview.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This changes KoImageSelectionWidget to no longer be a widget that embeds a KFileWidget, but instead show a KFileDialog to select a file. This should make it for example feel more native when run on windows, as you get a real file dialog. The overall behavior of the widget hasn't really changed with this diff, after selecting a file in the dialog/widget, you still get a preview of the image and can Ok/Cancel it.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/main/KoImageSelectionWidget.h <span style="color: grey">(737ffdc3f655eaffb31eeb569384fe2b6c8aa678)</span></li>
<li>libs/main/KoImageSelectionWidget.cpp <span style="color: grey">(92c6d215b1a4c30607b1855dd517cfbce61bdda7)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100716/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>