Hello All,<div><br></div><div>I need your comments/Inputs for the possible solutions,</div><div><br></div><div>1. Write a Wrapper class for KoAbstractApplicationController which would have all the slots and signals in it and Child(MainWindow) can create a object of the wrapper and connect the signals to it.</div>
<div><br></div><div>2. Remove QMainWindow inheritance from MainWindow.h and have it as a private member of MainWindow class. In this approach we can make KoAbstractApplicationContoller to Inherit from QObject. </div><div>
<br></div><div>3. Have the same design but while building check if it is built out-of-source-tree and add/remove headers from KoAbstraction.</div><div><br></div><div>Jaroslaw, Thanks for your hint. But I guess it can't be used in this scenario. since we need to define slots in children(MainWindow.cpp) as well. Or Have I got it wrong ? </div>
<div><br></div><div>Br,</div><div>Mani<br><br><div class="gmail_quote">On Tue, Feb 1, 2011 at 1:14 PM, Jaroslaw Staniek <span dir="ltr"><<a href="mailto:staniek@kde.org">staniek@kde.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<div>ok.. small hint; by coincidence I've encountered KEXI_DATAAWAREOBJECTINTERFACE code in kexi/widget/tableview/kexidataawareobjectiface.h. It'a a Q_OBJECT-like macro that inserts connecting methods to a class. Maybe similar macro could be useful in this case.<br>
</div><div><br></div><br><div class="gmail_quote">2011/2/1 Mani N C <span dir="ltr"><<a href="mailto:maninc@gmail.com" target="_blank">maninc@gmail.com</a>></span><div><div></div><div class="h5"><br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
My bad, I agree we won't be able to connect signals. The problem I have is when f-office is compiled out-of-tree the gives errors. I am trying to fix this in such a way that it would compile in-source and out-of-tree. Thanks for your comments, I will try to emit pure virtual methods and see.<div>
<br></div><div>Br,</div><div>Mani<div><div><br><br><div class="gmail_quote">On Mon, Jan 31, 2011 at 7:23 PM, Jarosław Staniek <span dir="ltr"><<a href="mailto:staniek@kde.org" target="_blank">staniek@kde.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div>
<div style="font-family:Verdana, Arial, Helvetica, Sans-Serif"><div>
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border:1px #c9c399 solid">
<tbody><tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100462/" target="_blank">http://git.reviewboard.kde.org/r/100462/</a>
</td>
</tr>
</tbody></table>
<br>
</div><pre style="white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">One of the solutions is to have emit*() pure virtual methods in the controller and implement them in f-office to emit real signals.
Sebastian, you wrote in ba54ba08 3 days ago that something did not build. But it did before...</pre><div>
<br>
<p>- Jarosław</p>
<br>
<p>On January 31st, 2011, 12:07 p.m., Mani Chandrasekar wrote:</p>
</div><table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-repeat:repeat-x;border:1px black solid">
<tbody><tr>
<td><div>
<div>Review request for Calligra.</div>
<div>By Mani Chandrasekar.</div>
</div><p style="color:grey"><i>Updated Jan. 31, 2011, 12:07 p.m.</i></p>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Description </h1><div>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border:1px solid #b8b5a0">
<tbody><tr>
<td>
<pre style="margin:0;padding:0;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">This patch removes KoAbstraction class which implements KoAbstractionContorller.
Since we are reimplementing most of the functions in MainWindow.cpp I have removed KoAbstraction class and moved all the signals to MainWindow
I feel the implementation should be in freoffice code instead of abstraction library.
Is there any possible drawbacks in this approach? </pre> </td>
</tr>
</tbody></table>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Diffs </h1>
<ul style="margin-left:3em;padding-left:0">
<li>tools/CMakeLists.txt <span style="color:grey">(d4e6ab5)</span></li>
<li>tools/f-office/CMakeLists.txt <span style="color:grey">(a212bc0)</span></li>
<li>tools/f-office/MainWindow.h <span style="color:grey">(f7b6149)</span></li>
<li>tools/f-office/MainWindow.cpp <span style="color:grey">(549b7d1)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100462/diff/" style="margin-left:3em" target="_blank">View Diff</a></p>
</div></td>
</tr>
</tbody></table>
</div>
</div>
</blockquote></div><br><br clear="all"><br></div></div>-- <br>Mani Chandrasekar<br><br>
</div>
</blockquote></div></div></div><font color="#888888"><br><br clear="all"><br>-- <br>regards / pozdrawiam, Jaroslaw Staniek<br> <a href="http://www.linkedin.com/in/jstaniek" target="_blank">http://www.linkedin.com/in/jstaniek</a><br>
Kexi & Calligra (<a href="http://kexi-project.org" target="_blank">kexi-project.org</a>, <a href="http://identi.ca/kexi" target="_blank">identi.ca/kexi</a>, <a href="http://calligra-suite.org" target="_blank">calligra-suite.org</a>)<br>
KDE Software Development Platform on MS Windows (<a href="http://windows.kde.org" target="_blank">windows.kde.org</a>)<br>
</font></blockquote></div><br><br clear="all"><br>-- <br>Mani Chandrasekar<br><br>
</div>