<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100508/">http://git.reviewboard.kde.org/r/100508/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I like it, also because it removes another hard-coded dependency on KoCanvasControllerWidget.</pre>
<br />
<p>- Boudewijn</p>
<br />
<p>On February 1st, 2011, 1:14 p.m., Sven Langkamp wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Sven Langkamp.</div>
<p style="color: grey;"><i>Updated Feb. 1, 2011, 1:14 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Currently there is a problem when you switch the input device to tablet. By default only the actions for the mouse input device are in the action collection. After switching the input device the tool is changed, but the new actions are not added to the action collection.
With the patch the actions of the old tool are taken form the action collection and the new added. Also copies the shortcuts as they might have changed.
Applications that want to use this have to provide an action collection in the canvas controller.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fixes bug 258066.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=258066">258066</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>krita/ui/kis_view2.cpp <span style="color: grey">(037a110)</span></li>
<li>libs/flake/KoCanvasController.h <span style="color: grey">(317548d)</span></li>
<li>libs/flake/KoCanvasController.cpp <span style="color: grey">(21d5f8a)</span></li>
<li>libs/flake/KoToolManager.cpp <span style="color: grey">(2db9bc1)</span></li>
<li>libs/flake/KoToolManager_p.h <span style="color: grey">(8ec6614)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100508/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>