<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100447/">http://git.reviewboard.kde.org/r/100447/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 27th, 2011, 5:53 a.m., <b>Thorsten Zachmann</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/100447/diff/1/?file=7595#file7595line80" style="color: black; font-weight: bold; text-decoration: underline;">libs/flake/KoConnectionPoint.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">struct FLAKE_EXPORT KoConnectionPoint</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">80</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">QPointF</span> <span class="n">position</span><span class="p">;</span> <span class="c1">///< the position of the connection point in shape coordinates</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The point are not stored in shape coordinates but in percentage value of the size</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">How it is stored internally is just an implementation detail. Once the connection point gets passed outside the shape via KoShape::connectionPoint, KoShape::connectionPoints, the position is converted to shape coordinates. So I think the comment is correct.</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 27th, 2011, 5:53 a.m., <b>Thorsten Zachmann</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/100447/diff/1/?file=7598#file7598line86" style="color: black; font-weight: bold; text-decoration: underline;">libs/flake/KoConnectionShape.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">enum HandleId {</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">86</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">KoFlake</span><span class="o">::</span><span class="n">Position</span> <span class="n">corners</span><span class="p">[</span><span class="mi">4</span><span class="p">]</span> <span class="o">=</span> <span class="p">{</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Please define as const</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ok</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 27th, 2011, 5:53 a.m., <b>Thorsten Zachmann</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/100447/diff/1/?file=7606#file7606line340" style="color: black; font-weight: bold; text-decoration: underline;">libs/flake/KoTextOnShapeContainer.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void KoTextOnShapeContainer::saveOdfChildElements(KoShapeSavingContext &context) const</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">340</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">return</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You are sure this should be committed? Yes I know with KoTextOnShapeContainer some of the stuff does not work</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Oops, no. That was an accident.</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 27th, 2011, 5:53 a.m., <b>Thorsten Zachmann</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/100447/diff/1/?file=7623#file7623line106" style="color: black; font-weight: bold; text-decoration: underline;">plugins/defaultTools/connectionTool/ConnectionTool.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">private:</pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">79</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="kt"><span class="hl">float</span></span><span class="hl"> </span><span class="n"><span class="hl">d</span>istance<span class="hl">Square</span></span><span class="p"><span class="hl">(</span></span> <span class="n">QPointF</span> <span class="n">p1</span><span class="p">,</span> <span class="n">QPointF</span> <span class="n">p2</span> <span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">92</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n"><span class="hl">qreal</span></span><span class="hl"> </span><span class="n"><span class="hl">squareD</span>istance</span><span class="p"><span class="hl">(</span></span><span class="hl"> </span><span class="k"><span class="hl">const</span></span> <span class="n">QPointF</span> <span class="o"><span class="hl">&</span></span><span class="n">p1</span><span class="p">,</span><span class="hl"> </span><span class="k"><span class="hl">const</span></span> <span class="n">QPointF</span> <span class="o"><span class="hl">&</span></span><span class="n">p2</span> <span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">this method should be const</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ok</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 27th, 2011, 5:53 a.m., <b>Thorsten Zachmann</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/100447/diff/1/?file=7623#file7623line125" style="color: black; font-weight: bold; text-decoration: underline;">plugins/defaultTools/connectionTool/ConnectionTool.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">private:</pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">98</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">KoConnectionShape</span> <span class="o">*</span> <span class="n"><span class="hl">m_la</span>stConnectionShape<span class="hl">On</span></span><span class="p">;</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">111</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">KoConnectionShape</span> <span class="o">*</span> <span class="n"><span class="hl">neare</span>stConnectionShape</span><span class="p"><span class="hl">(</span></span><span class="n"><span class="hl">QList</span></span><span class="o"><span class="hl"><</span></span><span class="n"><span class="hl">KoShape</span></span><span class="o"><span class="hl">*></span></span><span class="hl"> </span><span class="n"><span class="hl">shapes</span></span><span class="p"><span class="hl">,</span></span><span class="hl"> </span><span class="k"><span class="hl">const</span></span><span class="hl"> </span><span class="n"><span class="hl">QPointF</span></span><span class="hl"> </span><span class="o"><span class="hl">&</span></span><span class="n"><span class="hl">mousePos</span></span><span class="p"><span class="hl">)</span>;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">shapes should be passed as const &
Can the function be made const?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Sure, that was just an oversight.</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 27th, 2011, 5:53 a.m., <b>Thorsten Zachmann</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/100447/diff/1/?file=7623#file7623line131" style="color: black; font-weight: bold; text-decoration: underline;">plugins/defaultTools/connectionTool/ConnectionTool.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">private:</pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">117</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">KoShape</span> <span class="o">*</span> <span class="n">findShapeAtPosition</span><span class="p">(</span><span class="k">const</span> <span class="n">QPointF</span> <span class="o">&</span><span class="n">position</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">please make the function const.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ok</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 27th, 2011, 5:53 a.m., <b>Thorsten Zachmann</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/100447/diff/1/?file=7624#file7624line279" style="color: black; font-weight: bold; text-decoration: underline;">plugins/defaultTools/connectionTool/ConnectionTool.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">160</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">KoConnectionShape</span> <span class="o">*</span> <span class="n">connectionShapeTest</span> <span class="o">=</span> <span class="k">dynamic_cast</span><span class="o"><</span><span class="n">KoConnectionShape</span><span class="o">*></span><span class="p">(</span><span class="n">tempShape</span><span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">237</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span><span class="p">(</span><span class="o">!</span><span class="n">connectionShape</span><span class="p">)</span> <span class="p">{</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">there should be a blank after the if</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ok</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 27th, 2011, 5:53 a.m., <b>Thorsten Zachmann</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/100447/diff/1/?file=7624#file7624line529" style="color: black; font-weight: bold; text-decoration: underline;">plugins/defaultTools/connectionTool/ConnectionTool.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">348</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">m_connectionShape</span><span class="o">-></span><span class="n">connectSecond</span><span class="p">(</span><span class="n">shape2</span> <span class="p">,</span> <span class="n">getConnectionIndex</span><span class="p">(</span><span class="n">shape2</span><span class="p">,</span> <span class="n">shape1</span><span class="o">-></span><span class="n">absolutePosition</span><span class="p">()));</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">438</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="kt">int</span> <span class="n">ConnectionTool</span><span class="o">::</span><span class="n">handleAtPoint</span><span class="p">(</span><span class="n">KoShape</span> <span class="o">*</span><span class="n">shape</span><span class="p">,</span> <span class="k">const</span> <span class="n">QPointF</span> <span class="o">&</span><span class="n">mousePoint</span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Can the function made const?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Sure.</pre>
<br />
<p>- Jan</p>
<br />
<p>On January 27th, 2011, 11:08 p.m., Jan Hambrecht wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Jan Hambrecht.</div>
<p style="color: grey;"><i>Updated Jan. 27, 2011, 11:08 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch properly implements support for odf glue points (=connection points in flake) as defined in the ODF specification.
The following are some of the main points tackled:
* a new struct KoConnectionPoint which holds the relevant data of a connection point
* some new API in KoShape to handle connection points
* loading of custom connection points and their attributes like escape direction and align
* saving of connection points
* huge improvement to the connection tool which now can also create, delete and edit connection points
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested with the document attached to the bug report as well as with documents created with LibreOffice.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=251529">251529</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kexi/shapes/relationdesign/kexirelationdesignshape.cpp <span style="color: grey">(27604d4)</span></li>
<li>libs/flake/CMakeLists.txt <span style="color: grey">(0447004)</span></li>
<li>libs/flake/KoConnectionPoint.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/flake/KoConnectionPoint.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/flake/KoConnectionShape.h <span style="color: grey">(862d41b)</span></li>
<li>libs/flake/KoConnectionShape.cpp <span style="color: grey">(8430eb0)</span></li>
<li>libs/flake/KoConnectionShapeLoadingUpdater.cpp <span style="color: grey">(0bd834c)</span></li>
<li>libs/flake/KoConnectionShape_p.h <span style="color: grey">(ea3b0ba)</span></li>
<li>libs/flake/KoOdfWorkaround.h <span style="color: grey">(e6a5c63)</span></li>
<li>libs/flake/KoOdfWorkaround.cpp <span style="color: grey">(36fd86b)</span></li>
<li>libs/flake/KoShape.h <span style="color: grey">(f7179d7)</span></li>
<li>libs/flake/KoShape.cpp <span style="color: grey">(c5aee86)</span></li>
<li>libs/flake/KoShape_p.h <span style="color: grey">(f52ba8c)</span></li>
<li>libs/flake/tools/KoParameterChangeStrategy.h <span style="color: grey">(a10e54f)</span></li>
<li>libs/flake/tools/KoParameterChangeStrategy.cpp <span style="color: grey">(925602f)</span></li>
<li>libs/flake/tools/KoParameterChangeStrategy_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/flake/tools/KoPathConnectionPointStrategy.h <span style="color: grey">(2ec9467)</span></li>
<li>libs/flake/tools/KoPathConnectionPointStrategy.cpp <span style="color: grey">(15764bc)</span></li>
<li>libs/flake/tools/KoPathConnectionPointStrategy_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/flake/tools/KoPathTool.h <span style="color: grey">(c863f11)</span></li>
<li>libs/flake/tools/KoPathTool.cpp <span style="color: grey">(fe9351a)</span></li>
<li>plugins/defaultTools/CMakeLists.txt <span style="color: grey">(7bd62ce)</span></li>
<li>plugins/defaultTools/connectionTool/AddConnectionPointCommand.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/defaultTools/connectionTool/AddConnectionPointCommand.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/defaultTools/connectionTool/ChangeConnectionPointCommand.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/defaultTools/connectionTool/ChangeConnectionPointCommand.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/defaultTools/connectionTool/ConnectionPointWidget.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/defaultTools/connectionTool/ConnectionPointWidget.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/defaultTools/connectionTool/ConnectionPointWidget.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/defaultTools/connectionTool/ConnectionTool.h <span style="color: grey">(c0af323)</span></li>
<li>plugins/defaultTools/connectionTool/ConnectionTool.cpp <span style="color: grey">(a25b0d7)</span></li>
<li>plugins/defaultTools/connectionTool/ConnectionToolWidget.h <span style="color: grey">(17e072e)</span></li>
<li>plugins/defaultTools/connectionTool/ConnectionToolWidget.cpp <span style="color: grey">(d7211ad)</span></li>
<li>plugins/defaultTools/connectionTool/ConnectionToolWidget.ui <span style="color: grey">(6249ba4)</span></li>
<li>plugins/defaultTools/connectionTool/MoveConnectionPointStrategy.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/defaultTools/connectionTool/MoveConnectionPointStrategy.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/defaultTools/connectionTool/RemoveConnectionPointCommand.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/defaultTools/connectionTool/RemoveConnectionPointCommand.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/defaultTools/pics/CMakeLists.txt <span style="color: grey">(c64a256)</span></li>
<li>plugins/defaultTools/pics/hi16-action-escape-direction-all.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/defaultTools/pics/hi16-action-escape-direction-down.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/defaultTools/pics/hi16-action-escape-direction-horizontal.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/defaultTools/pics/hi16-action-escape-direction-left.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/defaultTools/pics/hi16-action-escape-direction-right.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/defaultTools/pics/hi16-action-escape-direction-up.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/defaultTools/pics/hi16-action-escape-direction-vertical.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/treeshape/Layout.cpp <span style="color: grey">(3b1a7ea)</span></li>
<li>plugins/treeshape/TreeShapeMoveStrategy.cpp <span style="color: grey">(cf20400)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100447/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>